[ http://jira.jboss.com/jira/browse/JBWS-2106?page=comments#action_12409955 ] Andrew Dinn commented on JBWS-2106: ----------------------------------- Your resolution of this issue is incomplete in that it only addresses the issue of how to configure the Action and FaultAction. It does not address how to specify the remaining WS Addressing fields. Specifically, the Web Services Transaction implementation needs also to be able to define the ReplyTo, FaultTo, MessageId and RelatesTo properties when invoking a web service via a stub and needs to be able to retrieve these properties plus the To address inside an SEI class. This feature request can only be resolved in a _portable_ manner by providing an implementation of the javax AddressingProperties class and an associated AddressingPropertiesBuilder class and integrating them into _all_three_ WS stacks. Resolution also requires detection of an AddressingProeprties property on a client stub and the ability to retrieve the incoming AddressingProperties via an injected WebServiceContext. I am aware of the fact that this functionality is not yet available in CXF. That is why I created this feature request, to record the fact that it is currently missing and request that this omission be addressed at some point. Actually, your account is not quite the full story. CXF 2.0 provides its own implementation of the AddressingProperties/Builder classes and both recognizes them on the client side and makes them available on the server side. Teh problem is that it does not make this functionality available using the javax APIs. Instead it requires the client to employ CXF-specific implementation classes. All of the requested features are quite satisfactorily implemented in JBossWS native. Metro does not yet have an implementation of these APIs but it is quite feasible to add one without modification ot the Metro sources (I did so in a prototype of the WSTX code running on Glassfish). This request cannot be resolved by something which does not address the requirements stated above. I would be grateful if you would reopen this feature request and leave it open pending provision of an implementation of the relevant APIs in either i) CXF/Metro or ii) the JBossWS integration layer. Alternatively, if you have a good reason to reject the request please advise. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ http://jira.jboss.com/jira/browse/JBWS-2106?page=comments#action_12410466 ] Richard Opalka commented on JBWS-2106: -------------------------------------- Only the following annotations and classes are part of public JAX-WS 2.1 API: javax.xml.ws.wsaddressing.W3CEndpointReferenceBuilder javax.xml.ws.soap.Addressing javax.xml.ws.soap.AddressingFeature Here's how annotations are going to be used with JAX-WS api: http://weblogs.java.net/blog/ramapulavarthi/archive/2006/09/support_for_w... I'm afraid it won't be possible to port our proprietary javax.xml.ws.addressing package to JBossWS-CXF integration. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Alessio Soldano updated JBWS-2106: ---------------------------------- Summary: javax.xml.ws.addressing package not available in JBossWS-CXF (was: Provide WS-Addressing implementation that satisfies JAX-WS 2.1 in JBossWS-CXF) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Andrew Dinn commented on JBWS-2106: ----------------------------------- Hi Alessio, Yes, cxf does implement the required AddressingProperties class but in a different package to the one used by Native, as are the other types provided by CXF. I probably could use their implementation to get my code to run on the CXF stack -- it looked to be pretty complete when I used it. The problem is how to use it compatibly with the Native JBossWS implementation. A lot of the methods in my current XTS build are currently parameterised with AddressingProperties instances or employ local values of this type. The same applies for the various dependent types employed in conjunction with AddressingProperties as AddressingBuilder, AttributedURI, Relationship, etc.. I need to be able to manipulate these types in order to construct faultto, replyto etc addresses. I don't really see how to generalize the code so that my code can operate over both stacks. Do you have any ideas how to resolve this? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Alessio Soldano commented on JBWS-2106: --------------------------------------- OK, I've spent some time trying to adapt the CXF internal addressing API (CXF actually supports multiple ws-addressing versions) to our javax.xml.ws.addressing API. This was done moving our native API to jbossws-common and having another AddressingBuilder implementation for JBossWS-CXF, implementing our AddressingBuilder while extending the CXF builder. Besides being an hacky solution, this proved to be not viable as the two APIs have incompatible implementations of some fields, for instance RelatesToType vs. our Relationship[]. Perhaps the latter could be revisited, but I'm not really willing to do that now, as it would break backward compatibility. So, unless someone has a brilliant idea for solving this, I'd unschedule this issue untill the JAX-WS EG address the JSR-261 stuff addition in a future relase (as we asked for). -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Andrew Dinn commented on JBWS-2106: ----------------------------------- I have bypassed this problem by creating an abstraction layer in the XTS code which hides all uses of the AddressingProperties class and its close relatives. Alternative implementations for Native and CXF are included (it comprises only 5 classes in all). See: http://anonsvn.jboss.org/repos/labs/labs/jbosstm/trunk/XTS/WS-C/dev/src11... and http://anonsvn.jboss.org/repos/labs/labs/jbosstm/trunk/XTS/WS-C/dev/src11... A consequence of adopting this abstraction layer is that the XTS code is now dual source/binary. This complicates the build, deploy and test processes. It would be easier if this compatibility library was deployed by JBossWS. This would also provide a starting point for other JBossWS clients who wish to have a portable API for WSA. Perhaps you could look at the code and i) see if it could be extended with any missing capabilities or revised and cleaned up ii) advise on the feasibility of transferring it from TS to WS. I have not yet commented the API of MAP and its related classes so the way it works may not be entirely clear. Amongst the trickier details the following are especially noteworthy. I dealt with the RelatesTo problem by limiting the API to only allow one relationship to be managed. There is some trickery required when attempting to install the outbound AddressingProperties for a port derived from a W3CEndpointReference. In Native the AddressingProperties are pre-installed by the getPort call with To defined and with the ReferenceProperty elements stashed as a property of the AddressingContext. In CXF you get a port which has no AddressingProperties object on the request context. The To/ReferenceProperty values seem to have been stashed away somewhere else so they still get used. So, when you add other WSA properties the routine which fetches the outbound map creates an AddressingProperties object on the fly at first access. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Alessio Soldano commented on JBWS-2106: --------------------------------------- I've committed some interfaces and the native impl. Still need to figure out if the classes are to live there (perhaps the interfaces will be moved to jbossws-common). Tomorrow I'll try converting a couple of the old ws-addressing testcase to use the common api. In the meantime, if you could take a look if the the interfaces would be OK for the WSTX prj, that would be good. I've added a getRefereceParameters in MAP and done a couple of changes in the native impl to support the common API. http://fisheye.jboss.org/changelog/JBossWS/?cs=10109 http://fisheye.jboss.org/changelog/JBossWS/?cs=10110 -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Alessio Soldano updated JBWS-2106: ---------------------------------- Summary: Unify Native and CXF api for JAX-WSA (JSR-261) (was: javax.xml.ws.addressing package not available in JBossWS-CXF) Fix Version/s: jbossws-native-3.2.0 jbossws-cxf-3.2.0 (was: jbossws-cxf-3.1.2) -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2106?page=com.atlassian.jira.plug... ] Alessio Soldano commented on JBWS-2106: --------------------------------------- OK, thanks Andrew. I've changed MAP and MAPBuilder: - public MAP inboundMap(MessageContext ctx); + public MAP inboundMap(Map<String, Object> ctx); but that should not be a problem, right? -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira