[ http://jira.jboss.com/jira/browse/JBWS-2166?page=comments#action_12416971 ] Andrew Dinn commented on JBWS-2166: ----------------------------------- Ok, I have two updates to this issue. Firstly, the same issue affects calls to initializeAsDestination when they supply an EndpointReference obtained from the incoming addressing properties. In this case also the reference parameters need copying. Secondly, I have upgraded the workaround to work with any reference parameters. Previously I was rebuilding a JBossTS reference parameter element using the same code as originally constructed the element. This only works when the format of the element is recognizable as created by JBoss i.e. when we are interoperating with JBoss. What I do now is use Node.cloneNode() to produce a copy of the original reference parameter element as a DOM Node/Element tree and then use SOAPFactory.copy() to convert the copy into a SOAP element tree. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2166?page=com.atlassian.jira.plug... ] Andrew Dinn commented on JBWS-2166: ----------------------------------- This same issue also appears to be causing regular failures when running the xts unit tests. However, in this case the offending reference parameter is not obtained from an incoming addressing context. In this case it is created from scratch using a soap factory and then attached to the faultto endpoint of an addressing context prior to a client invocation. It is hard to know what to do to work around this manifestation of the problem. After all if the soap element as originally created will causes a dom error why would it make any difference cloning the associated node and then using a soap factory to create a new soap element tree from the cloned dom node? This issue does not appear to be breaking the xts implementation itself (the demo still appears to run ok -- I'll be trying the rest of the system tests very soon). However, it is rather worrying that the unit tests are failing. This really needs fixing before 5.1 is released. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2166?page=com.atlassian.jira.plug... ] Andrew Dinn commented on JBWS-2166: ----------------------------------- When running on the 5.0.1 release this issue only appears to be affecting the unit tests. The xts demo program and the WSTX interop tests don't seem to fall foul of it. I have no idea why this is the case. Failures occur in some of the unit tests while other unit tests which construct and pass reference parameters in exactly the same way as the failing tests seem to succeed. What is most bizarre is that rerunning the tests in the same AS gives the same pattern of failure every time. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira

[ https://jira.jboss.org/jira/browse/JBWS-2166?page=com.atlassian.jira.plug... ] Andrew Dinn commented on JBWS-2166: ----------------------------------- HI Alessio, I think this may well fix initializeAsReply/Destination -- however, I am not sure it is the whole fix. The xts unit tests are also failing because of a wrong document exception. Here's the exception trace. javax.xml.ws.WebServiceException: org.w3c.dom.DOMException: WRONG_DOCUMENT_ERR: A node is used in a different document than the one that created it. at org.jboss.ws.core.jaxws.handler.HandlerChainExecutor.processHandlerFailure(HandlerChainExecutor.java:274) at org.jboss.ws.core.jaxws.handler.HandlerChainExecutor.handleMessage(HandlerChainExecutor.java:153) at org.jboss.ws.core.jaxws.client.ClientImpl.callRequestHandlerChain(ClientImpl.java:178) at org.jboss.ws.core.CommonClient.invoke(CommonClient.java:297) at org.jboss.ws.core.jaxws.client.ClientImpl.invoke(ClientImpl.java:291) at org.jboss.ws.core.jaxws.client.ClientProxy.invoke(ClientProxy.java:170) at org.jboss.ws.core.jaxws.client.ClientProxy.invoke(ClientProxy.java:150) at $Proxy163.commitOperation(Unknown Source) at com.arjuna.webservices11.wsat.client.CompletionCoordinatorClient.sendCommit(CompletionCoordinatorClient.java:105) at com.arjuna.wst11.tests.junit.CompletionParticipantTestCase.testSendCommit(CompletionParticipantTestCase . . . I don't see why this is getting the error because there is no copying involved. The client code which sets up the addressing properties and endpoint is included below. What is interesting is that this error is intermittent -- although when it happen it always happens in the same place. Only 8 of the WS-T tests fail but all of them set up addressing properties and endpoints. None of the WS-C tests fail but they do the same thing. <pre> class CompletionParticipantTestCase { . . . public void testSendCommit() throws Exception { final String messageId = "testSendCommit" ; final AddressingProperties addressingProperties = AddressingHelper.createRequestContext(TestUtil.completionCoordinatorServiceURI, messageId) ; final InstanceIdentifier instanceIdentifier = new InstanceIdentifier("1") ; final W3CEndpointReference endpoint = TestUtil.getCompletionCoordinatorEndpoint(instanceIdentifier.getInstanceIdentifier()); CompletionCoordinatorClient.getClient().sendCommit(endpoint, addressingProperties, new InstanceIdentifier("sender")) ; . . . Class CompletionCoordinatorClient { . . . public void sendCommit(final W3CEndpointReference endpoint, final AddressingProperties addressingProperties, final InstanceIdentifier identifier) throws SoapFault, IOException { EndpointReference initiator = getCompletionInitiator(endpoint); AddressingHelper.installFromFaultTo(addressingProperties, initiator, identifier); CompletionCoordinatorPortType port = getPort(endpoint, addressingProperties, commitAction); Notification commit = new Notification(); port.commitOperation(commit); } private CompletionCoordinatorPortType getPort(final W3CEndpointReference endpoint, final AddressingProperties addressingProperties, final AttributedURI action) { AddressingHelper.installNoneReplyTo(addressingProperties); return WSATClient.getCompletionCoordinatorPort(endpoint, action, addressingProperties); } . . . class AddressingHelper { . . . public static AddressingProperties createRequestContext(final String address, final String messageID) { AddressingBuilder builder = AddressingBuilder.getAddressingBuilder(); final AddressingProperties requestProperties = builder.newAddressingProperties(); requestProperties.setTo(makeURI(builder, address)); if (messageID != null) { requestProperties.setMessageID(makeURI(builder, messageID)); } else { // client does not care about id but we have to set some id or WSA will complain final String dummyID = MessageId.getMessageId(); requestProperties.setMessageID(makeURI(builder, dummyID)); } return requestProperties; } public static void installFromFaultTo(AddressingProperties addressingProperties, EndpointReference epReference, InstanceIdentifier identifier) { AddressingBuilder builder = AddressingBuilder.getAddressingBuilder(); EndpointReference from = builder.newEndpointReference(epReference.getAddress().getURI()); InstanceIdentifier.setEndpointInstanceIdentifier(from, identifier); addressingProperties.setFrom(from); EndpointReference faultTo = builder.newEndpointReference(epReference.getAddress().getURI()); InstanceIdentifier.setEndpointInstanceIdentifier(faultTo, identifier); addressingProperties.setFaultTo(faultTo); } public static void installNoneReplyTo(AddressingProperties addressingProperties) { addressingProperties.setReplyTo(getNoneAddress()); } private static EndpointReference noneAddress = null; private static synchronized EndpointReference getNoneAddress() { if (noneAddress == null) { AddressingBuilder builder = AddressingBuilder.getAddressingBuilder(); AddressingConstants addressingConstants = builder.newAddressingConstants(); try { URI noneURI = new URI(addressingConstants.getNoneURI()); noneAddress = builder.newEndpointReference(noneURI); } catch (URISyntaxException e) { // will not happen } } return noneAddress; } public static javax.xml.ws.addressing.AttributedURI makeURI(AddressingBuilder builder, String messageID) { try { return builder.newURI(messageID); } catch (URISyntaxException use) { return null; } } . . . class TestUtil { . . . public static W3CEndpointReference getCompletionCoordinatorEndpoint(String id) { return getEndpoint(AtomicTransactionConstants.COMPLETION_COORDINATOR_SERVICE_QNAME, AtomicTransactionConstants.COMPLETION_COORDINATOR_PORT_QNAME, completionCoordinatorServiceURI, id); } private static W3CEndpointReference getEndpoint(QName service, QName port, String address, String id) { try { W3CEndpointReferenceBuilder builder = new W3CEndpointReferenceBuilder(); builder.serviceName(service); builder.endpointName(port); builder.address(address); if (id != null) { InstanceIdentifier.setEndpointInstanceIdentifier(builder, id); } return builder.build(); } catch (Exception e) { return null; } } . . . class InstanceIdentifier { public static void setEndpointInstanceIdentifier(final W3CEndpointReferenceBuilder builder, final String identifier) { builder.referenceParameter(createInstanceIdentifierElement(identifier)); } private static SOAPFactory factory = createSoapFactory(); private static Name WSARJ_ELEMENT_INSTANCE_NAME; public static Element createInstanceIdentifierElement(final String instanceIdentifier) { try { SOAPElement element = factory.createElement(WSARJ_ELEMENT_INSTANCE_NAME); element.addNamespaceDeclaration(ArjunaConstants.WSARJ_PREFIX, ArjunaConstants.WSARJ_NAMESPACE); element.addTextNode(instanceIdentifier); return element; } catch (SOAPException se) { // TODO log error here (should never happen) return null; } } private static SOAPFactory createSoapFactory() { try { SOAPFactory factory = SOAPFactory.newInstance(); Name name = factory.createName(ArjunaConstants.WSARJ_ELEMENT_INSTANCE_IDENTIFIER, ArjunaConstants.WSARJ_PREFIX, ArjunaConstants.WSARJ_NAMESPACE); WSARJ_ELEMENT_INSTANCE_NAME = name; return factory; } catch (SOAPException e) { // TODO log error here (should never happen) } return null; } . . . </pre> -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira