From: ABRA2 <rabarna(a)archstone.in&gt; Subject: [rules-users] Help me improve my rules performance. To: rules-users(a)lists.jboss.org Date: Sunday, November 8, 2009, 11:02 PM Hi, I have an example of two rules we use in our project. Rule CheckStationNumber checks if the station number field is null in BillingRecord Object which is stored as a list in AssertionObject object. Rule AssignBAC gets a value from a static map(we dont want to do database calls eachtime.so we store the required values in a static map) and assigns it to bac field in BillingRecord based on certain other field values in Billing Record. So we have around 10 more rules similiar to this pattern and we run this rule against against 100,000 billing records and the execution time is very long.  I know that i am not supposed to use eval in rules which slows down the performance. Can you please suggest me few other ways how i can accomplish these tasks and improve the execution time? thanks ABRA2 example.drl import ct.fw.web.rules.*; import ct.fw.rules.*; import ct.fw.utils.*; import ct.fw.rules.*; import ct.fw.pf.*; import ct.fw.pf.dbi.DbAccess; import ct.fw.logging.*; import ct.fw.ex.*; import org.apache.commons.lang.*; import com.aa.gccp.domain.*; import com.aa.gccp.domain.persistence.dao.*; import com.aa.gccp.utils.*; import com.aa.gccp.processor.*;         global ct.fw.logging.SmartLogger log         function BillingRecord getRecord(AssertionObject ao)         {             return (BillingRecord) ao.get(0);         }             function Object getRecordData(AssertionObject ao, String key)         {             return getRecord(ao).get(key);         }        function void error(String msg,SmartLogger log)         {             log.error(BusinessRulesValidator.class, msg);         }     function void info(String msg,SmartLogger log)         {             log.info(BusinessRulesValidator.class, msg);                     } function String getBillActCode(String stationno,String tiktcrncy,String cardtype)     {         String bac="";         Map<String,String> bacamap = new HashMap<String,String>();         if(stationno!=null && !stationno.equals("") && tiktcrncy!=null && !tiktcrncy.equals("") && cardtype!=null && !cardtype.equals(""))         {          if(stationno.length()<7){stationno=stationno.substring(0,3);}          bacamap=FileFormatLoader.BACAMap;          if(bacamap.size()>0)           {             bac=bacamap.get(stationno+tiktcrncy+cardtype);          }         }         return bac;     }     rule CheckStationNumber salience 100 no-loop true when    $ao:AssertionObject()         $stno:String() from getRecordData($ao,"stationNo")    eval(($stno.equals("")) || ($stno == null)) then $ao.addError(BillingRecordHelper.STATION_NO_NULL_ERROR,"CheckStationNumber");       error(BillingRecordHelper.STATION_NO_NULL_ERROR,log); end rule AssignBAC salience 50 no-loop true when    $ao:AssertionObject()      $stno:String() from getRecordData($ao,"stationNo")      $cardtype:String() from getRecordData($ao,"cardType")      $tktcuralphacd:String() from  getRecordData($ao,"tktCurrAlphaCd")    $bac:String() from getBillActCode($stno,$tktcuralphacd,$cardtype)    eval(((((getRecord($ao)).getBillingActionCd())==null) || (((getRecord($ao)).getBillingActionCd()).equals(""))) && !($bac.equals(""))) then     modify($ao){setBillingRecord("billingActionCd",$bac);}   info(BillingRecordHelper.BAC_ASSIGNED_INFO,log); end -- View this message in context: http://old.nabble.com/Help-me-improve-my-rules-performance.-tp26261345p26... Sent from the drools - user mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users

From: ABRA2 <rabarna(a)archstone.in&gt; Subject: Re: [rules-users] Help me improve my rules performance. To: rules-users(a)lists.jboss.org Date: Sunday, November 15, 2009, 11:13 PM Thanks  a lot. Your suggestions has helped me improve my rule's performance. I have two more rule i need help with. 1. How do i check for condition of boolean variable without using eval like in the case below? rule CheckValidBinNumber when    $br:BillingRecord(cardNo!=null || cardNo!="")    $valid: Boolean() from checkValidity($br.cardNo)    eval(!($valid)) then    error(BillingRecordHelper.BIN_NO_INVALID_ERROR,log); end 2. How do i check if the value of variable created in when part without using eval? getMerchantNo is a function defined in the .drl file. If i dont use the condition eval($mno!="") then my rules gets fired in an infinte loop because there is one more rule which sets the value of billingActionCd in BillingRecord in working memory and it also triggers this rule. rule AssignMerchantNumber when    $br:BillingRecord(merchantNo==null || merchantNo=="")    $mno:String() from getMerchantNo($br.billingActionCd, $br.cardType, $br.salesSourceTypeCode, $br.posId)    eval($mno!="") then     modify($br){setMerchantNo($mno);}     info(BillingRecordHelper.MERCHANT_NO_ASSIGNED_INFO,log); end I really appreciate your timely help for improving my rules. thanks ABRA2 -- View this message in context: http://old.nabble.com/Help-me-improve-my-rules-performance.-tp26261345p26... Sent from the drools - user mailing list archive at Nabble.com. _______________________________________________ rules-users mailing list rules-users(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/rules-users