[jbossseam-issues] [JBoss JIRA] Assigned: (JBSEAM-848) TransactionPropagationType.isNewTransactionRequired() logic is incorrect for MANDATORY and NEVER

TransactionPropagationType.isNewTransactionRequired() logic is incorrect for MANDATORY and NEVER ------------------------------------------------------------------------------------------------ Key: JBSEAM-848 URL: http://jira.jboss.com/jira/browse/JBSEAM-848 Project: JBoss Seam Issue Type: Bug Affects Versions: 1.1.6.GA Environment: Any Reporter: Mike Quilleash Assigned To: Gavin King Fix For: 1.1.7.GA The existing code looks like this... case REQUIRED: return !transactionActive; case SUPPORTS: return false; case MANDATORY: if ( !transactionActive ) { throw new IllegalStateException("No transaction active on call to MANDATORY method"); } case NEVER: if ( transactionActive ) { throw new IllegalStateException("Transaction active on call to NEVER method"); } default: throw new IllegalArgumentException(); Will fall-through on the second two cases and throw an incorrect exception. Probably needs just needs "return false" in both cases.