[jbossseam-issues] [JBoss JIRA] Closed: (JBSEAM-2877) Seam Managed Transactions doesn't always clean up transactions it starts

Seam Managed Transactions doesn't always clean up transactions it starts ------------------------------------------------------------------------ Key: JBSEAM-2877 URL: http://jira.jboss.com/jira/browse/JBSEAM-2877 Project: Seam Issue Type: Bug Affects Versions: 2.0.2.CR1 Reporter: Clint Popetz Attachments: seamPhaseListener-cleanup-tx.diff, tx_except.tar.gz The behavior I'm describing is in servlet code; I have no idea how portlets work. So the attached patch is not complete. The SeamPhaseListener is starting a tx before the restoreView phase. However, if a runtime exception is thrown in, for example, the conversion and propagation of page request parameters to the event context, this transaction is marked rollbackOnly by the RollbackInterceptor, but afterServletPhase() will never call handleTransactionsAfterPhase(), and the transaction will never be rolled back. This leaves an active-but-aborted tx live for that thread. and any subsequent code that tries to use an EJB session bean will trigger further spurious exceptions, because the EJB3 tx is dead. My solution locally was to wrap the final half of afterServletPhase in a finally(). That's kind of a hack, but it does work correctly for me. It probably needs further investigation. I realize that post-exception code is tricky at best, but it seems reasonable to require SeamPhaseListener to at least roll back the tx if it started it, so that whatever work the Exceptions component does has a reasonable JTA state to work with.