I want to throw this out to the list for feedback. Something we have been doing for a
while now with the jQuery project is to require a unit test(s) for any PR or change
committed. This has worked very well in two ways. First, it provides a built in way to see
the issue being fixed/implemented within the PR. That way, the reviewer doesn't have
to build their own test(s) to see if the issue being addressed is actually fixed. Second,
it helps prevent regressions down the road since more of the code is covered by tests so
you know if some change you think is unrelated breaks something that fixed days, weeks,
years ago.
I would like to suggest we make this policy for at least the JS library (since that is the
one I review most often) but I believe this policy would be useful across the entire
project. Let me know what you think.
Thanks,
Kris