Re: [aerogear-dev] [OTP] Mobile-OTP / OTP for .NET

Hey my friend, welcome! Answers inline. -- "The measure of a man is what he does with power" - Plato - @abstractj - Volenti Nihil Difficile On Sunday, December 16, 2012 at 8:27 PM, Daniel Manzke wrote: > Hey guys, > > after 140 chars were not enough for matthias and bruno I decided to subscribe to the list. ;) > > 1: > After working through aerogear-otp-java I took some hours to port it .NET. If you are interested I would like to contribute it after cleanup. > > Are you interested? :) I'm completely dumb on .net platform. Is it ( https://github.com/manzke/aerogear-otp-dotnet) compatible with windows phone? > > 2: > Due to the fact that we are using Mobile-OTP in hour company I also took some time and have implemented it. > PoC is working. > Pull-Request will be submitted if ready. > > > Question: I saw that the Clock-Implementation is returning a static value for current time. So the token will be the same every time we call Totp.now(). Not really, do you have some scenario or unit test to reproduce it? The token will be the same during 30s only. > > Is it really what developers are expecting? No, I'd appreciate if you gist the sources to reproduce it, then we can find out what's wrong. > > If I call now, I expect the time it was called not created. :) > > Why not just use System.currentMilliSeconds()? It is UTC. ;) I wouldn't like to trust in Java while we're dealing with timezones. System.currentMilliSeconds also works np on changing it, if the unit tests are passing. > > > Bye, > Daniel > > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org (mailto:aerogear-dev@lists.jboss.org) > https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev