Hi, Last tuesday the PR for the new javascript crypto api landed, because I developed the crypto cordova plugin based on the 'old' api there is now a discrepancy between the 'current' javascript crypto api and the cordova one. We could change that this week as there aren't that many people that use the crypto cordova plugin, but we have frozen so what is the point of a freeze when we change things regardless? Anyway I think we could still change this what do you think?

On Tue, Nov 19, 2013 at 10:21 AM, Erik Jan de Wit <edewit(a)redhat.com&gt;wrote: > Hi, > > Last tuesday the PR for the new javascript crypto api landed, because I > developed the crypto cordova plugin based on the 'old' api there is now a > discrepancy between the 'current' javascript crypto api and the cordova > one. We could change that this week as there aren't that many people that > use the crypto cordova plugin, but we have frozen so what is the point of a > freeze when we change things regardless? > > Anyway I think we could still change this what do you think? > yes, I think updating the Cordova bits makes sense. Quote from yesterdays team meeting: <quote> 15:22:50 <qmx> #info qmx proposes to freeze this friday (as an exception to android), freeze this friday, release next week, announce after the holiday" </quote> So the freeze is this week, and IMO that's perfectly fine to update it. That said, but I think the only question I really have is why this update to reflect the 'new' API was not addressed already last week. Greetings, Matthias > > Cheers, > Erik Jan > > p.s. > have a look at the differences: > > current javascript api > > https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aer... > > current cordova api > > https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf... > > _______________________________________________ > aerogear-dev mailing list > aerogear-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/aerogear-dev > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf

The cordova crypto plugin can't follow the javascript one-to-one as all the calls have to be asynchronous. So it's not as simple as a dependency, I'll have to change the javascript api of the plugin to follow the javascript. It's a bit dependency hell as it depends on everything iOS android and javascript. Perhaps it would be good for Cordova to have it's own deadline.

Cheers, Erik Jan On 19 Nov,2013, at 11:14 , Matthias Wessendorf <matzew(a)apache.org&gt; wrote: A few questions: * The best is to "suck in" the 'latest' JS dependency via npm (or similar, or by hand), right ? * If yes... doesn't it generally make sense to release the Cordova bits a bit AFTER its core dependencies ? On iOS we did the same (yesterday I moved the Crypto to CocoaPods, today Christos is sucking that in, via CocoaPods (on aerogear-ios) -Matthias On Tue, Nov 19, 2013 at 10:59 AM, Matthias Wessendorf <matzew(a)apache.org&gt;wrote: > > > > On Tue, Nov 19, 2013 at 10:21 AM, Erik Jan de Wit <edewit(a)redhat.com&gt;wrote: > >> Hi, >> >> Last tuesday the PR for the new javascript crypto api landed, because I >> developed the crypto cordova plugin based on the 'old' api there is now a >> discrepancy between the 'current' javascript crypto api and the cordova >> one. We could change that this week as there aren't that many people that >> use the crypto cordova plugin, but we have frozen so what is the point of a >> freeze when we change things regardless? >> >> Anyway I think we could still change this what do you think? >> > > yes, I think updating the Cordova bits makes sense. > > Quote from yesterdays team meeting: > <quote> > 15:22:50 <qmx> #info qmx proposes to freeze this friday (as an exception > to android), freeze this friday, release next week, announce after the > holiday" > </quote> > > So the freeze is this week, and IMO that's perfectly fine to update it. > > > That said, but I think the only question I really have is why this update > to reflect the 'new' API was not addressed already last week. > > Greetings, > Matthias > > > >> >> Cheers, >> Erik Jan >> >> p.s. >> have a look at the differences: >> >> current javascript api >> >> https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aer... >> >> current cordova api >> >> https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf... >> >> _______________________________________________ >> aerogear-dev mailing list >> aerogear-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/aerogear-dev >> > > > > -- > Matthias Wessendorf > > blog: http://matthiaswessendorf.wordpress.com/ > sessions: http://www.slideshare.net/mwessendorf > twitter: http://twitter.com/mwessendorf > -- Matthias Wessendorf blog: http://matthiaswessendorf.wordpress.com/ sessions: http://www.slideshare.net/mwessendorf twitter: http://twitter.com/mwessendorf _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev

On Nov 19, 2013, at 4:21 AM, Erik Jan de Wit <edewit(a)redhat.com&gt; wrote: Hi, Last tuesday the PR for the new javascript crypto api landed, because I developed the crypto cordova plugin based on the 'old' api there is now a discrepancy between the 'current' javascript crypto api and the cordova one. We could change that this week as there aren't that many people that use the crypto cordova plugin, but we have frozen so what is the point of a freeze when we change things regardless? If it is still in your repo and not an AeroGear one, then i think it is fine to change. Since the code freeze was on friday, and the change was made on the tuesday before, i'm thinking that should've been enough time to update. I don't believe the change was to big

Anyway I think we could still change this what do you think? Cheers, Erik Jan p.s. have a look at the differences: current javascript api https://github.com/aerogear/aerogear-js/blob/master/tests/unit/crypto/aer... current cordova api https://github.com/edewit/aerogear.org/blob/f2fe8a48b2f9d9c581e62292abeaf... _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev _______________________________________________ aerogear-dev mailing list aerogear-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/aerogear-dev