ConnectionObserver
by Sanne Grinovero
While refactoring some related optimisations, I noticed there's
currently no way to register a custom ConnectionObserver.
There seems to be only one implementation, which is registered by default:
- org.hibernate.internal.ConnectionObserverStatsBridge#ConnectionObserverStatsBridge
Some questions:
# Is this expected?
# Should we deprecate the SPI so to make this more explict in the
future, and possibly eventually discuss removing it?
# Since I'm working on performance optimisations, may I take advantage
currently of the fact that there's only one registered? We're
currently iterating "the list of obeservers"...
Thanks
6 years, 7 months
API removal proposal: org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery
by Sanne Grinovero
Hi all,
is this method needed?
- org.hibernate.resource.jdbc.ResourceRegistry#cancelLastQuery
It seems undocumented, untested, and everything compiles just fine if
I just delete it - however it seems marked as API.
But also, I suppose this should be invoked by a different thread as
the one actually running the query? Which would imply this
implementation would need to be threadsafe, but it's not.
My primary reason to explore its removal though is that this method is
in the way of some optimisations I'd like to apply to this class, so
it would be quite useful for me to be able to remove it - assuming
that it's no longer of interest to anyone else.
Thanks,
Sanne
6 years, 7 months
Suggestions for fixing HHH-13570?
by Gail Badner
LockModeTest executes the following SQL for Sybase and SQL Server:
UPDATE T_LOCK_A WITH(NOWAIT) SET a_value = :value where id = :id";
This fails on Sybase, because it doesn't recognize WITH(NOWAIT).
If I remove WITH(NOWAIT), the statement blocks until Junit times out.
I'm having trouble finding some equivalent to WITH(NOWAIT) for Sybase. Does
anyone know if there is one?
Should I just skip this test for Sybase?
Thanks,
Gail
6 years, 7 months
JDK 13 is now in the Release Candidate Phase
by Rory O'Donnell
Hi Sanne,
Haven't heard from you in some time, any issues to report as we announce
a Release Candidate ?
*JDK 13 is now in the Release Candidate Phase
*
Per the JDK 13 schedule [1], we are now in the Release Candidate phase.
The stabilization repository, jdk/jdk13, is open for P1 bug fixes per
the JDK Release Process (JEP 3) [2].
All changes require approval via the Fix-Request Process [3].
For more details, see Mark Reinhold's email to jdk-dev mailing list [4]
* Milestone Schedule:
o Initial RC Build 33 - Aug 9, 2019
o GAC - Aug 22, 2019
o GAR - Sept 5, 2019
o GA - Sept 17, 2019
*OpenJDK 13 build 33 is available at http://jdk.java.net/13/*
* These early access, open source builds are provided under the GNU
General Public License, version 2, with the Classpath Exception
<http://openjdk.java.net/legal/gplv2+ce.html>.
* Schedule, status & features
o http://openjdk.java.net/projects/jdk/13/
* Release Notes
o http://jdk.java.net/13/release-notes
* Bug fixes reported by Open Source Projects :
o JDK-8228764 - fixed in b32 -reported by Apache Tomcat
**OpenJDK 14 *EA build 9 is now available at **http://jdk.java.net/14**
*
* These early access, open source builds are provided under the GNU
General Public License, version 2, with the Classpath Exception
<http://openjdk.java.net/legal/gplv2+ce.html>.
* Release Notes
o http://jdk.java.net/14/release-notes
* JEPs targeted to JDK 14
o JEP 352 <http://openjdk.java.net/jeps/352> - Non-Volatile Mapped
Byte Buffers
* Changes in this build
<http://hg.openjdk.java.net/jdk/jdk/log?rev=reverse%28%22jdk-14%2B8%22%3A%...>
* Bug fixes reported by Open Source Projects :
o JDK-8227170 - fixed in b8 -reported by Apache Ant
o JDK-8228485 - fixed in b8 -reported by JaCoCo
o JDK-8222791 - fixed in b7 -reported by Apache Lucene
*Project Panama Early-Access Builds*
* Build jdk-14-panama+1-15 (2019/8/8) is available at
http://jdk.java.net/panama/
* These early-access, open-source builds are provided under the GNU
General Public License, version 2, with the Classpath Exception
<http://openjdk.java.net/legal/gplv2+ce.html>.
Regards,
Rory
[1] https://openjdk.java.net/projects/jdk/13/#Schedule
[2] https://openjdk.java.net/jeps/3
[3] https://openjdk.java.net/jeps/3#Fix-Request-Process
[4] https://mail.openjdk.java.net/pipermail/jdk-dev/2019-August/003250.html
--
Rgds,Rory O'Donnell
Quality Engineering Manager
Oracle EMEA , Dublin, Ireland
6 years, 7 months
Any external uses for ORM's StatisticsImpl ?
by Sanne Grinovero
Hi all,
while working on HHH-13527 I noticed that there's quite some
complexity in StatisticsImpl to deal with the fact that the final
field `sessionFactory` could be null in some cases.
This field can only be null if its public no-argument constructor is
invoked, yet there is no code in whole of ORM invoking this.
I'm therefore tempted to remove this constructor and cleanup all those
checks for null; anybody knows why that constructor was explicitly
marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ?
- https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675f...
Suggesting this change for 5.4 (and beyond) only.
Thanks,
Sanne
6 years, 8 months
