Hi, I had a quick look at Hibernate Search's source code, and couldn't find any use of this class. So +1 for me. Yoann Rodière Hibernate NoORM Team yoann(a)hibernate.org On Wed, 7 Aug 2019 at 11:08, Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > > Hi all, > > while working on HHH-13527 I noticed that there's quite some > complexity in StatisticsImpl to deal with the fact that the final > field `sessionFactory` could be null in some cases. > > This field can only be null if its public no-argument constructor is > invoked, yet there is no code in whole of ORM invoking this. > > I'm therefore tempted to remove this constructor and cleanup all those > checks for null; anybody knows why that constructor was explicitly > marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? > - https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675f... > > Suggesting this change for 5.4 (and beyond) only. > > Thanks, > Sanne > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

I do not remember the history for it. +1 for removing that no-arg form. On Wed, Aug 7, 2019 at 4:08 AM Sanne Grinovero <sanne(a)hibernate.org&gt; wrote: > > Hi all, > > while working on HHH-13527 I noticed that there's quite some > complexity in StatisticsImpl to deal with the fact that the final > field `sessionFactory` could be null in some cases. > > This field can only be null if its public no-argument constructor is > invoked, yet there is no code in whole of ORM invoking this. > > I'm therefore tempted to remove this constructor and cleanup all those > checks for null; anybody knows why that constructor was explicitly > marked to stay with @SuppressWarnings({ "UnusedDeclaration" }) ? > - https://github.com/hibernate/hibernate-orm/blob/a26b971d434453be482e7675f... > > Suggesting this change for 5.4 (and beyond) only. > > Thanks, > Sanne > _______________________________________________ > hibernate-dev mailing list > hibernate-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/hibernate-dev

Hi Sanne, WildFly doesn't reference StatisticsImpl, WildFly does use Statistics. Scott