Re: [hibernate-dev] javax.money
The improperness of optional dependencies is already well documented
elsewhere, so I won't get into that.
I just think the "cleanest" solution, given the situation, is a separate
module/artifact (hibernate-money) defining the types and contributor. I
personally don't think this use-case "fits the mold" of a provided
dependency (on hibernate-core).
Of course then I ask myself about the practical aspect of using the
optional dependency approach versus a dedicated module for just a handful
of classes.
On Tue, Dec 22, 2015 at 11:34 AM Gunnar Morling <gunnar(a)hibernate.org>
wrote:
> yes we could use an optional/provided dependency, but
> that would not be "proper".
That would actually be my preference; If the javax.money types are
present, enable the required Types etc. otherwise not. It's a pattern
we e.g. use in Validator, too, where we provide additional constraint
validator types based on what's available in the runtime environment.
Why do you consider it as not proper?
2015-12-22 17:03 GMT+01:00 Steve Ebersole <steve(a)hibernate.org>:
> I had planned to support this JSR when I thought it would be part of the
> JDK. But as it is, supporting this properly would mean a whole new
> module/artifact just to add these few types + the dependency (similar to
> hibernate-java8). I am not a fan of the fact that it would require a
> separate dependency; yes we could use an optional/provided dependency,
but
> that would not be "proper".
>
> I am interested in what others think.
>
> On Mon, Dec 21, 2015, 1:37 PM Petar Tahchiev <paranoiabla(a)gmail.com>
wrote:
>
>> Hi guys,
>>
>> I've been playing lately with JSR 354 javax.money api (
>> http://javamoney.java.net) and I was wondering if there's any plans for
>> hibernate to support this.
>>
>> Thanks.
>>
>> --
>> Regards, Petar!
>> Karlovo, Bulgaria.
>> ---
>> Public PGP Key at:
>> http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x19658550C3110611
>> Key Fingerprint: A369 A7EE 61BC 93A3 CDFF 55A5 1965 8550 C311 0611
>> _______________________________________________
>> hibernate-dev mailing list
>> hibernate-dev(a)lists.jboss.org
>> https://lists.jboss.org/mailman/listinfo/hibernate-dev
>>
> _______________________________________________
> hibernate-dev mailing list
> hibernate-dev(a)lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/hibernate-dev