Re: [hibernate-dev] [HSEARCH] - pull request 95
Hello Sanne and Davide.
First of all awesome job :)
I've added a few comments in the pull request, here are a couple more.
The package should be something.something.impl as it's not meant to be published to
users.
org.hibernate.search.util.logging.impl is fine by me.
We might want to adjust some log levels according to
http://community.jboss.org/wiki/HowToLogInJBossProjects
I have not checked whether or not we are conformant but we will need to investigate at
some point (a different pull request of course).
Emmanuel
On 10 juin 2011, at 02:03, Sanne Grinovero wrote:
Hello,
this pull request by Davide is looking ok for me, as we've been
iterating on it a while now, but I would like a brief review from
someone else, at least your opinion about:
1- the final package name of the logger: package
org.hibernate.search.util.logging
2- he did on purpose not convert the archetype, still using slf4j in
the example for the "user app": keeps things simpler as enabling the
processor in eclipse still requires some non trivial manual steps
[JBIDE-8208] to be documented on the wiki
https://github.com/hibernate/hibernate-search/pull/95
Sanne
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev