6:51 a.m.
We need to align the 4.5 branch to latest ORM 4.3.
Considering the main theme for 4.5 is to keep up with JPA 2.1 and
latest WildFly, the branch is technically ready for a release.
Anything else that you would like to see fixed in this branch?
I have no problem in postponing the release to tomorrow if anyone
needs to send some PR soon, but if it takes longer I'd rather do
another release next week.. I don't want to prevent people from being
able to play with latest ORM just because our latest tag is not
compatible.
Sanne
8:16 a.m.
On 11 Jan 2013, at 13:51, Sanne Grinovero <sanne(a)hibernate.org> wrote:
We need to align the 4.5 branch to latest ORM 4.3.
Considering the main theme for 4.5 is to keep up with JPA 2.1 and
latest WildFly, the branch is technically ready for a release.
+1 We should release asap
Anything else that you would like to see fixed in this branch?
Yes - https://github.com/hibernate/hibernate-search/pull/523 (HSEARCH-1442)
I’ll need to confirm the fix and we should give the reporters a chance to verify against
a snapshot. If the fix looks good we should add it to the 4.5 release. Not sure whether
it
would even require another 4.4 release?
I have no problem in postponing the release to tomorrow if anyone
needs to send some PR soon
The pull request is there, but it might take people some time to verify the fix.
I would wait a couple of days.
—Hardy
8:23 a.m.
On 11 December 2013 14:16, Hardy Ferentschik <hardy(a)hibernate.org> wrote:
On 11 Jan 2013, at 13:51, Sanne Grinovero <sanne(a)hibernate.org> wrote:
> We need to align the 4.5 branch to latest ORM 4.3.
>
> Considering the main theme for 4.5 is to keep up with JPA 2.1 and
> latest WildFly, the branch is technically ready for a release.
+1 We should release asap
> Anything else that you would like to see fixed in this branch?
Yes - https://github.com/hibernate/hibernate-search/pull/523 (HSEARCH-1442)
I’ll need to confirm the fix and we should give the reporters a chance to verify against
a snapshot. If the fix looks good we should add it to the 4.5 release. Not sure whether
it
would even require another 4.4 release?
let's see what the OpenWide team needs.
> I have no problem in postponing the release to tomorrow if
anyone
> needs to send some PR soon
The pull request is there, but it might take people some time to verify the fix.
I would wait a couple of days.
ok let's wait but if you change your estimate, I don't mind releasing again.
—Hardy
_______________________________________________
hibernate-dev mailing list
hibernate-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/hibernate-dev
9:45 a.m.
Hi Sanne,
On Wed, Dec 11, 2013 at 3:23 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
> Yes - https://github.com/hibernate/hibernate-search/pull/523
(HSEARCH-1442)
> I’ll need to confirm the fix and we should give the reporters a chance to verify
against
> a snapshot. If the fix looks good we should add it to the 4.5 release. Not sure
whether it
> would even require another 4.4 release?
let's see what the OpenWide team needs.
I appreciate, but aparts from our needs, I think we *need* a fully
functional Hibernate Search release working with 4.2.x branch of ORM.
It's always bad to have 2 components so tightly integrated which
aren't working well together.
Currently, the only version working with this branch is the latest
4.4.1 but it's hardly usable as soon as you play with @IndexedEmbedded
so IMHO we should quickly release the fix if we can get it commited
soon.
Is 4.5 supposed to be compatible with ORM 4.2 and 4.3 or only 4.3?
FYI, we haven't started any validation of ORM 4.3 yet and I'm not sure
of when we will be able to start this work. I'd like to plan it ASAP.
Considering we cannot help to test it without this fix included, I
think it would be a good idea to wait for it before pushing a 4.5
alpha.
--
Guillaume
11:59 a.m.
Thanks for the feedback Guillaume,
I probably missed how critical this bug is, I definitely want 4.4 to
be "fully functional", so +1 to release another 4.4.x when this is
fixed.
Regarding Search 4.5: it's only compatible with ORM 4.3, we
specifically branched because it was too tricky to keep compatibility
with both versions of the JPA spec.
Sanne
On 11 December 2013 15:45, Guillaume Smet <guillaume.smet(a)gmail.com> wrote:
Hi Sanne,
On Wed, Dec 11, 2013 at 3:23 PM, Sanne Grinovero <sanne(a)hibernate.org> wrote:
>> Yes - https://github.com/hibernate/hibernate-search/pull/523 (HSEARCH-1442)
>> I’ll need to confirm the fix and we should give the reporters a chance to verify
against
>> a snapshot. If the fix looks good we should add it to the 4.5 release. Not sure
whether it
>> would even require another 4.4 release?
>
> let's see what the OpenWide team needs.
I appreciate, but aparts from our needs, I think we *need* a fully
functional Hibernate Search release working with 4.2.x branch of ORM.
It's always bad to have 2 components so tightly integrated which
aren't working well together.
Currently, the only version working with this branch is the latest
4.4.1 but it's hardly usable as soon as you play with @IndexedEmbedded
so IMHO we should quickly release the fix if we can get it commited
soon.
Is 4.5 supposed to be compatible with ORM 4.2 and 4.3 or only 4.3?
FYI, we haven't started any validation of ORM 4.3 yet and I'm not sure
of when we will be able to start this work. I'd like to plan it ASAP.
Considering we cannot help to test it without this fix included, I
think it would be a good idea to wait for it before pushing a 4.5
alpha.
--
Guillaume
4053
days inactive
4053
days old
4 comments
3 participants
participants (3)
-
Guillaume Smet -
Hardy Ferentschik -
Sanne Grinovero