On 4 Jan 2011, at 16:12, Eduardo Martins wrote:
>>>>
>>>> 3) Configuration stuff
>>>>
>>>> Generally I think the Configuration and GlobalConfiguration could be
>>>> simplified a bit, I found myself several times looking at the impl
>>>> code to understand how to achieve some configurations.
>>>
>>> Configurations such as?
>>
>> Example below, but this is a generic remark, more like a call to try
>> to simplify as much as possible, I can say that it took me much more
>> time to settle on configurations than to code.
>>
>>>
>>>> Better
>>>> documentation wouldn't hurt too, it's great to have a complete
>>>> reference, but the configuration samples are not ok, one is basically
>>>> empty, the other has all possible stuff, very unrealistic, would be
>>>> better to have reusable examples for each mode, with then
>>>> recommendations on how to improve these.
>>>
>>> Which configuration samples do you refer to? The ones in the testsuite?
>>
>> The ones bundled in etc/config-samples.
>
> Precisely for 5.0.0.ALPHA1 and 4.2.0.FINAL we removed all.xml and added sample.xml
that has more meaningful configurations in there with several of them commented and ready
for use.
>
I think it still needs more examples, and a docs section reviewing
those. It makes sense to have one example for each typical/mainstream
configuration used.
Again, these are in sample.xml but commented out. Are you suggesting that each one of
these becomes a separate config file? E.g., sample-all.xml, sample-async-repl-queue.xml,
sample-dist-l1.xml, etc?
>>
>>>
>>> I suppose the reusable examples that you look for might be partially
available via TestCacheManagerFactory except that these are oriented at testing (i.e. make
sure each testsuite thread uses a different mcast address). Maybe we should extract these
out and make more easily available.
>>>
>>>>
>>>> Infinispan 5 introduces a new global configuration setter to provide
>>>> an instance, with same method name as the one to provide the class
>>>> name. I believe one is enough, and to be more friendly with
>>>> Microcontainer and similar frameworks I would choose the one to set
>>>> the instance.
>>>
>>> Which configuration setter are you referring to?
>>
>> setMBeanServerLookup(...)
>
> Right. The one that takes a String is used by JAXB code whereas the one taking the
instance is used by programmatic configuration.
>
> I think the latter should be renamed to setMBeanServerLookupInstance at least.
>
Agree.
+1. Again, do you have a JIRA for this?
--
Manik Surtani
manik(a)jboss.org
twitter.com/maniksurtani
Lead, Infinispan
http://www.infinispan.org