On 25 Oct 2010, at 15:58, Vladimir Blagojevic wrote:
What do you mean by "may be interested in a @ViewChanged
callback during a merge as well"? Removing @Merged altogether?
No, just that a merge event as detected from JGroups should trigger both view changed as
well as merged notifications.
+1 to most of your changes in the changeset though, including the MergeEvent extends
ViewChangedEvent. I'm just removing the unnecessary @Merged annotations in our code
since they wil be triggered by the @ViewChanged annotation anyway.
On 2010-10-25, at 10:53 AM, Manik Surtani wrote:
> Hmm. I might revert that change, since it isn't just our code that is affected.
Any public code may be interested in a @ViewChanged callback during a merge as well.
>
> On 25 Oct 2010, at 15:27, Vladimir Blagojevic wrote:
>
>>
http://fisheye.jboss.org/changelog/Infinispan/?cs=2496
>>
>> I made a MergeEvent subclass of ViewChangeEvent. In our code base all current
callbacks annotated with @ViewChanged I annotated with @Merged. And then I enabled firing
of MergeEvent in CacheManagerNotifierImpl.
>>
>>
>> On 2010-10-25, at 10:20 AM, Manik Surtani wrote:
>>
>>>
>>> On 25 Oct 2010, at 15:17, Vladimir Blagojevic wrote:
>>>
>>>> I think this should already be fine. I took a liberty of concluding that
there was a small oversight in completion of ISPN-609 and I completed it. Please verify.
>>>
>>> How did you complete it? :)
>>
>>
>> _______________________________________________
>> infinispan-dev mailing list
>> infinispan-dev(a)lists.jboss.org
>>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
>
> --
> Manik Surtani
> manik(a)jboss.org
> Lead, Infinispan
> Lead, JBoss Cache
>
http://www.infinispan.org
>
http://www.jbosscache.org
>
>
>
>
>
> _______________________________________________
> infinispan-dev mailing list
> infinispan-dev(a)lists.jboss.org
>
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Vladimir Blagojevic
JBoss Clustering Team
JBoss, by Red Hat
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Manik Surtani
manik(a)jboss.org
Lead, Infinispan
Lead, JBoss Cache
http://www.infinispan.org
http://www.jbosscache.org