[infinispan-dev] Asymmetric logging for lock aquisition attempt and success/failure

Hi, I'm trying to track down an elusive random bug and I've noticed that in LockManagerImpl, we print: if (trace) log.trace("Attempting to lock {0} with acquisition timeout of {1} millis", key, lockTimeout); But whether this succeeded or not is logged in clients of lockAndRecord, i.e. EntryFactoryImpl: if (lockManager.lockAndRecord(key, ctx)) { // successfully locked! if (trace) log.trace("Successfully acquired lock!"); return true; It'd be better if the success/failure was logged in LockManagerImpl, so that you can simply enable TRACE on LockManagerImpl, rather than having to do that in that class and also in any client class calling lockAndRecord(). If anyone has any objections to moving "Successfully acquired lock!" to LockManagerImpl, let me know. Cheers, -- Galder Zamarreño Sr. Software Engineer Infinispan, JBoss Cache