Re: [infinispan-dev] Merged and MergeEvent in 4.2

I think this should already be fine. I took a liberty of concluding that there was a small oversight in completion of ISPN-609 and I completed it. Please verify.

On 2010-10-25, at 7:46 AM, Manik Surtani wrote: > Yes, both types of notifications should be emitted. I'll take a look at this today. Reopening ISPN-609. > > On 11 Oct 2010, at 20:42, Mircea Markus wrote: > >> >> On 11 Oct 2010, at 20:37, Vladimir Blagojevic wrote: >> >>> >>> On 2010-10-11, at 1:22 PM, Mircea Markus wrote: >>> >>>> >>>> On 11 Oct 2010, at 18:12, Vladimir Blagojevic wrote: >>>> >>>>> Hey, >>>>> >>>>> No need to register a new listener for merge event. There is no addMergeEventListener, only addListener! Manik's mechanism looks for annotated callback methods in a listener and registers them with event notifiers. So when you do addListener(x) and x has methods annotated with ViewChaged and Merged annotations then x will get registered in appropriate list in CacheManagerNotifierImpl. Very ingenious mechanism. >>>>> >>>>> Yes, I made MergeEvent subclass of ViewChangeEvent. It was not before. To all our view change listener classes that had ViewChange annotated method callback I added Merged as well. >>>> I see! My question is: if a cluster merge happens, and I have a method annotated with ViewChange *only* (i.e. doesn't have @Merged) - will the @ViewChange annotated method be called? IMO it should because merge is only a special kind of view change. >>> >>> Aha, I see :) It will not get called! The root cause is split of view notification in JGroups transport! We have to make this clear for 4.2 release! >> That's my point :) I think it should be called as merge is a particular type of view change (the view literally changes) >>> >>> Vladimir >>> >>> >>> _______________________________________________ >>> infinispan-dev mailing list >>> infinispan-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/infinispan-dev >> >> >> _______________________________________________ >> infinispan-dev mailing list >> infinispan-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > > -- > Manik Surtani > manik(a)jboss.org > Lead, Infinispan > Lead, JBoss Cache > http://www.infinispan.org > http://www.jbosscache.org > > > > > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev -- Vladimir Blagojevic JBoss Clustering Team JBoss, by Red Hat _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev