Re: [infinispan-dev] CacheLoader.prepare/commit/rollback

On 14 May 2009, at 09:57, Mircea Markus wrote: Hi, > > Currently the interface of these classes use a > javax.transaction.Transaction parameter: > > void prepare(List<? extends Modification> modifications, Transaction tx, > boolean isOnePhase) throws CacheLoaderException; > > The problem with this is that Transaction will not exist if this is a > remotely originated call (we only propagate the GlobalTransaction on the > remote nodes). > I've took a look at the CacheStore impls, they do not use any specific > javax.transaction.Transaction logic/methods, but rather use the param as a > key in their internal caches. > Do you see any issues with changing the signature of CacheStore to replace > Transaction param with GlobalTransaction? > Sure, this is fine by me. Better get it in ASAP though, before I cut ALPHA3, since the CacheStore interface should be frozen after that. You would need to update cache store impls, but that should be trivial. Cheers -- Manik Surtani manik(a)jboss.org Lead, Infinispan Lead, JBoss Cache http://www.infinispan.org http://www.jbosscache.org _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev