Re: [infinispan-dev] Re: Distributed hashing - heterogenous nodes
Hi Alex,
On 07/06/2009 06:27 AM, Alex Kluge wrote:
Hi,
> First of all, apologies for the delay getting back to you.
No problem, we are all busy. (OK, I confess it was the Fourth of July and I was on
vacation :))
> With regards to keeping replication count as instance variable or method
> parameter, I need to look at it in more detailed. I'll reply to asap.
Replication count is a configuration parameter, so I don't see it being
problem converting it to an instance variable. However, the
ConsistentHash interface would need a setter of some sort to publicly
set the replication count.
That's actually an easy change, there are a number of options. A slightly
difficult issue
is that I use arrays. It is much easier to locate the additional nodes for replication
with
an array than with other data structures.
Could you be more specific on why you find it easier to use arrays?
Regardless, I don't see a problem in you using arrays internally but
returning List instances as indicated in ConsistentHash interface.
> Apologies for my ignorance if this has mentioned before but I don't
> remember, do you have committer access to the Infininispan code already?
Nope – I could always send a copy to the dev mailing list – but I am not sure about
the appropriateness of dropping about 480 lines of code onto a mailing list. And
it's anybody's guess how it would be formatted.
What about you check out Infinispan trunk, apply your changes to it and
send us a patch?
Anonymous svn repo: http://anonsvn.jboss.org/repos/infinispan/trunk/
Thanks,
Alex
_______________________________________________
infinispan-dev mailing list
infinispan-dev(a)lists.jboss.org
https://lists.jboss.org/mailman/listinfo/infinispan-dev
--
Galder Zamarreño
Sr. Software Engineer
Infinispan, JBoss Cache