While adding changes for cache methods (entrySet, keySet, values, size) to include
passivated entries it had been pointed out to conditionally do these operations if flags
such as SKIP_CACHE_STORE and SKIP_CACHE_LOAD were provided. Also does anyone have any
feedback on if both flags should apply or just say SKIP_CACHE_STORE? Currently
SizeCommand, EntrySetCommand, ValuesCommand and KeySetCommand do not inherit from
FlagAffectedCommand which are used for commands that behavior is dependent upon flags.
The problem is that FlagAffectedCommand currently extends VisitableCommand,
TopologyAffectedCommand, MetadataAwareCommand interfaces. These interfaces do not really
apply to the commands I am working on as they are local only. I was planning on removing
the extended interfaces from the FlagAffectedCommand interface and update all the commands
that implement this interface currently to make sure they still properly implement the
additional interfaces. Searching for instanceof FlagAffectedCommand it also appears that
all current references should be alright after refactoring. Once these interfaces are
decoupled I can add the FlagAffectedCommand interface to the SizeCommand, EntrySetCommand,
ValuesCommand and KeySetCommand and subsequently to the CommandFactory and my changes
should be good.
Any opinions or concerns?
Thanks,
- Will