+1 This is how it's also done for AS7 project. Rado On 28/08/12 15:29, Sanne Grinovero wrote: > Hi all, > I see that on github there are many pull requests for Infinispan, but > a good amount of them is not to be merged, needing more feedback or > pending for other reasons. > > Rather than keeping things open, shouldn't we track these on JIRA? I'd > like to interpret the "pull requests" as things that should be > reviewed for immediate merging. > > Shall we close those pulls which need further work? > > Cheers, > Sanne > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev > _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

Rado, is the AS7 process documented anywhere? Sanne, I'm not sure I understood what you mean by tracking these in JIRA... do you mean I should add a link to the branch on GitHub instead of a pull request (if my code is not quite ready), and feedback should go in JIRA comments as well?

Dan On Tuesday, August 28, 2012, Mircea Markus wrote: > > +1. > I'll update the deferred pull requests. > > On 28 Aug 2012, at 15:14, Radoslav Husar wrote: > > > +1 This is how it's also done for AS7 project. > > > > Rado > > > > On 28/08/12 15:29, Sanne Grinovero wrote: > >> Hi all, > >> I see that on github there are many pull requests for Infinispan, but > >> a good amount of them is not to be merged, needing more feedback or > >> pending for other reasons. > >> > >> Rather than keeping things open, shouldn't we track these on JIRA? I'd > >> like to interpret the "pull requests" as things that should be > >> reviewed for immediate merging. > >> > >> Shall we close those pulls which need further work? > >> > >> Cheers, > >> Sanne > >> _______________________________________________ > >> infinispan-dev mailing list > >> infinispan-dev(a)lists.jboss.org > >> https://lists.jboss.org/mailman/listinfo/infinispan-dev > >> > > _______________________________________________ > > infinispan-dev mailing list > > infinispan-dev(a)lists.jboss.org > > https://lists.jboss.org/mailman/listinfo/infinispan-dev > > _______________________________________________ > infinispan-dev mailing list > infinispan-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

On 31 Aug 2012, at 19:56, Sanne Grinovero <sanne(a)infinispan.org <mailto:sanne@infinispan.org>> wrote: > > I wish I had a single tool integrating it all, including personal life > related tasks; please someone steal my idea and implement it :) A whiteboard? :) -- Manik Surtani manik(a)jboss.org <mailto:manik@jboss.org> twitter.com/maniksurtani <http://twitter.com/maniksurtani> Platform Architect, JBoss Data Grid http://red.ht/data-grid _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev

There are two pull requests which are not active: https://github.com/infinispan/infinispan/pull/1097 This has been issued 4 moths ago with the last comments about 3 months ago so IMO it should a) have a JIRA created and b) be closed till an updated pull request is send. https://github.com/infinispan/infinispan/pull/1230 This requires Dan's input. I think we can do the same thing with it, just to keep the pull request queue cleaner. All the other requests are "active" and should be kept open IMO.

Cheers, Mircea On 28 Aug 2012, at 19:24, Mircea Markus wrote: +1. I'll update the deferred pull requests. On 28 Aug 2012, at 15:14, Radoslav Husar wrote: +1 This is how it's also done for AS7 project. Rado On 28/08/12 15:29, Sanne Grinovero wrote: Hi all, I see that on github there are many pull requests for Infinispan, but a good amount of them is not to be merged, needing more feedback or pending for other reasons. Rather than keeping things open, shouldn't we track these on JIRA? I'd like to interpret the "pull requests" as things that should be reviewed for immediate merging. Shall we close those pulls which need further work? Cheers, Sanne _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev _______________________________________________ infinispan-dev mailing list infinispan-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/infinispan-dev