Feeding off a previous short discussion about removing operations from subsystems, I was thinking of removing a few of the operations from the logging subsystem. We are giving the root-logger a proper address type of /subsystem=logging/root-logger=ROOT. This moves the change-root-log-level operation to that path. I was thinking about removing that operation as it should probably be handled via the write-attribute operation. Along with the change-root-log-level, I'd like to rename the "root-logger-assign-handler" and "root-logger-unassign-handler" to remove the "root-logger" prefix. Also, I'd like to remove the change-log-level in the /subsystem=logging/logger=name path. Anyone have any thoughts or concerns about this?

I'd like to add for all subsystem developers, please make write-attribute/read-attribute work properly for all attributes whenever possible. This even goes for attributes that are ModelType.List and ModelType.Property. We can generate the console UI much faster and more consistently when the base operations work as expected. Quoting James Perkins <jperkins(a)redhat.com&gt;: > I forgot to add to the list, I'd love to remove the update-properties > operation in favor of the write-attribute options. > > On 11/07/2011 04:04 PM, James Perkins wrote: >> Feeding off a previous short discussion about removing operations from >> subsystems, I was thinking of removing a few of the operations from the >> logging subsystem. We are giving the root-logger a proper address type >> of /subsystem=logging/root-logger=ROOT. This moves the >> change-root-log-level operation to that path. I was thinking about >> removing that operation as it should probably be handled via the >> write-attribute operation. >> >> Along with the change-root-log-level, I'd like to rename the >> "root-logger-assign-handler" and "root-logger-unassign-handler" to >> remove the "root-logger" prefix. >> >> Also, I'd like to remove the change-log-level in the >> /subsystem=logging/logger=name path. >> >> Anyone have any thoughts or concerns about this? >> > > -- > James R. Perkins > JBoss by Red Hat > > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev > _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

Please don't change this without an explicit OK from Heiko Rupp and Alexey Loubyansky. The web console guys have already replied and didn't object, so I assume they are ok with it. Please also plan on updating the community docs and directly notifying Misty Stanley-Jones. Changing an API that isn't wrong but is just duplicative is a lot of work if it's in a part of the model that has had docs and client tooling created around it.

Feeding off a previous short discussion about removing operations from subsystems, I was thinking of removing a few of the operations from the logging subsystem. We are giving the root-logger a proper address type of /subsystem=logging/root-logger=ROOT. This moves the change-root-log-level operation to that path. I was thinking about removing that operation as it should probably be handled via the write-attribute operation.

Anyone have any thoughts or concerns about this?

It sounds like it might be on our best interest to just leave it then.

The effort to support the code in the subsystem is not that difficult.

I was just more concerned with having non-conventional operation names in the subsystem and making it confusing in the CLI.

On 11/09/2011 01:47 AM, Heiko W.Rupp wrote: > > While I don't entirely like that so late in the game, > I can live with it. For us it makes it more complicated > to support 7.0 and 7.1 and EAP. While EAP is prio1, > if it makes it into 7.1 it should be ok, as 7.1 will be freely > available as well. > > Heiko >