I'm having the strangest problem with the server.log showing up in the bin directory in my fork of jboss-as (https://github.com/starksm64/jboss-as). It is reproducible and I'm seeing it on two different machines. I do not see it if I clone https://github.com/jbossas/jboss-as directly, but I do not have any outstanding changes in my workspace, so I don't know where the change is being introduced. I have debugged it to the point of seeing that the PeriodicRotatingFileHandlerAdd.execute call receives a ModelNode operation that has the file.{path,relative-to} information: { "operation" => "add", "address" => [ ("subsystem" => "logging"), ("periodic-rotating-file-handler" => "FILE") ], "autoflush" => true, "level" => "INFO", "formatter" => "%d{HH:mm:ss,SSS} %-5p [%c] (%t) %s%E%n", "file" => { "path" => "server.log", "relative-to" => "jboss.server.log.dir" }, "append" => true, "suffix" => ".yyyy-MM-dd", "operation-headers" => {"rollback-on-runtime-failure" => false}, "encoding" => undefined } but this test at PeriodicRotatingFileHandlerAdd.java:95 fails and so the dependency on relative-to is not added: if (operation.hasDefined(CommonAttributes.RELATIVE_TO)) { fileBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, RELATIVE_TO).asString()), String.class, fileService.getRelativeToInjector()); } Anyone know what is going on before I spend any more time debugging this?

So why isn't a pull from upstream bringing this change into my repo? [507][valkyrie: jboss-as]$ git remote show origin * remote origin Fetch URL: https://github.com/starksm64/jboss-as Push URL: https://github.com/starksm64/jboss-as HEAD branch: master Remote branches: master tracked refs/remotes/origin/JBAS-9225 stale (use 'git remote prune' to remove) Local branch configured for 'git pull': master merges with remote master Local ref configured for 'git push': master pushes to master (local out of date) [508][valkyrie: jboss-as]$ git pull --rebase upstream masterFrom git://github.com/jbossas/jboss-as * branch master -> FETCH_HEAD Current branch master is up to date. [509][valkyrie: jboss-as]$ git diff origin/master logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java | wc 72 255 5271 On 5/20/11 8:06 AM, Jason T. Greene wrote: > On 5/20/11 10:01 AM, Scott Stark wrote: >> I'm having the strangest problem with the server.log showing up in the >> bin directory in my fork of jboss-as >> (https://github.com/starksm64/jboss-as). It is reproducible and I'm >> seeing it on two different machines. I do not see it if I clone >> https://github.com/jbossas/jboss-as directly, but I do not have any >> outstanding changes in my workspace, so I don't know where the change is >> being introduced. >> >> I have debugged it to the point of seeing that the >> PeriodicRotatingFileHandlerAdd.execute call receives a ModelNode >> operation that has the file.{path,relative-to} information: >> >> { >> "operation" => "add", >> "address" => [ >> ("subsystem" => "logging"), >> ("periodic-rotating-file-handler" => "FILE") >> ], >> "autoflush" => true, >> "level" => "INFO", >> "formatter" => "%d{HH:mm:ss,SSS} %-5p [%c] (%t) %s%E%n", >> "file" => { >> "path" => "server.log", >> "relative-to" => "jboss.server.log.dir" >> }, >> "append" => true, >> "suffix" => ".yyyy-MM-dd", >> "operation-headers" => {"rollback-on-runtime-failure" => false}, >> "encoding" => undefined >> } >> >> but this test at PeriodicRotatingFileHandlerAdd.java:95 fails and so the >> dependency on relative-to is not added: >> if >> (operation.hasDefined(CommonAttributes.RELATIVE_TO)) { >> >> fileBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, >> RELATIVE_TO).asString()), String.class, >> fileService.getRelativeToInjector()); >> } >> Anyone know what is going on before I spend any more time debugging this? > > This looks like something that was already fixed: > > if (operation.hasDefined(FILE)) { > if (operation.get(FILE).hasDefined(RELATIVE_TO)) { > > serviceBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, > RELATIVE_TO).asString()), String.class, service.getRelativeToInjector()); > } > service.setPath(operation.get(FILE, PATH).asString()); > } > > > > Jason T. Greene > JBoss, a division of Red Hat > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

I don't get it. This claims there is no diff: [341](ironmaiden:jboss-as)> git diff upstream/master logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java[342](ironmaiden:jboss-as) > and yet if I clone git://github.com/jbossas/jboss-as.git into upstream-jboss-as and diff against that there are several differences: [340](ironmaiden:jboss-as)> diff logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java 36a37 > import static org.jboss.as.logging.CommonAttributes.HANDLER_TYPE; 38a40 > import static org.jboss.as.logging.CommonAttributes.QUEUE_LENGTH; 62a65,66 > static final String OPERATION_NAME = "add-periodic-handler"; > 73a78,83 > final String handlerType = operation.require(HANDLER_TYPE).asString(); > final LoggerHandlerType type = LoggerHandlerType.valueOf(handlerType); > if(type != LoggerHandlerType.PERIODIC_ROTATING_FILE_HANDLER) { > throw new OperationFailedException(new ModelNode().set("invalid operation for handler-type: " + type)); > } > 77a88 > subModel.get(HANDLER_TYPE).set(handlerType); 79a91 > subModel.get(QUEUE_LENGTH).set(operation.get(QUEUE_LENGTH)); 90,93c102,103 < final HandlerFileService fileService = new HandlerFileService(operation.get(FILE, PATH).asString()); < final ServiceBuilder<?> fileBuilder = serviceTarget.addService(LogServices.handlerFileName(name), fileService); < if (operation.hasDefined(CommonAttributes.RELATIVE_TO)) { < fileBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, RELATIVE_TO).asString()), String.class, fileService.getRelativeToInjector()); --- > if (operation.get(FILE).hasDefined(RELATIVE_TO)) { > serviceBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, RELATIVE_TO).asString()), String.class, service.getRelativeToInjector()); 95,96c105 < fileBuilder.setInitialMode(ServiceController.Mode.ACTIVE).install(); < serviceBuilder.addDependency(LogServices.handlerFileName(name), String.class, service.getFileNameInjector()); --- > service.setPath(operation.get(FILE, PATH).asString()); [343](ironmaiden:jboss-as)> diff logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java | cksum 494053061 1917 On 5/20/11 8:39 AM, Jason T. Greene wrote: > It looks like you are diffing your local tree against your github > origin, instead of upstream. BTW your origin has a merge commit at the > top right now. You probably want to git push -f it. > > > _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

I see it too using the latest upstream. So it's not because you're checkout is out of date. On 5/20/11 12:22 PM, Scott Stark wrote: > This is ridiculous. I created another github account, forked > jbossas/jboss-as: > https://github.com/starksmjboss/jboss-as > > clone that, build it and run it and still see the same problem: > > [368](ironmaiden:bin)> ls > domain.bat jboss-admin.bat standalone.bat wsconsume.bat > wsprovide.sh > domain.conf jboss-admin.sh standalone.conf wsconsume.sh > domain.sh server.log standalone.sh wsprovide.bat > >

I think I know the fix. On 5/20/11 12:41 PM, Scott Stark wrote: > Thank goodness. > > On 5/20/11 10:35 AM, Brian Stansberry wrote: >> I see it too using the latest upstream. So it's not because you're >> checkout is out of date. >> >> On 5/20/11 12:22 PM, Scott Stark wrote: >>> This is ridiculous. I created another github account, forked >>> jbossas/jboss-as: >>> https://github.com/starksmjboss/jboss-as >>> >>> clone that, build it and run it and still see the same problem: >>> >>> [368](ironmaiden:bin)> ls >>> domain.bat jboss-admin.bat standalone.bat wsconsume.bat >>> wsprovide.sh >>> domain.conf jboss-admin.sh standalone.conf wsconsume.sh >>> domain.sh server.log standalone.sh wsprovide.bat >>> >>> > > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

I keep seeing two issues with de-typed: - traceability of operations (in IDE, during refactoring) - plain invalid invocations, like this one We need more coverage on de-typed operations. But maybe we can also tie the runtime to the descriptions, so that invalid operations are caught. (A special mode of running?)

Carlo On 05/20/2011 08:01 PM, Brian Stansberry wrote: > Fixed. > > http://github.com/jbossas/jboss-as/compare/78ee9b2...0a8d61e > > On 5/20/11 12:44 PM, Brian Stansberry wrote: >> I think I know the fix. >> >> On 5/20/11 12:41 PM, Scott Stark wrote: >>> Thank goodness. >>> >>> On 5/20/11 10:35 AM, Brian Stansberry wrote: >>>> I see it too using the latest upstream. So it's not because you're >>>> checkout is out of date. >>>> >>>> On 5/20/11 12:22 PM, Scott Stark wrote: >>>>> This is ridiculous. I created another github account, forked >>>>> jbossas/jboss-as: >>>>> https://github.com/starksmjboss/jboss-as >>>>> >>>>> clone that, build it and run it and still see the same problem: >>>>> >>>>> [368](ironmaiden:bin)> ls >>>>> domain.bat jboss-admin.bat standalone.bat wsconsume.bat >>>>> wsprovide.sh >>>>> domain.conf jboss-admin.sh standalone.conf wsconsume.sh >>>>> domain.sh server.log standalone.sh wsprovide.bat >>>>> >>>>> >>> _______________________________________________ >>> jboss-as7-dev mailing list >>> jboss-as7-dev(a)lists.jboss.org >>> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev >> > _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

On May 23, 2011, at 5:25 AM, Carlo de Wolf&lt;cdewolf(a)redhat.com&gt; wrote: > We need more coverage on de-typed operations. > But maybe we can also tie the runtime to the descriptions, so that > invalid operations are caught. (A special mode of running?) > That was something Brian and I were discussing at JBW, using descriptions to validate. It will be tough to get that into 7.0 though (unfortunately).

This is ridiculous. I created another github account, forked jbossas/jboss-as: https://github.com/starksmjboss/jboss-as clone that, build it and run it and still see the same problem: [368](ironmaiden:bin)> ls domain.bat jboss-admin.bat standalone.bat wsconsume.bat wsprovide.sh domain.conf jboss-admin.sh standalone.conf wsconsume.sh domain.sh server.log standalone.sh wsprovide.bat On 5/20/11 9:49 AM, Scott Stark wrote: > I don't get it. This claims there is no diff: > > [341](ironmaiden:jboss-as)> git diff upstream/master > logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java[342](ironmaiden:jboss-as) > > > > and yet if I clone git://github.com/jbossas/jboss-as.git into > upstream-jboss-as and diff against that there are several differences: > > [340](ironmaiden:jboss-as)> diff > logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java > /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java > 36a37 > > import static org.jboss.as.logging.CommonAttributes.HANDLER_TYPE; > 38a40 > > import static org.jboss.as.logging.CommonAttributes.QUEUE_LENGTH; > 62a65,66 > > static final String OPERATION_NAME = "add-periodic-handler"; > > > 73a78,83 > > final String handlerType = > operation.require(HANDLER_TYPE).asString(); > > final LoggerHandlerType type = > LoggerHandlerType.valueOf(handlerType); > > if(type != LoggerHandlerType.PERIODIC_ROTATING_FILE_HANDLER) { > > throw new OperationFailedException(new > ModelNode().set("invalid operation for handler-type: " + type)); > > } > > > 77a88 > > subModel.get(HANDLER_TYPE).set(handlerType); > 79a91 > > subModel.get(QUEUE_LENGTH).set(operation.get(QUEUE_LENGTH)); > 90,93c102,103 > < final HandlerFileService fileService = new > HandlerFileService(operation.get(FILE, PATH).asString()); > < final ServiceBuilder<?> fileBuilder = > serviceTarget.addService(LogServices.handlerFileName(name), fileService); > < if > (operation.hasDefined(CommonAttributes.RELATIVE_TO)) { > < > fileBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, > RELATIVE_TO).asString()), String.class, > fileService.getRelativeToInjector()); > --- > > if > (operation.get(FILE).hasDefined(RELATIVE_TO)) { > > > serviceBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, > RELATIVE_TO).asString()), String.class, service.getRelativeToInjector()); > 95,96c105 > < > fileBuilder.setInitialMode(ServiceController.Mode.ACTIVE).install(); > < > serviceBuilder.addDependency(LogServices.handlerFileName(name), > String.class, service.getFileNameInjector()); > --- > > service.setPath(operation.get(FILE, > PATH).asString()); > > [343](ironmaiden:jboss-as)> diff > logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java > /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java > | cksum > 494053061 1917 > > > On 5/20/11 8:39 AM, Jason T. Greene wrote: >> It looks like you are diffing your local tree against your github >> origin, instead of upstream. BTW your origin has a merge commit at the >> top right now. You probably want to git push -f it. >> >> >> > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev

https://github.com/wolfc/jboss-as/commit/170249b1435e430ab8d0f6a726e6b17e...

I thought it was due to me running stuff in the IDE. Then it is most likely one of the Arquillian configs. Carlo On 05/20/2011 07:22 PM, Scott Stark wrote: > This is ridiculous. I created another github account, forked > jbossas/jboss-as: > https://github.com/starksmjboss/jboss-as > > clone that, build it and run it and still see the same problem: > > [368](ironmaiden:bin)> ls > domain.bat jboss-admin.bat standalone.bat wsconsume.bat > wsprovide.sh > domain.conf jboss-admin.sh standalone.conf wsconsume.sh > domain.sh server.log standalone.sh wsprovide.bat > > > On 5/20/11 9:49 AM, Scott Stark wrote: >> I don't get it. This claims there is no diff: >> >> [341](ironmaiden:jboss-as)> git diff upstream/master >> logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java[342](ironmaiden:jboss-as) >> > >> >> and yet if I clone git://github.com/jbossas/jboss-as.git into >> upstream-jboss-as and diff against that there are several differences: >> >> [340](ironmaiden:jboss-as)> diff >> logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java >> /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java >> 36a37 >> > import static org.jboss.as.logging.CommonAttributes.HANDLER_TYPE; >> 38a40 >> > import static org.jboss.as.logging.CommonAttributes.QUEUE_LENGTH; >> 62a65,66 >> > static final String OPERATION_NAME = "add-periodic-handler"; >> > >> 73a78,83 >> > final String handlerType = >> operation.require(HANDLER_TYPE).asString(); >> > final LoggerHandlerType type = >> LoggerHandlerType.valueOf(handlerType); >> > if(type != LoggerHandlerType.PERIODIC_ROTATING_FILE_HANDLER) { >> > throw new OperationFailedException(new >> ModelNode().set("invalid operation for handler-type: " + type)); >> > } >> > >> 77a88 >> > subModel.get(HANDLER_TYPE).set(handlerType); >> 79a91 >> > subModel.get(QUEUE_LENGTH).set(operation.get(QUEUE_LENGTH)); >> 90,93c102,103 >> < final HandlerFileService fileService = new >> HandlerFileService(operation.get(FILE, PATH).asString()); >> < final ServiceBuilder<?> fileBuilder = >> serviceTarget.addService(LogServices.handlerFileName(name), fileService); >> < if >> (operation.hasDefined(CommonAttributes.RELATIVE_TO)) { >> < >> fileBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, >> RELATIVE_TO).asString()), String.class, >> fileService.getRelativeToInjector()); >> --- >> > if >> (operation.get(FILE).hasDefined(RELATIVE_TO)) { >> > >> serviceBuilder.addDependency(AbstractPathService.pathNameOf(operation.get(FILE, >> RELATIVE_TO).asString()), String.class, service.getRelativeToInjector()); >> 95,96c105 >> < >> fileBuilder.setInitialMode(ServiceController.Mode.ACTIVE).install(); >> < >> serviceBuilder.addDependency(LogServices.handlerFileName(name), >> String.class, service.getFileNameInjector()); >> --- >> > service.setPath(operation.get(FILE, >> PATH).asString()); >> >> [343](ironmaiden:jboss-as)> diff >> logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java >> /home/git/JBossAS/upstream-jboss-as/logging/src/main/java/org/jboss/as/logging/PeriodicRotatingFileHandlerAdd.java >> | cksum >> 494053061 1917 >> >> >> On 5/20/11 8:39 AM, Jason T. Greene wrote: >>> It looks like you are diffing your local tree against your github >>> origin, instead of upstream. BTW your origin has a merge commit at the >>> top right now. You probably want to git push -f it. >>> >>> >>> >> _______________________________________________ >> jboss-as7-dev mailing list >> jboss-as7-dev(a)lists.jboss.org >> https://lists.jboss.org/mailman/listinfo/jboss-as7-dev > _______________________________________________ > jboss-as7-dev mailing list > jboss-as7-dev(a)lists.jboss.org > https://lists.jboss.org/mailman/listinfo/jboss-as7-dev _______________________________________________ jboss-as7-dev mailing list jboss-as7-dev(a)lists.jboss.org https://lists.jboss.org/mailman/listinfo/jboss-as7-dev