[JBoss JIRA] Commented: (JBRULES-269) Parser to be stricter with newlines
by Dirk Bergstrom (JIRA)
[ http://jira.jboss.com/jira/browse/JBRULES-269?page=comments#action_12346703 ]
Dirk Bergstrom commented on JBRULES-269:
----------------------------------------
I think it would be quite reasonable to require that rule, when, then & end be on their own lines. It would enforce a modicum of clarity, and avoid "goddam keyword collisions", as noted elsewhere.
I have no objection to enforcing column positions, but then again I like Python.
> Parser to be stricter with newlines
> -----------------------------------
>
> Key: JBRULES-269
> URL: http://jira.jboss.com/jira/browse/JBRULES-269
> Project: JBoss Rules
> Issue Type: Feature Request
> Security Level: Public(Everyone can see)
> Components: Drl Parser/Builder
> Affects Versions: 3.0-rc2
> Reporter: Michael Neale
> Assigned To: Michael Neale
> Fix For: 3.1-m3
>
>
> Given that we are not going down the route of
> when {
> }
> style brackets, we will need to be stricter about newlines.
> In otherwords, newlines are required I believe in the following scenarious:
> before a when,
> after a when before the LHS
> before a then
> after a then before then RHS
> before an end (at the end of the rule).
> when,then, end - should all appear on a line by themselves.
> Optionally (perhaps?) rule should always be at the start of a newline.
> on a similar note, should rule and end be at the start of a newline? (don't really want to have to enforce column positions - but it is kind of needed).
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 6 months
[JBoss JIRA] Created: (JBRULES-550) NPE while removing and adding same package
by Ravi Godbole (JIRA)
NPE while removing and adding same package
------------------------------------------
Key: JBRULES-550
URL: http://jira.jboss.com/jira/browse/JBRULES-550
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Drl Parser/Builder
Affects Versions: 3.0.4
Environment: Windows
Reporter: Ravi Godbole
Assigned To: Mark Proctor
I am trying to reload the rule which is modified externally [ without stopping my rule engine which already has the mentioned rule loaded]. When adding is commented everything works well.
// Code snippet as follows
ruleBase = RuleBaseFactory.newRuleBase();
final Reader source = new InputStreamReader( RuleService.class.getResourceAsStream("/rules/" + "TestAddNew.drl" ) );
PackageBuilder builder = new PackageBuilder();
builder.addPackageFromDrl( source );
ruleBase.addPackage( builder.getPackage() );
workingMemory = ruleBase.newWorkingMemory( );
workingMemory.assertObject(new Object());
ruleBase.removePackage("com.test.one");
final Reader sourceOne = new InputStreamReader( RuleService.class.getResourceAsStream("/rules/" + "TestAddNew.drl" ) );
PackageBuilder builder_1 = new PackageBuilder();
builder_1.addPackageFromDrl( sourceOne );
ruleBase.addPackage( builder_1.getPackage() );
System.out.println("Rule successfully Added");
///////////// Rule file //////////////////////////
package com.test.one
import java.lang.Object;
rule addNewRule
no-loop true
when
eval( 1 > 2 )
then
System.out.println("True evaluated");
end
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 6 months
[JBoss JIRA] Commented: (JBCACHE-485) Refactor the current Collection classes (list and set)
by Ben Wang (JIRA)
[ http://jira.jboss.com/jira/browse/JBCACHE-485?page=comments#action_12346676 ]
Ben Wang commented on JBCACHE-485:
----------------------------------
Elias, currently collection.ReplicatedSyncSetTest still fails with one more test. Not sure if it is introduced recently or not. I don't have time to fix it. But would you mind to take a look? :-) Thanks! -Ben
> Refactor the current Collection classes (list and set)
> ------------------------------------------------------
>
> Key: JBCACHE-485
> URL: http://jira.jboss.com/jira/browse/JBCACHE-485
> Project: JBoss Cache
> Issue Type: Task
> Security Level: Public(Everyone can see)
> Components: PojoCache
> Reporter: Ben Wang
> Assigned To: Ben Wang
> Priority: Critical
> Fix For: PojoCache
>
> Attachments: icache.diff, set.diff
>
> Original Estimate: 4 weeks
> Remaining Estimate: 4 weeks
>
> Current implementation of Collection uses direct coupling to the cache store indices. E.g., we map them into subtree according to index ordering. This is not very desirable for performance reason. We should consider to provide a indirect mapping such that it is considered a graph instead of ordered tree.
> Or we should investigate whether it is possible to use a proxy operates on java.util.* classes such that we don't need to have our own implementation. The JDK lincense aside, ArrayList, e.g., uses an internal transient array. Is it possible to "aspectize" on that array only?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 6 months