[JBoss JIRA] Created: (JBCACHE-911) Remove or refactor NodeFactory
by Elias Ross (JIRA)
Remove or refactor NodeFactory
------------------------------
Key: JBCACHE-911
URL: http://jira.jboss.com/jira/browse/JBCACHE-911
Project: JBoss Cache
Issue Type: Task
Security Level: Public (Everyone can see)
Reporter: Elias Ross
Assigned To: Manik Surtani
I don't see any external use for this class in 2.0 and think it's quite ugly. There is no way to configure the behavior. Users shouldn't use it anyway.
Places it is called:
* NodeImpl.getOrCreateChild() -> I'm thinking that adding a "template method" to say AbstractNode
protected abstract Node createNode(Fqn child_fqn, Node parent, TreeCache x);
would be good. OptimisticNode or WorkspaceNode can obviously override this.
* TreeCache {}: Since it's configuration driven, map an "enum" to a series of "new NodeXYZ()" statements.
* OptimisticXYZInterceptor : Create factory methods in TransactionWorkspace
* DefaultStateTransferIntegrator : ??
Node target = factory.createDataNode(nodeType, name, fqn, parent, nd.getAttributes(), false, null, cache.getCacheSPI());
((DataNode) parent).addChild(name, target);
Should simply be able to call parent.addChild(name) here. There is the (small) optimization of reusing the attribute Map directly, but this is probably a premature optimization. Or, maybe just parent.put(name, nd.getAttributes()) ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months
[JBoss JIRA] Created: (JBTM-188) ConcurrentModificationException during commit time Synchronization processing
by Jonathan Halliday (JIRA)
ConcurrentModificationException during commit time Synchronization processing
-----------------------------------------------------------------------------
Key: JBTM-188
URL: http://jira.jboss.com/jira/browse/JBTM-188
Project: JBoss Transaction Manager
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: JTA Implementation
Affects Versions: 4.2.3
Environment: java 1.5, linux, TS 4.2.3.CR2 jta
Reporter: Jonathan Halliday
Assigned To: Jonathan Halliday
Fix For: 4.2.3
When a Synchronization's beforeCompletion method registers another Synchrinization to the transaction, Bad Things happen.
12:38:20,062 ERROR [STDERR] java.util.ConcurrentModificationException
12:38:20,092 ERROR [STDERR] at java.util.TreeMap$PrivateEntryIterator.nextEntry(TreeMap.java:1031)
12:38:20,092 ERROR [STDERR] at java.util.TreeMap$KeyIterator.next(TreeMap.java:1058)
12:38:20,092 ERROR [STDERR] at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.beforeCompletion(TwoP
haseCoordinator.java:211)
12:38:20,092 ERROR [STDERR] at com.arjuna.ats.arjuna.coordinator.TwoPhaseCoordinator.end(TwoPhaseCoordinat
or.java:88)
12:38:20,092 ERROR [STDERR] at com.arjuna.ats.arjuna.AtomicAction.commit(AtomicAction.java:177)
12:38:20,092 ERROR [STDERR] at com.arjuna.ats.internal.jta.transaction.arjunacore.TransactionImple.commitA
ndDisassociate(TransactionImple.java:1204)
12:38:20,112 ERROR [STDERR] at com.arjuna.ats.internal.jta.transaction.arjunacore.BaseTransaction.commit(B
aseTransaction.java:134)
12:38:20,112 ERROR [STDERR] at com.arjuna.ats.jbossatx.BaseTransactionManagerDelegate.commit(BaseTransacti
onManagerDelegate.java:87)
12:38:20,112 ERROR [STDERR] at org.jboss.test.cmp2.ageout.test.JDBC2PmAgeOutUnitTestCase.commitTx(JDBC2PmA
geOutUnitTestCase.java:236)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months