[JBoss JIRA] Created: (JBAS-4413) Incorrect behaviour in TCLFilter
by Poyan (JIRA)
Incorrect behaviour in TCLFilter
--------------------------------
Key: JBAS-4413
URL: http://jira.jboss.com/jira/browse/JBAS-4413
Project: JBoss Application Server
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: Logging
Affects Versions: JBossAS-4.0.5.GA
Reporter: Poyan
Assigned To: Scott M Stark
Just one TCLFilter can be added to an appender, decide method return either ACCEPT or DENY.
Should return NEUTRAL is some case.
public int decide(LoggingEvent event)
{
int ok = Filter.DENY;
if( acceptOnMatch == true )
{
ok = Filter.DENY;
if( isMatchingTCL() ){
ok = Filter.ACCEPT;
}
}
else
{
ok = Filter.ACCEPT; // CHANGING THIS ROW TO ok = Filter.NEUTRAL; should do that you check the other filters to.
if( isMatchingTCL() )
ok = Filter.DENY;
}
return ok;
}
Log4j.xml:
<appender name="CONSOLE" class="org.apache.log4j.ConsoleAppender">
<layout class="org.apache.log4j.PatternLayout">
<param name="ConversionPattern" value="%d %-5p [%t] %c - %m%n"/>
</layout>
<filter class="org.jboss.logging.filter.TCLFilter">
<param name="AcceptOnMatch" value="false"/>
<param name="DeployURL" value="jboss-common-client.jarpoyan"/>
</filter>
<filter class="org.jboss.logging.filter.TCLFilter">
<param name="AcceptOnMatch" value="false"/>
<param name="DeployURL" value="dnsns.jarpoyan"/>
</filter>
</appender>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years
[JBoss JIRA] Created: (JGRP-563) Consolidate state transfer API to use streams
by Vladimir Blagojevic (JIRA)
Consolidate state transfer API to use streams
---------------------------------------------
Key: JGRP-563
URL: http://jira.jboss.com/jira/browse/JGRP-563
Project: JGroups
Issue Type: Task
Reporter: Vladimir Blagojevic
Assigned To: Vladimir Blagojevic
Fix For: 3.0
Although streaming state transfer has its advantages over byte based state transfer, byte based state transfer is absolutely necessary since streaming based transfer relies on plain sockets that are not firewall friendly. However, that does not mean that we cannot consolidate state transfer API at application level and mask byte based transfer with streams. We have already done this in JBC 2.0 so there is no reason not to do it on JGroups level as well.
Advantages:
- simpler state transfer API
- interchangeable state transfer mechanism without affect on application
- simplification of client application
Disadvantages:
- we break current API by eliminating getState(byte[]) and setState(byte [])
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 1 month