[JBoss JIRA] Created: (JBCACHE-823) Refactor eviction configuration away from EvictionConfiguration interface
by Brian Stansberry (JIRA)
Refactor eviction configuration away from EvictionConfiguration interface
-------------------------------------------------------------------------
Key: JBCACHE-823
URL: http://jira.jboss.com/jira/browse/JBCACHE-823
Project: JBoss Cache
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Reporter: Brian Stansberry
Assigned To: Brian Stansberry
Fix For: 2.0.0.GA
The EvictionConfiguration interface presumes that objects that represent a policy configuration should be able to parse their XML config themselves. We don't want that; parsing of the legacy XML configs should be handled by XmlConfigurationParser and policy config objects should be configurable by the MC without their having any internal expectation of being passed a DOM element.
To do this:
1) Create interface EvictionPolicyConfig. This is used internally (e.g. in the RegionManager and Region classes) in place of EvictionConfiguration.
2) All of the config classes for the standard eviction policies now implement EvictionPolicyConfig instead of EvictionConfiguration.
To support old custom policies:
1) EvictionConfiguration still exists but is deprecated.
2) EvictionConfiguration now extends EvictionPolicyConfig. So, custom impls *will* need to be modified to implement EvictionPolicyConfig's 2 methods.
3) XmlConfigurationParser when trying to configure a policy config object will check if it implements EvictionConfiguration. If it does, the legacy parseXmlConfig(Element) method will be called. Otherwise it will be configured via reflection.
Need to decided exactly how to handle the old public EvictionConfiguration Region.getEvictionConfiguration() method.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 1 month
[JBoss JIRA] Created: (JBCACHE-822) Reconsider validation of EvictionPolicyConfig objects
by Brian Stansberry (JIRA)
Reconsider validation of EvictionPolicyConfig objects
-----------------------------------------------------
Key: JBCACHE-822
URL: http://jira.jboss.com/jira/browse/JBCACHE-822
Project: JBoss Cache
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Reporter: Brian Stansberry
Assigned To: Manik Surtani
In the legacy code, various impls of EvictionConfiguration would validate input during calls to parseXmlConfig. Problem is that if a config was instantiated and configured programatically, no validation occurred. Further the old parseXmlConfig validations basically just tested whether a configuration element was present, not whether it had a reasonable value.
The new validate() methods really should just test for reasonable values; whether the value was configured externally or was there by default is irrelevant.
Main task here is to remove some old unit tests that checked whether a value was set or not during xml parsing and replace with tests that check whether the reasonable value requirement is enforced.
Probably will do this after alpha.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 1 month
[JBoss JIRA] Created: (JGRP-416) MergeView processing fails for Multiplexer channel
by Jerry Gauthier (JIRA)
MergeView processing fails for Multiplexer channel
--------------------------------------------------
Key: JGRP-416
URL: http://jira.jboss.com/jira/browse/JGRP-416
Project: JGroups
Issue Type: Bug
Affects Versions: 2.4.1
Reporter: Jerry Gauthier
Assigned To: Bela Ban
When I simulate a cluster failure and restart using a Multiplexer channel, the merge process fails in JGroups with an UnsupportedOperationException in Multiplexer.mergeServiceState(). The stack trace is as follows.
ERROR [org.jgroups.mux.Multiplexer] problems handling merge view java.lang.UnsupportedOperationException
at org.jgroups.util.UnmodifiableVector.retainAll(UnmodifiableVector.java:158)
at org.jgroups.mux.Multiplexer.mergeServiceState(Multiplexer.java:867)
at org.jgroups.mux.Multiplexer.handleMergeView(Multiplexer.java:812)
at org.jgroups.mux.Multiplexer.access$200(Multiplexer.java:21)
at org.jgroups.mux.Multiplexer$1.run(Multiplexer.java:287)
I looked at the relevant JGroups code and it appears that JGroups uses a MergeView object that always returns an UnmodifiableVector when MergeView.getMembers() is invoked. The Multiplexer.mergeServiceState() method invokes MergeView.getMembers() followed by UnmodifiableVector(.retainAll(), causing the exception to occur.
This problem can be replicated by executing DRMTestCase in JBossAS 5.0. The error occurs in DRMTestCase.isMasterReplica().
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 1 month