[JBoss JIRA] Updated: (JBMESSAGING-152) Refactor exception handling
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-152?page=all ]
Tim Fox updated JBMESSAGING-152:
--------------------------------
Summary: Refactor exception handling (was: Revisit exception handling)
Fix Version/s: 2.0.0 Beta 1
(was: Unscheduled)
> Refactor exception handling
> ---------------------------
>
> Key: JBMESSAGING-152
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-152
> Project: JBoss Messaging
> Issue Type: Task
> Components: JMS Facade
> Reporter: Tim Fox
> Assigned To: Tim Fox
> Priority: Minor
> Fix For: 2.0.0 Beta 1
>
> Original Estimate: 1 day, 4 hours
> Remaining Estimate: 1 day, 4 hours
>
> We should audit the exception handling.
> In some areas it is quite sloppy including anti-patterns such as:
> 1. Logging errors when they're not being handled
> 2. Rethrowing with less information. E.g. losing the message or original exception.
> 3. Too much usage of "throws Throwable" or "throws Exception" where probably unnecessary.
> 4. Swallowing exceptions.
> We need to go through the whole of the code, auditing and changing as necessary.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months
[JBoss JIRA] Closed: (JBMESSAGING-216) Prepare Messaging to replace JBossMQ in the JBoss Mail distribution
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-216?page=all ]
Tim Fox closed JBMESSAGING-216.
-------------------------------
Resolution: Won't Fix
> Prepare Messaging to replace JBossMQ in the JBoss Mail distribution
> -------------------------------------------------------------------
>
> Key: JBMESSAGING-216
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-216
> Project: JBoss Messaging
> Issue Type: Task
> Components: Tests and Performance
> Reporter: Ovidiu Feodorov
> Priority: Minor
> Fix For: Unscheduled
>
>
> Andy's input:
> does jboss messaging:
> 1. recover from outages with incomplete blobs being written?
> 2. avoid making 3 copies of a message in memory?
> 3. install cleanly on JBoss 4.0.3SP1/JDK5?
> 4. work with Postgresql, MySQL, Hypersonic?
> 5. perform better/on par with JBossMQ when used locally (no remote invocation)
> 6. Have a reasonably simple method of swapping out its persistence layer ?
> #1 is a particularly bad problem (in my view it should be detected and moved to the DMQ with a the blob truncated and a reference to the orgininal record [which should be excluded from mainstream processing by a flag])
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months
[JBoss JIRA] Updated: (JBMESSAGING-271) Modifying a server/**/*Advised.java or a client/**/**Delegate.java file breaks the incremental build, because of AOPC failure
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-271?page=all ]
Tim Fox updated JBMESSAGING-271:
--------------------------------
Fix Version/s: Miscellaneous
(was: Unscheduled)
> Modifying a server/**/*Advised.java or a client/**/**Delegate.java file breaks the incremental build, because of AOPC failure
> -----------------------------------------------------------------------------------------------------------------------------
>
> Key: JBMESSAGING-271
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-271
> Project: JBoss Messaging
> Issue Type: Bug
> Components: Build System
> Reporter: Ovidiu Feodorov
> Priority: Minor
> Fix For: Miscellaneous
>
>
> Modifying a class that is going to be AOPCed (server/**/*Advised.java or a client/**/**Delegate.java) breaks the incremental build, as the AOPC fails to process it:
> compile-classes:
> [javac] Compiling 1 source file to C:\work\src\cvs\jboss-head\jms\output\classes
> [aopc] java.lang.RuntimeException: defrost(): org.jboss.jms.client.delegate.ClientBrowserDelegate$close_N4742752445160157748 was pruned.
> [aopc] at javassist.CtClassType.checkPruned(CtClassType.java:1093)
> [aopc] at javassist.CtClassType.defrost(CtClassType.java:272)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.defrostClassIfExists(OptimizedInvocations.java:66)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.makeInvocationClass(OptimizedInvocations.java:96)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodInvocations.createOptimizedInvocationClass(OptimizedMethodInvocations.java:78)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodExecutionTransformer.transformMethod(OptimizedMethodExecutionTransformer.java:59)
> [aopc] at org.jboss.aop.instrument.MethodExecutionTransformer.instrument(MethodExecutionTransformer.java:137)
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:654)
> [aopc] at org.jboss.aop.AspectManager.translate(AspectManager.java:835)
> [aopc] at org.jboss.aop.AspectManager.transform(AspectManager.java:747)
> [aopc] at org.jboss.aop.standalone.Compiler.compileFile(Compiler.java:345)
> [aopc] at org.jboss.aop.standalone.Compiler.compile(Compiler.java:234)
> [aopc] at org.jboss.aop.standalone.Compiler.main(Compiler.java:90)
> [aopc] [error] failed to transform: org.jboss.jms.client.delegate.ClientBrowserDelegate.. Do verbose mode if you want full stack trace.
> [aopc] java.lang.RuntimeException: failed to transform: org.jboss.jms.client.delegate.ClientBrowserDelegate
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:728)
> [aopc] at org.jboss.aop.AspectManager.translate(AspectManager.java:835)
> [aopc] at org.jboss.aop.AspectManager.transform(AspectManager.java:747)
> [aopc] at org.jboss.aop.standalone.Compiler.compileFile(Compiler.java:345)
> [aopc] at org.jboss.aop.standalone.Compiler.compile(Compiler.java:234)
> [aopc] at org.jboss.aop.standalone.Compiler.main(Compiler.java:90)
> [aopc] Caused by: java.lang.RuntimeException: defrost(): org.jboss.jms.client.delegate.ClientBrowserDelegate$close_N4742752445160157748 was pruned.
> [aopc] at javassist.CtClassType.checkPruned(CtClassType.java:1093)
> [aopc] at javassist.CtClassType.defrost(CtClassType.java:272)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.defrostClassIfExists(OptimizedInvocations.java:66)
> [aopc] at org.jboss.aop.instrument.OptimizedInvocations.makeInvocationClass(OptimizedInvocations.java:96)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodInvocations.createOptimizedInvocationClass(OptimizedMethodInvocations.java:78)
> [aopc] at org.jboss.aop.instrument.OptimizedMethodExecutionTransformer.transformMethod(OptimizedMethodExecutionTransformer.java:59)
> [aopc] at org.jboss.aop.instrument.MethodExecutionTransformer.instrument(MethodExecutionTransformer.java:137)
> [aopc] at org.jboss.aop.instrument.Instrumentor.transform(Instrumentor.java:654)
> [aopc] ... 5 more
> [aopc] Exception in thread "main"
> BUILD FAILED
> C:\work\src\cvs\jboss-head\jms\build.xml:339: Java returned: 1
> The workaround in this case is to do a ant clean and then rebuild everything from scratch, which is very inefficient.
> Must be fixed properly
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months
[JBoss JIRA] Closed: (JBMESSAGING-218) Persistent services are very noisy in the logs when the table(s) they are trying to create already exists
by Tim Fox (JIRA)
[ http://jira.jboss.com/jira/browse/JBMESSAGING-218?page=all ]
Tim Fox closed JBMESSAGING-218.
-------------------------------
Resolution: Won't Fix
set createTablesOnStartup to false if you don't want to attempt to create tables every time.
Note the excpetions are logged at DEBUG - so change your log4j settings if you don't like them.
> Persistent services are very noisy in the logs when the table(s) they are trying to create already exists
> ---------------------------------------------------------------------------------------------------------
>
> Key: JBMESSAGING-218
> URL: http://jira.jboss.com/jira/browse/JBMESSAGING-218
> Project: JBoss Messaging
> Issue Type: Sub-task
> Components: Messaging Core Persistence
> Reporter: Ovidiu Feodorov
> Priority: Minor
> Fix For: Unscheduled
>
> Original Estimate: 4 hours
> Remaining Estimate: 4 hours
>
> JDBCDurableSubscriptionStore, JDBCMessageStore, JDBCTransactionLog try to create their corresponding tables during their inialization procedure and litter the logs with SQLException stack traces if the corresponding tables exist:
> java.sql.SQLException: Table already exists: TRANSACTION in statement [CREATE TABLE TRANSACTION]
> at org.hsqldb.jdbc.Util.sqlException(Util.java:61)
> at org.hsqldb.jdbc.jdbcStatement.fetchResult(jdbcStatement.java:1580)
> .....
> Use a less noisy way to insure the tables exist. Swallowing the SQLException is not a solution, since it may signal other problems with the database.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
19 years, 3 months