[JBoss JIRA] Created: (JGRP-507) CloserThread's attempt to interrupt TimeScheduler on closure could be end up being ignored
by Galder Zamarreno (JIRA)
CloserThread's attempt to interrupt TimeScheduler on closure could be end up being ignored
------------------------------------------------------------------------------------------
Key: JGRP-507
URL: http://jira.jboss.com/jira/browse/JGRP-507
Project: JGroups
Issue Type: Bug
Reporter: Galder Zamarreno
Assigned To: Bela Ban
Fix For: 2.3 SP1, 2.3
A race condition in JGroups could cause a channel that should be closed (for example, after being shunned)
to never be closed.
In order to stop TimeScheduler thread, CloserThread set's TimeScheduler's thread status
as interrupted. If the interruption occurs while TimeScheduler is waiting, then no problems.
But, in TimeScheduler._run(), actual running of a task via task.run(); happens outside
synchronized(queue) block which means that CloserThread could set the TimeSchedule thread's
status as interrupted while the task is running, for example, sending an FD are-you-alive message.
If down the protocol that's carrying out the task, all down threads are set to false, and TimeScheduler
thread is interrupted while the task is running, the interruption could be caught while sending a message to network:
TP (UDP and TCP/TCP_NIO's parent):
TP.down(Event evt)
....
try {
if(use_outgoing_packet_handler)
outgoing_queue.put(msg);
else
send(msg, dest, multicast);
}
catch(QueueClosedException closed_ex) {
}
catch(InterruptedException interruptedEx) {
}
catch(Throwable e) {
if(log.isErrorEnabled()) log.error("failed sending message", e);
}
Catching InterruptedException and doing nothing will clear the Thread's interrupted status. If
the interruption from CloserThread is caught here, TimeScheduler thread will never finished,
leaving the channel blocked and never rejoining the cluster.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 11 months
[JBoss JIRA] Created: (EJBTHREE-975) HA-JNDI InitialContext for @Resource annotation
by Ana Holzbach (JIRA)
HA-JNDI InitialContext for @Resource annotation
-----------------------------------------------
Key: EJBTHREE-975
URL: http://jira.jboss.com/jira/browse/EJBTHREE-975
Project: EJB 3.0
Issue Type: Bug
Components: Clustering
Affects Versions: AS 4.2.0 GA
Reporter: Ana Holzbach
We're deploying ejbs in a clustered environment that access JMS topics with @Resource annotation as follows:
@Resource(mappedName = "TopicConnectionFactory")
private ConnectionFactory mJmsConnectionFactory;
@Resource(mappedName = "topic/RoomService/BedStaffUpdate")
private Topic mStaffUpdateTopic;
The topics are deployed in deploy-hasingleton and are available to the singleton master in the cluster only. The remaining nodes get the following error:
javax.naming.NameNotFoundException: topic not bound
at org.jnp.server.NamingServer.getBinding(NamingServer.java:529)
at org.jnp.server.NamingServer.getBinding(NamingServer.java:537)
at org.jnp.server.NamingServer.getObject(NamingServer.java:543)
at org.jnp.server.NamingServer.lookup(NamingServer.java:267)
at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:625)
at org.jnp.interfaces.NamingContext.lookup(NamingContext.java:587)
at javax.naming.InitialContext.lookup(InitialContext.java:351)
at flex.messaging.services.messaging.adapters.JMSProxy.getDestination(JMSProxy.java:186)
at flex.messaging.services.messaging.adapters.JMSTopicConsumer.start(JMSTopicConsumer.java:59)
at flex.messaging.services.messaging.adapters.JMSAdapter.manage(JMSAdapter.java:345)
at flex.messaging.services.MessageService.manageSubscriptions(MessageService.java:571)
at flex.messaging.services.MessageService.serviceCommand(MessageService.java:152)
at flex.messaging.MessageBroker.routeCommandToService(MessageBroker.java:622)
at flex.messaging.endpoints.AbstractEndpoint.serviceMessage(AbstractEndpoint.java:298)
at flex.messaging.endpoints.rtmp.AbstractRTMPServer.dispatchMessage(AbstractRTMPServer.java:682)
at flex.messaging.endpoints.rtmp.NIORTMPConnection$RTMPReader.run(NIORTMPConnection.java:665)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecut
or.java:643)
at edu.emory.mathcs.backport.java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.j
ava:668)
at java.lang.Thread.run(Thread.java:595)
See also http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4049784#4049784
According to Brian Stansberry the @Resource annotations are resolved relative to a default initial context, which will not work for the clustered environment, since we need access to the HA-JNDI context for these. Also according to Brian, getJndiProperties() in DeploymentUnit should be responsible for reading jndi properties defined at deployment through which we might be able to define an HA-JNDI context, but this method returns null in jboss 4.x and also in "2 out of the 3 impls in the AS 5 codebase". See also http://www.jboss.com/index.html?module=bb&op=viewtopic&t=109219
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 11 months
[JBoss JIRA] Created: (JBPORTAL-1505) Parameters class may have a "protected" internal Map, for overriding
by Antoine Herzog (JIRA)
Parameters class may have a "protected" internal Map, for overriding
--------------------------------------------------------------------
Key: JBPORTAL-1505
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1505
Project: JBoss Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Components: Portal Core
Affects Versions: 2.6 CR3
Environment: JBP2.6 RC3
Reporter: Antoine Herzog
Assigned To: Julien Viet
Priority: Minor
The class org.jboss.portlet.util.Parameters has a
private Map parameters;
put it with protected :
protected Map parameters;
so access it possible when overriding this class.
Example of needs :
- overriding the the Parameters class to provide access to the collection, etc...
- use of our own TotoParameters, inheriting from Parameters, to work it with specific features
for debugging... log what is in it (the Parameters class provide nothing to get the collection of key, the size() etc...)
and when overriding and modifying some CommandFactory and URLFactory
Turnaround : I use a ParametersHelper, to fill the Map of params, manipulate it, debug...
and just before to pass it to the portal (end of CommandFactory doMapping method), I build a Parameters instance from it.
It is ok in this use case, but overriding the class would be much better.
Thanks
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 11 months
[JBoss JIRA] Created: (JBRULES-849) DynamicRulesTest fails with JDK 1.6
by Lars Ivar Igesund (JIRA)
DynamicRulesTest fails with JDK 1.6
-----------------------------------
Key: JBRULES-849
URL: http://jira.jboss.com/jira/browse/JBRULES-849
Project: JBoss Rules
Issue Type: Bug
Security Level: Public (Everyone can see)
Affects Versions: 4.0.0.MR2
Environment: Linux, JDK 1.6
Reporter: Lars Ivar Igesund
Assigned To: Mark Proctor
I'm doing mvn install from trunk, using JDK 1.6 on Kubuntu Linux.
For module drools-compiler, testDynamicFunction in the file below results in an ERROR
drools-compiler/src/test/java/org/drools/integrationtests/DynamicRulesTest.java
The contents of drools-compiler/target/surefire-reports/org.drools.integrationtests.DynamicRulesTest.txt are
------------------------------------------------------------------------------
Test set: org.drools.integrationtests.DynamicRulesTest
-------------------------------------------------------------------------------
Tests run: 8, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.008 sec <<< FAILURE!
testDynamicFunction(org.drools.integrationtests.DynamicRulesTest) Time elapsed: 0.036 sec <<< ERROR!
java.lang.NoClassDefFoundError: org/drools/test/AddFive
at org.drools.test.Rule_global_rule_test_0.consequence(Rule_global_rule_test_0.java:9)
at org.drools.test.Rule_global_rule_test_0ConsequenceInvoker.evaluate(Rule_global_rule_test_0ConsequenceInvoker.java:20)
at org.drools.common.DefaultAgenda.fireActivation(DefaultAgenda.java:497)
at org.drools.common.DefaultAgenda.fireNextItem(DefaultAgenda.java:461)
at org.drools.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:372)
at org.drools.common.AbstractWorkingMemory.fireAllRules(AbstractWorkingMemory.java:353)
at org.drools.integrationtests.DynamicRulesTest.testDynamicFunction(DynamicRulesTest.java:312)
at org.drools.integrationtests.DynamicRulesTest.testDynamicFunction(DynamicRulesTest.java:312)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at junit.framework.TestCase.runTest(TestCase.java:154)
at junit.framework.TestCase.runBare(TestCase.java:127)
at junit.framework.TestResult$1.protect(TestResult.java:106)
at junit.framework.TestResult.runProtected(TestResult.java:124)
at junit.framework.TestResult.run(TestResult.java:109)
at junit.framework.TestCase.run(TestCase.java:118)
at junit.framework.TestSuite.runTest(TestSuite.java:208)
at junit.framework.TestSuite.run(TestSuite.java:203)
at sun.reflect.GeneratedMethodAccessor8.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.junit.JUnitTestSet.execute(JUnitTestSet.java:213)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.executeTestSet(AbstractDirectoryTestSuite.java:138)
at org.apache.maven.surefire.suite.AbstractDirectoryTestSuite.execute(AbstractDirectoryTestSuite.java:125)
at org.apache.maven.surefire.Surefire.run(Surefire.java:132)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.apache.maven.surefire.booter.SurefireBooter.runSuitesInProcess(SurefireBooter.java:290)
at org.apache.maven.surefire.booter.SurefireBooter.main(SurefireBooter.java:818)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 11 months
[JBoss JIRA] Created: (JBMESSAGING-629) Unneccessary puts and gets in message store
by Tim Fox (JIRA)
Unneccessary puts and gets in message store
-------------------------------------------
Key: JBMESSAGING-629
URL: http://jira.jboss.com/jira/browse/JBMESSAGING-629
Project: JBoss Messaging
Issue Type: Task
Affects Versions: 1.0.1.GA, 1.2.0.Alpha1
Reporter: Tim Fox
Assigned To: Tim Fox
Fix For: 1.2.0.Beta1
We are currently executing unnecessary puts into the message store on the primary execution path of message routing.
When a new message arrives - it is first added to the message store. The message is only ever retrieved from the message store if a reference is loaded from paging and we want to make sure we do not have more than once instance in memory at once.
The first put is therefore unnecessary and will have some performance implications. Messages should only be added to the message store (if necessary) when they are paged to storage
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 11 months