[JBoss JIRA] Created: (JBREM-953) CLONE [JBREM-945] - Allow ServerThread to keep running after SocketTImeoutException
by Ron Sigal (JIRA)
CLONE [JBREM-945] - Allow ServerThread to keep running after SocketTImeoutException
-----------------------------------------------------------------------------------
Key: JBREM-953
URL: http://jira.jboss.com/jira/browse/JBREM-953
Project: JBoss Remoting
Issue Type: Task
Security Level: Public (Everyone can see)
Affects Versions: 2.2.2.SP4
Reporter: Ron Sigal
Assigned To: Ron Sigal
Priority: Minor
Fix For: 2.2.2.SP7
Currently, org.jboss.remoting.transport.socket.ServerThread will close its socket and return itself to the threadpool in the event of a SocketTimeoutException. However, it could simply continue trying to read the next invocation. The javadoc for java.net.Socket.setSoTimeout() states:
Enable/disable SO_TIMEOUT with the specified timeout, in milliseconds. With this option set to a non-zero timeout, a read() call on the InputStream associated with this Socket will block for only this amount of time. If the timeout expires, a java.net.SocketTimeoutException is raised, though the Socket is still valid.
If the timeout is due to transitory circumstances, then it would be much more efficient to allow the ServerThread to continue, rather than forcing the client to start over with a new socket.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 3 months
[JBoss JIRA] Created: (JBREM-951) CLONE [JBREM-942] - A deadlock encountered on ConnectionValidator
by Ron Sigal (JIRA)
CLONE [JBREM-942] - A deadlock encountered on ConnectionValidator
------------------------------------------------------------------
Key: JBREM-951
URL: http://jira.jboss.com/jira/browse/JBREM-951
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: transport
Affects Versions: 2.2.2.SP5
Environment: JBoss-EAP-4.2, JBossMessaging-1.4.0-SP3, JBossRemoting-2.2.2-SP5
Reporter: Tyronne Wickramarathne
Assigned To: Ron Sigal
Priority: Critical
Fix For: 2.2.2.SP7
This deadlock occurred on JBREM when a JBossMessaging Bridge was set and consuming messages. here's the StackTrace :
Found one Java-level deadlock:
=============================
"Thread-278":
waiting to lock monitor 0x08128544 (object 0xce8b25e0, a java.lang.Object),
which is held by "Timer-4"
"Timer-4":
waiting to lock monitor 0x08129160 (object 0xce89f508, a java.util.ArrayList),
which is held by "Thread-278"
Java stack information for the threads listed above:
===================================================
"Thread-278":
at org.jboss.remoting.ConnectionValidator.doStop(ConnectionValidator.java:526)
- waiting to lock <0xce8b25e0> (a java.lang.Object)
at org.jboss.remoting.ConnectionValidator.stop(ConnectionValidator.java:252)
at org.jboss.remoting.ConnectionValidator.removeConnectionListener(ConnectionValidator.java:344)
- locked <0xce89f508> (a java.util.ArrayList)
at org.jboss.remoting.Client.removeConnectionListener(Client.java:398)
at org.jboss.jms.client.remoting.JMSRemotingConnection.removeConnectionListener(JMSRemotingConnection.java:493)
- locked <0xce8b18c8> (a org.jboss.jms.client.remoting.JMSRemotingConnection)
at org.jboss.jms.client.container.ConnectionAspect.handleClose(ConnectionAspect.java:184)
at sun.reflect.GeneratedMethodAccessor134.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
at java.lang.reflect.Method.invoke(Method.java:597)
at org.jboss.aop.advice.PerInstanceAdvice.invoke(PerInstanceAdvice.java:121)
at org.jboss.jms.client.delegate.ClientConnectionDelegate$close_N4742752445160157748.invokeNext(ClientConnectionDelegate$close_N4742752445160157748.java)
at org.jboss.jms.client.container.FailoverValveInterceptor.invoke(FailoverValveInterceptor.java:92)
at org.jboss.aop.advice.PerInstanceInterceptor.invoke(PerInstanceInterceptor.java:105)
at org.jboss.jms.client.delegate.ClientConnectionDelegate$close_N4742752445160157748.invokeNext(ClientConnectionDelegate$close_N4742752445160157748.java)
at org.jboss.jms.client.container.ClosedInterceptor.invoke(ClosedInterceptor.java:170)
at org.jboss.aop.advice.PerInstanceInterceptor.invoke(PerInstanceInterceptor.java:105)
at org.jboss.jms.client.delegate.ClientConnectionDelegate$close_N4742752445160157748.invokeNext(ClientConnectionDelegate$close_N4742752445160157748.java)
at org.jboss.jms.client.delegate.ClientConnectionDelegate.close(ClientConnectionDelegate.java)
at org.jboss.jms.client.JBossConnection.close(JBossConnection.java:132)
at org.jboss.jms.server.bridge.Bridge.cleanup(Bridge.java:1098)
at org.jboss.jms.server.bridge.Bridge.access$1100(Bridge.java:66)
at org.jboss.jms.server.bridge.Bridge$FailureHandler.run(Bridge.java:1496)
at java.lang.Thread.run(Thread.java:619)
"Timer-4":
at org.jboss.remoting.ConnectionValidator.notifyListeners(ConnectionValidator.java:553)
- waiting to lock <0xce89f508> (a java.util.ArrayList)
at org.jboss.remoting.ConnectionValidator.run(ConnectionValidator.java:286)
- locked <0xce8b25e0> (a java.lang.Object)
at java.util.TimerThread.mainLoop(Timer.java:512)
at java.util.TimerThread.run(Timer.java:462)
Found 1 deadlock.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 3 months
[JBoss JIRA] Created: (JBPORTAL-1970) FastURLDecoder / enhance error message
by Antoine Herzog (JIRA)
FastURLDecoder / enhance error message
---------------------------------------
Key: JBPORTAL-1970
URL: http://jira.jboss.com/jira/browse/JBPORTAL-1970
Project: JBoss Portal
Issue Type: Task
Security Level: Public (Everyone can see)
Affects Versions: Common-1.0
Environment: JBP 2.6.4
Reporter: Antoine Herzog
Priority: Minor
Fix For: Common-1.0.1
small thing :
in FastURLDecoder class
at line : 329
line is : throw new MalformedInputException("Cannot decode char " + c);
Adding some "[" and "]." would be better :
throw new MalformedInputException("Cannot decode char [" + c + "].");
usual error case is a blank space in the url... and then the message MAY be confusing (nothing is shown).
it will help when someone have this kind of error on bad char in the url.
thanks,
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
18 years, 3 months