[JBoss JIRA] Created: (JBMESSAGING-1708) Simplify TransportConfiguration parameters
by Jeff Mesnil (JIRA)
Simplify TransportConfiguration parameters
------------------------------------------
Key: JBMESSAGING-1708
URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1708
Project: JBoss Messaging
Issue Type: Task
Components: Configuration and Management
Affects Versions: 2.0.0.beta4
Reporter: Jeff Mesnil
Assignee: Jeff Mesnil
Fix For: 2.0.0
the TransportConfiguration parameters are represented in XML by:
<param key="jbm.remoting.netty.tcpnodelay" value="false" type="Boolean"/>
The user shouldn't have to specify the type attribute as the Acceptor/Connector implementation knows what type they require for a given param key. We can get rid of it.
This would also simplify the Java representation from Map<String, Object> to a more constrained Map<String, String>.
The current code to retrieve a param value can already retrieve a value from a String (as is the case for the JCA resource adapter).
The key values could also be simplified as they are constrained by the acceptor/connector element.
E.g. for INVM configuration, rename "jbm.remoting.invm.serverid" to "id"
for Netty, rename "jbm.remoting.netty.host" to "host", etc.
This would be more intuitive for the user.
With these changes
<acceptors>
<acceptor name="netty-acceptor">
<factory-class>org.jboss.messaging.integration.transports.netty.NettyAcceptorFactory</factory-class>
<param key="jbm.remoting.netty.host" value="192.168.0.10" type="String"/>
<param key="jbm.remoting.netty.tcpnodelay" value="false" type="Boolean"/>
<param key="jbm.remoting.netty.tcpsendbuffersize" value="1048576" type="Integer"/>
<param key="jbm.remoting.netty.tcpreceivebuffersize" value="1048576" type="Integer"/>
</acceptor>
</acceptors>
would become
<acceptors>
<acceptor name="netty-acceptor">
<factory-class>org.jboss.messaging.integration.transports.netty.NettyAcceptorFactory</factory-class>
<param key="host" value="192.168.0.10"/>
<param key="tcpnodelay" value="false"/>
<param key="tcpsendbuffersize" value="1048576"/>
<param key="tcpreceivebuffersize" value="1048576"/>
</acceptor>
</acceptors>
without any loss of information.
Another possible refinement would be to get rid of the <factory-class> element and replace if by a type attribute on <acceptor>/<connector> which could be either "invm" or "netty" and we can internally have a map between the type values and the class implementation.
<factory-class> is completely generic but I doubt that adding another network framework is a trivial task. It makes the configuration of every user more complex that it could.
If we want genericity, we could still externalize the type<->class mapping in a properties file. This will be modified by power users but remain unchanged for 99% of our users.
With this change, the configuration would looks like:
<acceptors>
<acceptor name="netty-acceptor" type="netty">
<param key="host" value="192.168.0.10"/>
<param key="tcpnodelay" value="false"/>
<param key="tcpsendbuffersize" value="1048576"/>
<param key="tcpreceivebuffersize" value="1048576"/>
</acceptor>
</acceptors>
No more implementation detail obfuscates the configuration
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 11 months
[JBoss JIRA] Created: (JBAS-7129) Test Target tests-scout-jaxr failures
by Anil Saldhana (JIRA)
Test Target tests-scout-jaxr failures
-------------------------------------
Key: JBAS-7129
URL: https://jira.jboss.org/jira/browse/JBAS-7129
Project: JBoss Application Server
Issue Type: Sub-task
Security Level: Public (Everyone can see)
Components: JAXR service, Test Suite
Reporter: Anil Saldhana
Assignee: Anil Saldhana
Fix For: JBossAS-5.2.0.Beta1
==============
tests-scout-jaxr:
[mkdir] Created dir: /home/anil/Branch_5_x/testsuite/output/log
[junit] Running org.jboss.test.jaxr.scout.JaxrBaseTestCase
[junit] Running org.jboss.test.jaxr.scout.JaxrBaseTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 1.685 sec
[junit] Running org.jboss.test.jaxr.scout.basic.JaxrJNDIConnectionTestCase
[junit] Running org.jboss.test.jaxr.scout.basic.JaxrJNDIConnectionTestCase
[junit] Tests run: 1, Failures: 0, Errors: 0, Time elapsed: 0.354 sec
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrDeleteAssociationTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrDeleteAssociationTestCase
[junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 4.051 sec
[junit] Test org.jboss.test.jaxr.scout.publish.JaxrDeleteAssociationTestCase FAILED
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrDeleteOrganizationTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrDeleteOrganizationTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 2.898 sec
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrSaveOrganizationTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrSaveOrganizationTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 2.687 sec
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrSaveServiceBindingTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.JaxrSaveServiceBindingTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 3.705 sec
[junit] Running org.jboss.test.jaxr.scout.publish.infomodel.JaxrClassficationTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.infomodel.JaxrClassficationTestCase
[junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 2.193 sec
[junit] Test org.jboss.test.jaxr.scout.publish.infomodel.JaxrClassficationTestCase FAILED
[junit] Running org.jboss.test.jaxr.scout.publish.infomodel.JaxrConfimAssociationTestCase
[junit] Running org.jboss.test.jaxr.scout.publish.infomodel.JaxrConfimAssociationTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 4.265 sec
[junit] Running org.jboss.test.jaxr.scout.query.JaxrBusinessQueryTestCase
[junit] Running org.jboss.test.jaxr.scout.query.JaxrBusinessQueryTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 3.187 sec
[junit] Running org.jboss.test.jaxr.scout.query.infomodel.JaxrFindAssociationsTestCase
[junit] Running org.jboss.test.jaxr.scout.query.infomodel.JaxrFindAssociationsTestCase
[junit] Tests run: 2, Failures: 0, Errors: 0, Time elapsed: 4.505 sec
==================================
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 11 months
[JBoss JIRA] Created: (JGRP-1016) memory leak in GMS protocol
by Miro Selent (JIRA)
memory leak in GMS protocol
---------------------------
Key: JGRP-1016
URL: https://jira.jboss.org/jira/browse/JGRP-1016
Project: JGroups
Issue Type: Bug
Affects Versions: 2.7
Reporter: Miro Selent
Assignee: Bela Ban
Priority: Critical
Found in org.jgroups.protocols.pbcast.GMS in a scenario where members were killed and restarted very frequently and one member is persistently running. The memory consumption icreased very quickly until OutOfMemory.
Our analysis with JProfiler leads to the following assumption:
The number of org.jgroups.stack.IpAddress held by merge_ack_collector icreases every time a member was (re)started.
These instances were never removed because no MERGE events occured. This is completely clear since there was only one coordinator (the long running member).
If GMS receives no MERGE event it never cleans up the stored IpAddress instances in the merge_ack_collector.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
16 years, 11 months