[JBoss JIRA] Created: (JBRULES-2739) Upgrade to ANT 1.8.1
by Geoffrey De Smet (JIRA)
Upgrade to ANT 1.8.1
--------------------
Key: JBRULES-2739
URL: https://jira.jboss.org/browse/JBRULES-2739
Project: Drools
Issue Type: Task
Security Level: Public (Everyone can see)
Components: drools-ant
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Fix For: 5.2.0.M1
Mainly to make the build compatible with maven 3 in an easy way.
Currently the ant dependencies are somewhat of a mess:
- the maven-antrun-plugin has been defined twice
- we use the old groupId's of ant dependencies (which messes with conflict resolution for those that depend on us)
- osgi uses a different version of ant => extracted to a separate issue JBRULES-2738
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Created: (JBRULES-2737) Buidl with maven 3 fails on Guvnor due to maven-antrun-plugin
by Geoffrey De Smet (JIRA)
Buidl with maven 3 fails on Guvnor due to maven-antrun-plugin
-------------------------------------------------------------
Key: JBRULES-2737
URL: https://jira.jboss.org/browse/JBRULES-2737
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: drools-guvnor
Affects Versions: 5.1.1.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Fix For: 5.2.0.M1
Just tried a quick build of drools with maven 3, just to see if it works or not. The answer is no atm :)
[INFO] ------------------------------------------------------------------------
[INFO] Building Drools :: Guvnor 5.2.0.SNAPSHOT
[INFO] ------------------------------------------------------------------------
[INFO]
[INFO] --- maven-clean-plugin:2.4.1:clean (default-clean) @ drools-guvnor ---
[INFO] Deleting /home/gdesmet/projects/jboss/drools/drools-guvnor/target
[INFO]
[INFO] --- maven-antrun-plugin:1.4:run (clean repository) @ drools-guvnor ---
Downloading: https://repository.jboss.org/nexus/content/groups/public/ant/ant-apache-r...
Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/ant/an...
Downloading: http://repo1.maven.org/maven2/ant/ant-apache-regexp/1.6.5/ant-apache-rege...
Downloaded: http://repo1.maven.org/maven2/ant/ant-apache-regexp/1.6.5/ant-apache-rege... (154 B at 0.1 KB/sec)
Downloading: https://repository.jboss.org/nexus/content/groups/public/jakarta-regexp/j...
Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/jakart...
Downloading: http://repo1.maven.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-r...
Downloaded: http://repo1.maven.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-r... (160 B at 0.2 KB/sec)
Downloading: https://repository.jboss.org/nexus/content/groups/public/ant/ant-apache-r...
Downloading: https://repository.jboss.org/nexus/content/groups/public/jakarta-regexp/j...
Downloading: https://repository.jboss.org/nexus/content/groups/public/org/codehaus/ple...
Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/ant/an...
Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/jakart...
Downloading: https://repository.jboss.org/nexus/content/repositories/deprecated/org/co...
Downloading: http://repo1.maven.org/maven2/ant/ant-apache-regexp/1.6.5/ant-apache-rege...
Downloading: http://repo1.maven.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-r...
Downloading: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1....
Downloaded: http://repo1.maven.org/maven2/org/codehaus/plexus/plexus-interpolation/1.... (35 KB at 25.7 KB/sec)
Downloaded: http://repo1.maven.org/maven2/jakarta-regexp/jakarta-regexp/1.4/jakarta-r... (28 KB at 12.2 KB/sec)
Downloaded: http://repo1.maven.org/maven2/ant/ant-apache-regexp/1.6.5/ant-apache-rege... (4 KB at 1.3 KB/sec)
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Drools ............................................ SUCCESS [0.852s]
[INFO] Drools :: API ..................................... SUCCESS [12.894s]
[INFO] Drools :: Core .................................... SUCCESS [14.521s]
[INFO] Drools :: Compiler ................................ SUCCESS [18.671s]
[INFO] Drools :: Flow Core ............................... SUCCESS [6.583s]
[INFO] Drools :: Flow Compiler ........................... SUCCESS [4.423s]
[INFO] Drools :: IDE Common .............................. SUCCESS [5.537s]
[INFO] Drools :: Verifier ................................ SUCCESS [4.015s]
[INFO] Drools :: Templates ............................... SUCCESS [2.196s]
[INFO] Drools :: Decision Tables ......................... SUCCESS [2.855s]
[INFO] Drools :: Ant Task ................................ SUCCESS [1.860s]
[INFO] Drools :: Persistence :: JPA ...................... SUCCESS [7.075s]
[INFO] Drools Flow :: Persistence :: JPA ................. SUCCESS [1.885s]
[INFO] Drools :: Grid .................................... SUCCESS [0.011s]
[INFO] Drools :: Grid :: API ............................. SUCCESS [1.179s]
[INFO] Drools :: Grid :: Local Impl ...................... SUCCESS [1.526s]
[INFO] Drools :: Spring .................................. SUCCESS [2.937s]
[INFO] Drools :: Camel ................................... SUCCESS [12.931s]
[INFO] Drools :: Container ............................... SUCCESS [0.010s]
[INFO] Drools :: DroolsDoc ............................... SUCCESS [1.456s]
[INFO] Drools :: Fact Constraint ......................... SUCCESS [1.867s]
[INFO] Drools :: Grid :: Remote API ...................... SUCCESS [1.120s]
[INFO] Drools :: Grid :: Remote Node :: Mina ............. SUCCESS [1.492s]
[INFO] Drools :: Grid :: Remote Directory :: Mina ........ SUCCESS [0.912s]
[INFO] Drools :: Process :: WorkItems .................... SUCCESS [3.449s]
[INFO] Drools :: Process :: Task ......................... SUCCESS [3.494s]
[INFO] Drools :: Grid :: Task ............................ SUCCESS [2.217s]
[INFO] Drools :: Grid :: Distributed API ................. SUCCESS [1.460s]
[INFO] Drools :: Grid :: Services ........................ SUCCESS [2.022s]
[INFO] Drools :: Repository .............................. SUCCESS [3.407s]
[INFO] Drools :: Process :: BPMN2 ........................ SUCCESS [3.260s]
[INFO] Drools :: Guvnor .................................. FAILURE [12.195s]
[INFO] Drools :: JSR-94 API Module ....................... SKIPPED
[INFO] Drools :: Process :: BAM .......................... SKIPPED
[INFO] Drools :: GWT Console ............................. SKIPPED
[INFO] Drools :: GWT Console Forms ....................... SKIPPED
[INFO] Drools :: GWT Console Graph Viewer ................ SKIPPED
[INFO] Drools :: Process :: GWT console WAR .............. SKIPPED
[INFO] Drools :: Process :: GWT console server WAR ....... SKIPPED
[INFO] Drools :: Process ................................. SKIPPED
[INFO] Drools :: Server .................................. SKIPPED
[INFO] Drools :: Clips ................................... SKIPPED
[INFO] Drools :: Planner parent .......................... SKIPPED
[INFO] Drools :: Planner core ............................ SKIPPED
[INFO] Drools :: Planner examples ........................ SKIPPED
[INFO] Drools :: Pipeline ................................ SKIPPED
[INFO] Drools :: Simulator ............................... SKIPPED
[INFO] Drools :: OSGi :: Wrapper :: jxls-reader .......... SKIPPED
[INFO] Drools :: OSGi :: Wrapper :: MVEL2 ................ SKIPPED
[INFO] Drools :: OSGi bundles ............................ SKIPPED
[INFO] Spring OSGi Test .................................. SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 2:47.632s
[INFO] Finished at: Wed Oct 20 11:13:45 CEST 2010
[INFO] Final Memory: 32M/67M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.4:run (clean repository) on project drools-guvnor: Execution clean repository of goal org.apache.maven.plugins:maven-antrun-plugin:1.4:run failed: An API incompatibility was encountered while executing org.apache.maven.plugins:maven-antrun-plugin:1.4:run: java.lang.NoSuchMethodError: org.apache.tools.ant.launch.Locator.fromJarURI(Ljava/lang/String;)Ljava/lang/String;
[ERROR] -----------------------------------------------------
[ERROR] realm = plugin>org.apache.maven.plugins:maven-antrun-plugin:1.4
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] = file:/home/gdesmet/.m2/repository/org/apache/maven/plugins/maven-antrun-plugin/1.4/maven-antrun-plugin-1.4.jar
[ERROR] urls[1] = file:/home/gdesmet/.m2/repository/ant/ant-nodeps/1.6.5/ant-nodeps-1.6.5.jar
[ERROR] urls[2] = file:/home/gdesmet/.m2/repository/ant/ant-apache-regexp/1.6.5/ant-apache-regexp-1.6.5.jar
[ERROR] urls[3] = file:/home/gdesmet/.m2/repository/jakarta-regexp/jakarta-regexp/1.4/jakarta-regexp-1.4.jar
[ERROR] urls[4] = file:/home/gdesmet/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.1/plexus-interpolation-1.1.jar
[ERROR] urls[5] = file:/home/gdesmet/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
[ERROR] urls[6] = file:/home/gdesmet/.m2/repository/org/codehaus/plexus/plexus-utils/2.0.5/plexus-utils-2.0.5.jar
[ERROR] urls[7] = file:/home/gdesmet/.m2/repository/org/apache/ant/ant-nodeps/1.8.1/ant-nodeps-1.8.1.jar
[ERROR] urls[8] = file:/home/gdesmet/.m2/repository/org/apache/ant/ant/1.8.1/ant-1.8.1.jar
[ERROR] urls[9] = file:/home/gdesmet/.m2/repository/org/apache/ant/ant-launcher/1.8.1/ant-launcher-1.8.1.jar
[ERROR] Number of foreign imports: 4
[ERROR] import: Entry[import org.codehaus.plexus.util.xml.pull.XmlSerializer from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.util.xml.pull.XmlPullParserException from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.util.xml.pull.XmlPullParser from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.util.xml.Xpp3Dom from realm ClassRealm[plexus.core, parent: null]]
[ERROR]
[ERROR] realm = project>org.drools:drools:5.2.0.SNAPSHOT
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] Number of foreign imports: 1
[ERROR] import: Entry[import extension>org.apache.maven.wagon:wagon-webdav:1.0-beta-2 from realm ClassRealm[extension>org.apache.maven.wagon:wagon-webdav:1.0-beta-2, parent: ClassRealm[maven.api, parent: null]]]
[ERROR]
[ERROR] realm = maven.api
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] Number of foreign imports: 21
[ERROR] import: Entry[import org.sonatype.aether from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.personality from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.logging from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.lifecycle from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.context from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.container from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.configuration from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.component from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.classworlds from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.PlexusContainerException from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.PlexusContainer from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.PlexusConstants from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.MutablePlexusContainer from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.DuplicateChildContainerException from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.DefaultPlexusContainer from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.DefaultContainerConfiguration from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.DefaultComponentRegistry from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.ContainerConfiguration from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.plexus.ComponentRegistry from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.codehaus.classworlds from realm ClassRealm[plexus.core, parent: null]]
[ERROR] import: Entry[import org.apache.maven from realm ClassRealm[plexus.core, parent: null]]
[ERROR]
[ERROR] -----------------------------------------------------
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/PluginContainerException
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <goals> -rf :drools-guvnor
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Created: (JGRP-1247) Discovery: max_rank prevents physical address from being fetched
by Bela Ban (JIRA)
Discovery: max_rank prevents physical address from being fetched
----------------------------------------------------------------
Key: JGRP-1247
URL: https://jira.jboss.org/browse/JGRP-1247
Project: JGroups
Issue Type: Bug
Reporter: Bela Ban
Assignee: Bela Ban
Fix For: 2.11
If we have {A,B,C,D,E,F} and max_rank=3, then we'll only get responses from A, B and C. If a new member G doesn't have E's physical address, a GET_PHYSICAL_ADDRESS sent up from TP to Discovery doesn't fetch E's physical address !
SOLUTION: GET_PHYSICAL_ADDRESS should include the logical address of the member (E) whose physical address we want. A receiver returns a response if (1) its rank is less than max_rank or (2) the arg to GET_PHYSICAL_ADDRESS is not null and is the local address
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Created: (JBRULES-2706) Replace extjs grid in decision tables and rule templates with a new grid that suppors cell merging
by Geoffrey De Smet (JIRA)
Replace extjs grid in decision tables and rule templates with a new grid that suppors cell merging
--------------------------------------------------------------------------------------------------
Key: JBRULES-2706
URL: https://jira.jboss.org/browse/JBRULES-2706
Project: Drools
Issue Type: Feature Request
Security Level: Public (Everyone can see)
Components: drools-guvnor
Affects Versions: 5.1.1.FINAL
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Critical
Fix For: 5.2.0.M1
<conan> so what I'd like to do is get our dtable moved across to a new grid
<conan> but also for it to be updated so that it supports cell merging
<conan> the cell merging is essential for proper web based dtables
<conan> cbrock was working on errai grid that supports cell merging
<conan> manstis has been looking into it
<conan> he submitted some patches to errai but says it's a lot of work
<conan> to make it into a full component
<conan> he thinks that flex grid now has cell merging, but I doubt that.....
<conan> but he might be right in that it would be quicker to move the errai cell merging code into a fork of the gwt flex grid
<conan> that try and move everything into errai grid that makes a grid workable
<conan> a second issue is that that the rule template
<conan> really should use the same grid as dtable grid
<conan> including the same mechanisms for driving possible values et
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Created: (JBRULES-2736) Maven build with an empty repository doesn't work
by Geoffrey De Smet (JIRA)
Maven build with an empty repository doesn't work
-------------------------------------------------
Key: JBRULES-2736
URL: https://jira.jboss.org/browse/JBRULES-2736
Project: Drools
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: All
Reporter: Geoffrey De Smet
Assignee: Geoffrey De Smet
Priority: Minor
Fix For: 5.2.0.M1
[INFO] ------------------------------------------------------------------------
[INFO] Building Drools :: Persistence :: JPA
[INFO] task-segment: [clean, install]
[INFO] ------------------------------------------------------------------------
...
Missing:
----------
1) javax.transaction:jta:jar:1.1
Try downloading the file manually from:
http://java.sun.com/products/jta
Then, install it using the command:
mvn install:install-file -DgroupId=javax.transaction -DartifactId=jta -Dversion=1.1 -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=javax.transaction -DartifactId=jta -Dversion=1.1 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.drools:drools-persistence-jpa:jar:5.2.0.SNAPSHOT
2) javax.transaction:jta:jar:1.1
2) antlr:antlr:jar:2.7.6
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=antlr -DartifactId=antlr -Dversion=2.7.6 -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=antlr -DartifactId=antlr -Dversion=2.7.6 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.drools:drools-persistence-jpa:jar:5.2.0.SNAPSHOT
2) org.hibernate:hibernate-core:jar:3.3.0.SP1
3) antlr:antlr:jar:2.7.6
3) dom4j:dom4j:jar:1.6.1
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=dom4j -DartifactId=dom4j -Dversion=1.6.1 -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=dom4j -DartifactId=dom4j -Dversion=1.6.1 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.drools:drools-persistence-jpa:jar:5.2.0.SNAPSHOT
2) dom4j:dom4j:jar:1.6.1
4) org.slf4j:slf4j-api:jar:1.6.0
Try downloading the file manually from the project website.
Then, install it using the command:
mvn install:install-file -DgroupId=org.slf4j -DartifactId=slf4j-api -Dversion=1.6.0 -Dpackaging=jar -Dfile=/path/to/file
Alternatively, if you host your own repository you can deploy the file there:
mvn deploy:deploy-file -DgroupId=org.slf4j -DartifactId=slf4j-api -Dversion=1.6.0 -Dpackaging=jar -Dfile=/path/to/file -Durl=[url] -DrepositoryId=[id]
Path to dependency:
1) org.drools:drools-persistence-jpa:jar:5.2.0.SNAPSHOT
2) org.slf4j:slf4j-api:jar:1.6.0
----------
4 required artifacts are missing.
for artifact:
org.drools:drools-persistence-jpa:jar:5.2.0.SNAPSHOT
from the specified remote repositories:
com.springsource.repository.bundles.release (http://repository.springsource.com/maven/bundles/release),
codehaus-snapshot (http://snapshots.repository.codehaus.org),
com.springsource.repository.bundles.external (http://repository.springsource.com/maven/bundles/external),
rio-project.org (http://www.rio-project.org/maven2),
central (http://repo1.maven.org/maven2),
codehaus (http://repository.codehaus.org),
apache-incubating (http://people.apache.org/repo/m2-snapshot-repository/),
repo.openehealth.org (http://repo.openehealth.org/maven2/releases),
jboss-deprecated (https://repository.jboss.org/nexus/content/repositories/deprecated/),
jboss-public-repository-group (https://repository.jboss.org/nexus/content/groups/public/)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months
[JBoss JIRA] Commented: (EJBTHREE-558) Memory Leak in AuthenticationInterceptor
by jaikiran pai (JIRA)
[ https://jira.jboss.org/browse/EJBTHREE-558?page=com.atlassian.jira.plugin... ]
jaikiran pai commented on EJBTHREE-558:
---------------------------------------
There's no more development going on for EJB3 on community JBoss AS 4.x versions. Please upgrade to latest AS6.x community version, if possible.
> Memory Leak in AuthenticationInterceptor
> ----------------------------------------
>
> Key: EJBTHREE-558
> URL: https://jira.jboss.org/browse/EJBTHREE-558
> Project: EJB 3.0
> Issue Type: Bug
> Components: Security
> Reporter: Luigi Putanesca
> Assignee: Scott Stark
> Fix For: Branch_4_2
>
> Attachments: SecurityAssociation.java.patch
>
>
> In org.jboss.aspects.security.AuthenticationInterceptor.invoke(), the finally clause sets SecurityAssociation principal and credential to null. Although I think this was intended to clear any login, what it does is add a SubjectContext with principal = null to the SecurityAssociation.subjectContext stack. This entry is never removed and each time this block of code is invoked, it adds another item to the stack. The stack grows and grows. I think this is mainly a problem when restorePrincipal is true.
> What also compounds the problem is that if users were logged in by application code and never logged out, they remain on the stack in this thread indefinitely. Not only is this a problem with the stack growing, it is also a security vulnerability because it means there are still authenticated users on the stack that can be restored by another client or process using the same thread.
> My initial thought on how to fix this was to call the SecurityPrincipal.clear() method in place of setting the principal to null. However I'm not sure it is safe to call clear in that particular place possibly resulting in authentication errors if users are logged out prematurely. Additionally, the 'if' clause there means the code is not always executed so in some cases the clear will not occur. I think the clear needs to be called at some point but I don't know the code well enough to know where the appropriate place would be.
> Here is the snippet of code in question. See the finally clause:
> /**
> * Authenticates the caller using the principal and credentials in the
> * Infocation if thre is a security manager and an invcocation method.
> */
> public Object invoke(org.jboss.aop.joinpoint.Invocation invocation) throws Throwable
> {
> try
> {
> authenticate(invocation);
> }
> catch (GeneralSecurityException gse)
> {
> handleGeneralSecurityException(gse);
> }
> Object oldDomain = SecurityContext.currentDomain.get();
> try
> {
> SecurityContext.currentDomain.set(authenticationManager);
> return invocation.invokeNext();
> }
> finally
> {
> SecurityContext.currentDomain.set(oldDomain);
> // so that the principal doesn't keep being associated with thread if the thread is pooled
> SecurityAssociation.popSubjectContext();
> if (invocation.getMetaData("security", "principal") != null)
> {
> SecurityAssociation.setPrincipal(null);
> SecurityAssociation.setCredential(null);
> }
> }
> }
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
15 years, 9 months