[JBoss JIRA] (AS7-6334) Ensure there is expression testing, basic transformation testing and reject-expression transformation testing for all subsystems
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/AS7-6334?page=com.atlassian.jira.plugin.s... ]
Tomaz Cerar updated AS7-6334:
-----------------------------
Description:
Task to track the work we've all been doing on expressions/transformers.
See JaxrSubsystemTestCase for an example of what I'd like to see for each subsystem:
1) The standard subsystem test applied to a config that covers the full xsd with expressions added to each relevant attribute.
2) Basic transformation testing against 7.1.2 and 7.1.3
3) Reject-expression testing against 7.1.2 and 7.1.3
Assigned to me but this is really a team effort, with a big chunk already done. Please use comments on this JIRA to indicate if you're looking at something.
Please edit this description and put an OK after the subsystem name to indicate it's good to go.
clustering/jgroups (OK)
clustering/infinispan
cmp [OK]
configadmin [OK]
connector/datasource
connector/jca [OK]
connector/resource-adapter
deployment-scanner
ee
ejb3 [OK]
jacorb - Just a note: the 'security' attribute transformation is not tested
jaxr OK
jaxrs - nothing to do, empty subsystem
jdr - nothing to do, empty subsystem
jmx (OK)
jpa (OK)
jsf [PR https://github.com/jbossas/jboss-as/pull/3925]
jsr77 - nothing to do, empty subsystem
logging - PR sent https://github.com/jbossas/jboss-as/pull/3930
mail
messaging [OK]
modcluster [OK]
naming [OK]
osgi (OK)
pojo - nothing to do, empty subsystem
remoting - [OK]
sar - nothing to do, empty subsystem
security [PR sent - https://github.com/jbossas/jboss-as/pull/3941 - needs more work as mentioned in https://issues.jboss.org/browse/AS7-6407]
threads - WIP Kabir
transactions (just needs AS7-6336)
web
webservices
weld - nothing to do, empty subsystem
xts - [ok] nothing to do, susbystem model has not changed since 7.1.2 & 7.1.3
was:
Task to track the work we've all been doing on expressions/transformers.
See JaxrSubsystemTestCase for an example of what I'd like to see for each subsystem:
1) The standard subsystem test applied to a config that covers the full xsd with expressions added to each relevant attribute.
2) Basic transformation testing against 7.1.2 and 7.1.3
3) Reject-expression testing against 7.1.2 and 7.1.3
Assigned to me but this is really a team effort, with a big chunk already done. Please use comments on this JIRA to indicate if you're looking at something.
Please edit this description and put an OK after the subsystem name to indicate it's good to go.
clustering/jgroups (OK)
clustering/infinispan
cmp - PR sent https://github.com/jbossas/jboss-as/pull/3792
configadmin [OK]
connector/datasource
connector/jca [OK]
connector/resource-adapter
deployment-scanner
ee
ejb3 [OK]
jacorb - Just a note: the 'security' attribute transformation is not tested
jaxr OK
jaxrs - nothing to do, empty subsystem
jdr - nothing to do, empty subsystem
jmx (OK)
jpa (OK)
jsf [PR https://github.com/jbossas/jboss-as/pull/3925]
jsr77 - nothing to do, empty subsystem
logging - PR sent https://github.com/jbossas/jboss-as/pull/3930
mail
messaging [OK]
modcluster [PR: https://github.com/jbossas/jboss-as/pull/3947]
naming [PR https://github.com/jbossas/jboss-as/pull/3910]
osgi (OK)
pojo - nothing to do, empty subsystem
remoting - [OK]
sar - nothing to do, empty subsystem
security [PR sent - https://github.com/jbossas/jboss-as/pull/3941 - needs more work as mentioned in https://issues.jboss.org/browse/AS7-6407]
threads - WIP Kabir
transactions (just needs AS7-6336)
web
webservices
weld - nothing to do, empty subsystem
xts - nothing to do, susbystem model has not changed since 7.1.2 & 7.1.3
> Ensure there is expression testing, basic transformation testing and reject-expression transformation testing for all subsystems
> --------------------------------------------------------------------------------------------------------------------------------
>
> Key: AS7-6334
> URL: https://issues.jboss.org/browse/AS7-6334
> Project: Application Server 7
> Issue Type: Task
> Components: Domain Management
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Fix For: 7.2.0.Alpha1
>
>
> Task to track the work we've all been doing on expressions/transformers.
> See JaxrSubsystemTestCase for an example of what I'd like to see for each subsystem:
> 1) The standard subsystem test applied to a config that covers the full xsd with expressions added to each relevant attribute.
> 2) Basic transformation testing against 7.1.2 and 7.1.3
> 3) Reject-expression testing against 7.1.2 and 7.1.3
> Assigned to me but this is really a team effort, with a big chunk already done. Please use comments on this JIRA to indicate if you're looking at something.
> Please edit this description and put an OK after the subsystem name to indicate it's good to go.
> clustering/jgroups (OK)
> clustering/infinispan
> cmp [OK]
> configadmin [OK]
> connector/datasource
> connector/jca [OK]
> connector/resource-adapter
> deployment-scanner
> ee
> ejb3 [OK]
> jacorb - Just a note: the 'security' attribute transformation is not tested
> jaxr OK
> jaxrs - nothing to do, empty subsystem
> jdr - nothing to do, empty subsystem
> jmx (OK)
> jpa (OK)
> jsf [PR https://github.com/jbossas/jboss-as/pull/3925]
> jsr77 - nothing to do, empty subsystem
> logging - PR sent https://github.com/jbossas/jboss-as/pull/3930
> mail
> messaging [OK]
> modcluster [OK]
> naming [OK]
> osgi (OK)
> pojo - nothing to do, empty subsystem
> remoting - [OK]
> sar - nothing to do, empty subsystem
> security [PR sent - https://github.com/jbossas/jboss-as/pull/3941 - needs more work as mentioned in https://issues.jboss.org/browse/AS7-6407]
> threads - WIP Kabir
> transactions (just needs AS7-6336)
> web
> webservices
> weld - nothing to do, empty subsystem
> xts - [ok] nothing to do, susbystem model has not changed since 7.1.2 & 7.1.3
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (AS7-6408) Can't configure JGroups subsystem with CLI script in 7.2.0.Alpha1-SNAPSHOT
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/AS7-6408?page=com.atlassian.jira.plugin.s... ]
Tomaz Cerar edited comment on AS7-6408 at 1/29/13 6:53 PM:
-----------------------------------------------------------
Yeah fix also addresses that.
news for 7.2 is that you now have both :add-protocol and :add-transport operations that replace lists parameters that ware part of add() operation
but in any case I would modify your script to something like that:
{noformat}
# Configuring jGroups
batch
/extension=org.jboss.as.clustering.jgroups:add
run-batch
batch
/subsystem=jgroups:add(default-stack=udp)
# protocols is a list of string now. I have to configure socket-bindings later
/subsystem=jgroups/stack=udp:add()
/subsystem=jgroups/stack=udp:add-transport("type"=>"UDP","socket-binding"=>"jgroups-udp")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"FD_SOCK","socket-binding"=>"jgroups-udp-fd")
... (other protocols)...
/subsystem=jgroups/stack=tcp:add()
/subsystem=jgroups/stack=udp:add-transport("type"=>"TCP","socket-binding"=>"jgroups-tcp")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"MPING","socket-binding"=>"jgroups-mping")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"pbcast.NAKACK2")
... (other protocols)...
run-batch
{noformat}
was (Author: ctomc):
Yeah fix also addresses that.
news is that you now have both :add-protocol and :add-transport operations that replace that lists that had in :add() operation
but in any case I would modify your script to something like that:
{noformat}
# Configuring jGroups
batch
/extension=org.jboss.as.clustering.jgroups:add
run-batch
batch
/subsystem=jgroups:add(default-stack=udp)
# protocols is a list of string now. I have to configure socket-bindings later
/subsystem=jgroups/stack=udp:add()
/subsystem=jgroups/stack=udp:add-transport("type"=>"UDP","socket-binding"=>"jgroups-udp")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"FD_SOCK","socket-binding"=>"jgroups-udp-fd")
... (other protocols)...
/subsystem=jgroups/stack=tcp:add()
/subsystem=jgroups/stack=udp:add-transport("type"=>"TCP","socket-binding"=>"jgroups-tcp")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"MPING","socket-binding"=>"jgroups-mping")
/subsystem=jgroups/stack=udp:add-protocol("type"=>"pbcast.NAKACK2")
... (other protocols)...
run-batch
{noformat}
> Can't configure JGroups subsystem with CLI script in 7.2.0.Alpha1-SNAPSHOT
> ---------------------------------------------------------------------------
>
> Key: AS7-6408
> URL: https://issues.jboss.org/browse/AS7-6408
> Project: Application Server 7
> Issue Type: Bug
> Components: Clustering
> Affects Versions: 7.2.0.Alpha1
> Environment: Git checkout of JBossAS 7.2.0.ALPHA1 from today (28/Jan/2013)
> Reporter: Bernd Koecke
> Assignee: Tomaz Cerar
> Fix For: 7.2.0.Alpha1
>
> Attachments: standalone-ha-jgroups.cli, standalone-jgroups-fragment.xml
>
>
> When I try to configure extension and subsystem JGroups with a CLI script, the attribute "protocols" of the stack=tcp- or stack=udp-node contains the list of configured protocols twice. The result is that the list of protocols is doubled in the standalone.xml. But having a protocol twice in one stack results in an error at next server startup. I will attach the CLI script and the resulting XML fragment.
> When I shutdown the server, remove the doubled second part of each protocol list, the server comes up and all is working fine. But I can't configure it only with a CLI script.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (JGRP-1575) View members should be always unmodifiable
by Gray Watson (JIRA)
[ https://issues.jboss.org/browse/JGRP-1575?page=com.atlassian.jira.plugin.... ]
Gray Watson updated JGRP-1575:
------------------------------
Summary: View members should be always unmodifiable (was: View members should be unmodifiable alwats)
> View members should be always unmodifiable
> ------------------------------------------
>
> Key: JGRP-1575
> URL: https://issues.jboss.org/browse/JGRP-1575
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 3.1, 3.2
> Reporter: Gray Watson
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.3
>
>
> Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList. In my view in the constructor members should be a final Collections.unmodifiableList. This would save GC throughput on all of the wrapper objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (JGRP-1575) View members should be always unmodifiable
by Gray Watson (JIRA)
[ https://issues.jboss.org/browse/JGRP-1575?page=com.atlassian.jira.plugin.... ]
Gray Watson updated JGRP-1575:
------------------------------
Description:
Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList.
In my opinion, in the View constructor, members should be a final Collections.unmodifiableList from the start. This would save GC throughput on all of the wrapper objects.
was:Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList. In my view in the constructor members should be a final Collections.unmodifiableList. This would save GC throughput on all of the wrapper objects.
> View members should be always unmodifiable
> ------------------------------------------
>
> Key: JGRP-1575
> URL: https://issues.jboss.org/browse/JGRP-1575
> Project: JGroups
> Issue Type: Enhancement
> Affects Versions: 3.1, 3.2
> Reporter: Gray Watson
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.3
>
>
> Right now the members list inside of the View is mutable. Everytime someone calls getMembers() it creates another Collections.unmodifiableList.
> In my opinion, in the View constructor, members should be a final Collections.unmodifiableList from the start. This would save GC throughput on all of the wrapper objects.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (JBLOGGING-85) slf4j-jboss-logmanager does not support parametization of a logging statement in the presence of a Throwable
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/JBLOGGING-85?page=com.atlassian.jira.plug... ]
James Perkins resolved JBLOGGING-85.
------------------------------------
Resolution: Done
Pull request merged.
> slf4j-jboss-logmanager does not support parametization of a logging statement in the presence of a Throwable
> ------------------------------------------------------------------------------------------------------------
>
> Key: JBLOGGING-85
> URL: https://issues.jboss.org/browse/JBLOGGING-85
> Project: JBoss Logging
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Components: slf4j-jboss-logmanager
> Reporter: Hercules Zeus
> Assignee: James Perkins
>
> http://www.slf4j.org/faq.html#paramException describes that from slf4j 1.6 onwards doing the following will print a stacktrace:
> logger.error("Failed to format {}", s, e);
> However, due to the implementation of org.slf4j.impl.MessageFormatter in slf4j-jboss-logmanager, when logger.error(String, Object, Object) is called, even if the third parameter is a Throwable, it is not recognised as such.
> Investigating further, it seems that org.slf4j.impl.MessageFormatter is probably just an old copy of org.slf4j.helpers.MessageFormatter in slfj-api 1.6.1, where most formatting methods used to return a String now returns a FormattingTuple.
> This issue can be fixed by making all calls in Slf4Logger to org.slf4j.impl.MessageFormatter to call org.slf4j.helpers.MessageFormatter instead and appropriately call ExtLogRecord.setThrown(formattingTuple.getThrowable()).
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months