[JBoss JIRA] (AS7-3772) Regularize expression handling in the interface resources
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/AS7-3772?page=com.atlassian.jira.plugin.s... ]
Brian Stansberry commented on AS7-3772:
---------------------------------------
Stuff to look into:
$ cd controller/src/main/java/org/jboss/as/controller/interfaces/
$ git grep "resolve()"
InetAddressMatchInterfaceCriteria.java: resolved = InetAddress.getByName(address.resolve().asString());
LoopbackAddressInterfaceCriteria.java: resolved = InetAddress.getByName(address.resolve().asString());
ParsedInterfaceCriteria.java: final String rawAddress = context == null ? model.resolve().asString() : context.resolveExpressions(model).asString();
> Regularize expression handling in the interface resources
> ---------------------------------------------------------
>
> Key: AS7-3772
> URL: https://issues.jboss.org/browse/AS7-3772
> Project: Application Server 7
> Issue Type: Sub-task
> Components: Domain Management
> Affects Versions: 7.1.0.Final
> Reporter: Brian Stansberry
> Assignee: Brian Stansberry
> Fix For: 7.2.0.Alpha1
>
>
> The interface resource code predates the evolution of the AttributeDefinition classes. Convert it over to that and make sure the xml parsers, operation step handlers and ParsedInterfaceCriteria follow the standard practices. Basically,
> 1) Use AD.parseAndSet() in the parsers. This will ensure parsing any criteria type that supports expressions will result in values of type EXPRESSION if appropriate.
> 2) Use AD.validateAndSet() in the MODEL stage of the OSH. This will ensure reading in input values from the CLI/console etc for any criteria type that supports expressions will result in values of type EXPRESSION if appropriate.
> 3) Pass the OperationContext into ParsedInterfaceCriteria and use AD.resolveModelAttribute() for resolution.
> 4) Get the calls to ModelNode.resolve() out of the InterfaceCriteria implementations. By the time those classes see a value it should already be resolved.
> This may not be entirely possible, as interface criteria as a bit unusual types of attributes. But the general intent here should be followed.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (AS7-6352) CLI cursor marker position is not consistent
by Kabir Khan (JIRA)
[ https://issues.jboss.org/browse/AS7-6352?page=com.atlassian.jira.plugin.s... ]
Kabir Khan commented on AS7-6352:
---------------------------------
Just the standard built-on one, if I understood the question correctly
> CLI cursor marker position is not consistent
> --------------------------------------------
>
> Key: AS7-6352
> URL: https://issues.jboss.org/browse/AS7-6352
> Project: Application Server 7
> Issue Type: Feature Request
> Components: CLI
> Reporter: Kabir Khan
> Assignee: Alexey Loubyansky
> Fix For: 7.2.0.Alpha1
>
>
> To reproduce, execute
> /subsystem=jmx:read-resource
> Now press the up arrow, to get that command again so you see
> /subsystem=jmx:read-resource
> The cursor is at the end. Now I want to delete 'jmx' and put in 'ee', so I move the cursor to the ':'. I press backspace to delete the 'x' but the cursor marker jumps back to the end of the line, however when I press backspace again the 'm' gets deleted. This appears to be at the end of the line when I delete the 'j' and enter the 'ee'. So what happens under the hood is fine, but the marker appears to be in the wrong place after it has been moved and editing starts.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months
[JBoss JIRA] (JBREM-1318) Zero is a valid value so SoLinger
by Doug Grove (JIRA)
Doug Grove created JBREM-1318:
---------------------------------
Summary: Zero is a valid value so SoLinger
Key: JBREM-1318
URL: https://issues.jboss.org/browse/JBREM-1318
Project: JBoss Remoting
Issue Type: Bug
Security Level: Public (Everyone can see)
Components: general
Affects Versions: 2.5.4.SP3
Reporter: Doug Grove
Priority: Minor
MicroSocketClientInvoker checks to see that SoLinger is greater than zero:
if (soLingerSet &&
soLingerDuration > 0) s.setSoLinger(soLinger, soLingerDuration);
Zero is a valid value for SoLinger.
The code should be changed to greater than or equal to zero.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
13 years, 5 months