February 2013 - jboss-jira - Jboss List Archives

[JBoss JIRA] (EJBTHREE-2295) Fix wrong initialization of cluster members register

by Bartosz Baranowski (JIRA)

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBWEB-266) Cookie Processing of JSON Cookie destroys Cookie Header

by Manuel Coenen (JIRA)

[ https://issues.jboss.org/browse/JBWEB-266?page=com.atlassian.jira.plugin.... ] Manuel Coenen updated JBWEB-266: -------------------------------- Environment: Windows 7 x64 and RHEL/CentOS 5.x, Java 1.7.0_11, JBoss AS 7.0.2 Final (was: Windows 7 x64 and RHEL/CentOS with JBoss AS 7.0.2 Final) > Cookie Processing of JSON Cookie destroys Cookie Header > ------------------------------------------------------- > > Key: JBWEB-266 > URL: https://issues.jboss.org/browse/JBWEB-266 > Project: JBoss Web > Issue Type: Bug > Security Level: Public(Everyone can see) > Components: Tomcat > Affects Versions: JBossWeb-7.0.1.GA > Environment: Windows 7 x64 and RHEL/CentOS 5.x, Java 1.7.0_11, JBoss AS 7.0.2 Final > Reporter: Manuel Coenen > Assignee: Remy Maucherat > > When sending a cookie with JSON content to JBoss the automatic cookie processing (triggered by looking for a session cookie) modifies the {{byte[]}} buffer which is also used for the HTTP headers. > This is due to multiple objects depending on the same {{byte[]}} buffer instance. The following hierarchy should demonstrate this dependency: > {noformat} > Http11Processor.request (Request) > └> cookies (Cookies) > | └> scookies[] (ServerCookie) > | └> scookies[x] (where x is the index referencing the JSON cookie) > | └> value (MessageByte) > | └>byteC (ByteChunk) > | \ > | |-> buff (byte[]) > | / > | ┌> byteC (ByteChunk) > | ┌> valueB (MessageByte) > | ┌> headers[y] (where y is the index referencing the JSON cookie header) > | ┌> headers[] (MimeHeaderField) > └> headers (MimeHeader) > {noformat} > The method {{Cookies.unescapeDoubleQuotes(ByteChunk)}} modifies this buffer by overwriting its contents when removing the escaped double-quotes. This in return destroys the reference for the header as it will still maintain the {{start}} and {{end}} reference inside this buffer. If the value for this header is read later it will be the unescaped content trailed by the surplus escaped region (see reproduction instructions for a more detailed example). > In my opinion the method {{Cookies.unescapeDoubleQuotes(ByteChunk)}} should copy the {{byte[]}} first to avoid side effects to other parts referencing this {{byte[]}} as it could be (and is in our case) that the headers (including cookie) need to be forwarded unmodified to another server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (EJBTHREE-2295) Fix wrong initialization of cluster members register

by Bartosz Baranowski (JIRA)

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBWEB-266) Cookie Processing of JSON Cookie destroys Cookie Header

by Manuel Coenen (JIRA)

Manuel Coenen created JBWEB-266: ----------------------------------- Summary: Cookie Processing of JSON Cookie destroys Cookie Header Key: JBWEB-266 URL: https://issues.jboss.org/browse/JBWEB-266 Project: JBoss Web Issue Type: Bug Security Level: Public (Everyone can see) Components: Tomcat Affects Versions: JBossWeb-7.0.1.GA Environment: Windows 7 x64 and RHEL/CentOS with JBoss AS 7.0.2 Final Reporter: Manuel Coenen Assignee: Remy Maucherat When sending a cookie with JSON content to JBoss the automatic cookie processing (triggered by looking for a session cookie) modifies the {{byte[]}} buffer which is also used for the HTTP headers. This is due to multiple objects depending on the same {{byte[]}} buffer instance. The following hierarchy should demonstrate this dependency: {noformat} Http11Processor.request (Request) └> cookies (Cookies) | └> scookies[] (ServerCookie) | └> scookies[x] (where x is the index referencing the JSON cookie) | └> value (MessageByte) | └>byteC (ByteChunk) | \ | |-> buff (byte[]) | / | ┌> byteC (ByteChunk) | ┌> valueB (MessageByte) | ┌> headers[y] (where y is the index referencing the JSON cookie header) | ┌> headers[] (MimeHeaderField) └> headers (MimeHeader) {noformat} The method {{Cookies.unescapeDoubleQuotes(ByteChunk)}} modifies this buffer by overwriting its contents when removing the escaped double-quotes. This in return destroys the reference for the header as it will still maintain the {{start}} and {{end}} reference inside this buffer. If the value for this header is read later it will be the unescaped content trailed by the surplus escaped region (see reproduction instructions for a more detailed example). In my opinion the method {{Cookies.unescapeDoubleQuotes(ByteChunk)}} should copy the {{byte[]}} first to avoid side effects to other parts referencing this {{byte[]}} as it could be (and is in our case) that the headers (including cookie) need to be forwarded unmodified to another server. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (EJBTHREE-2295) Fix wrong initialization of cluster members register

by Bartosz Baranowski (JIRA)

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBWEB-263) Remove WeakHash map from BeanELResolver and depend on proper callback to remove bean properties

by Remy Maucherat (JIRA)

[ https://issues.jboss.org/browse/JBWEB-263?page=com.atlassian.jira.plugin.... ] Remy Maucherat commented on JBWEB-263: -------------------------------------- Yes, if you port the class from the newer versions, with Class as the key, this should work. > Remove WeakHash map from BeanELResolver and depend on proper callback to remove bean properties > ----------------------------------------------------------------------------------------------- > > Key: JBWEB-263 > URL: https://issues.jboss.org/browse/JBWEB-263 > Project: JBoss Web > Issue Type: Bug > Security Level: Public(Everyone can see) > Reporter: Bartosz Baranowski > Assignee: Remy Maucherat > Attachments: JBWEB-263.patch > > > As in subject. Even though its a weakhashmap( and current source has the ConcurrentCache. > Affected version: 2.1.12.GA - http://svn.jboss.org/repos/jbossweb/branches/2.1.x/ > Fix version: next( EAP depends on 2.1.13.GA-patch01 or JBOSSWEB_2_1_12_GA_patch03 ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (AS7-6550) Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog

by Heiko Braun (JIRA)

[ https://issues.jboss.org/browse/AS7-6550?page=com.atlassian.jira.plugin.s... ] Heiko Braun edited comment on AS7-6550 at 2/20/13 4:16 AM: ----------------------------------------------------------- The following is required to resolve the issue: - send a pull for the main codebase - merge it into 1.5.x I can do the later, but I still need your pull request. was (Author: heiko.braun): The following is required to resolve the issue: - send a pull for the main codebase - merge it into 1.5.x I can do the later, but I still your pull request. > Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog > ----------------------------------------------------------------------------------- > > Key: AS7-6550 > URL: https://issues.jboss.org/browse/AS7-6550 > Project: Application Server 7 > Issue Type: Feature Request > Components: Console > Reporter: Heiko Braun > Assignee: Harald Pehl > Labels: console_1.5.2 > Fix For: 7.3.0.Alpha1 > > > See https://bugzilla.redhat.com/show_bug.cgi?id=912690 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (AS7-6550) Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog

by Heiko Braun (JIRA)

[ https://issues.jboss.org/browse/AS7-6550?page=com.atlassian.jira.plugin.s... ] Heiko Braun reopened AS7-6550: ------------------------------ The following is required to resolve the issue: - send a pull for the main codebase - merge it into 1.5.x I can do the later, but I still your pull request. > Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog > ----------------------------------------------------------------------------------- > > Key: AS7-6550 > URL: https://issues.jboss.org/browse/AS7-6550 > Project: Application Server 7 > Issue Type: Feature Request > Components: Console > Reporter: Heiko Braun > Assignee: Harald Pehl > Labels: console_1.5.2 > Fix For: 7.3.0.Alpha1 > > > See https://bugzilla.redhat.com/show_bug.cgi?id=912690 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (JBWEB-263) Remove WeakHash map from BeanELResolver and depend on proper callback to remove bean properties

by Bartosz Baranowski (JIRA)

[ https://issues.jboss.org/browse/JBWEB-263?page=com.atlassian.jira.plugin.... ] Bartosz Baranowski commented on JBWEB-263: ------------------------------------------ Here is a build to test current 2.1.x with Class as key in EAP: http://boo.lab.bos.redhat.com:8380/job/EAP-5.1.x-patch2/60/ > Remove WeakHash map from BeanELResolver and depend on proper callback to remove bean properties > ----------------------------------------------------------------------------------------------- > > Key: JBWEB-263 > URL: https://issues.jboss.org/browse/JBWEB-263 > Project: JBoss Web > Issue Type: Bug > Security Level: Public(Everyone can see) > Reporter: Bartosz Baranowski > Assignee: Remy Maucherat > Attachments: JBWEB-263.patch > > > As in subject. Even though its a weakhashmap( and current source has the ConcurrentCache. > Affected version: 2.1.12.GA - http://svn.jboss.org/repos/jbossweb/branches/2.1.x/ > Fix version: next( EAP depends on 2.1.13.GA-patch01 or JBOSSWEB_2_1_12_GA_patch03 ) -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

[JBoss JIRA] (AS7-6550) Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog

by Harald Pehl (JIRA)

[ https://issues.jboss.org/browse/AS7-6550?page=com.atlassian.jira.plugin.s... ] Harald Pehl resolved AS7-6550. ------------------------------ Resolution: Done Removed unmanaged deployment tab from replace dialog. > Confusing behavior of form under the "Unmanaged" tab in deployment's Replace dialog > ----------------------------------------------------------------------------------- > > Key: AS7-6550 > URL: https://issues.jboss.org/browse/AS7-6550 > Project: Application Server 7 > Issue Type: Feature Request > Components: Console > Reporter: Heiko Braun > Assignee: Harald Pehl > Labels: console_1.5.2 > Fix For: 7.3.0.Alpha1 > > > See https://bugzilla.redhat.com/show_bug.cgi?id=912690 -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira

13 years, 5 months

1
0
0 / 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira February 2013