[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina updated ELY-47:
--------------------------
Description:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of [pull request 13|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
was:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of [pull request 13|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of [pull request 13|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina updated ELY-47:
--------------------------
Description:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of [pull request 13|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
was:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of [pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of [pull request 13|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina updated ELY-47:
--------------------------
Description:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of [pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
was:
StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
http://tools.ietf.org/html/rfc3454#appendix-B.2
Relevant profile description:
http://tools.ietf.org/html/rfc3454#section-3.2
Full test is part of pull request https://github.com/wildfly-security/wildfly-sasl/pull/13, but for basic testing and for reference can be used this simple test:
{code:java}
@Test
public void testNormalizationWithNFKC(){
ByteStringBuilder b = new ByteStringBuilder();
String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
assertEquals(after, new String(b.toArray()));
}
{code}
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of [pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13], but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina edited comment on ELY-47 at 8/26/14 4:34 AM:
--------------------------------------------------------
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full test of case folding ignored in [pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13] for needs of implementing it.
was (Author: honza889):
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full test of case folding ignored in [[pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13]] for needs of implementing it.
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of pull request https://github.com/wildfly-security/wildfly-sasl/pull/13, but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina edited comment on ELY-47 at 8/26/14 4:34 AM:
--------------------------------------------------------
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full test of case folding ignored in [[pull request|https://github.com/wildfly-security/wildfly-sasl/pull/13]] for needs of implementing it.
was (Author: honza889):
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full test ignored in pull request for needs of implementing it.
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of pull request https://github.com/wildfly-security/wildfly-sasl/pull/13, but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (DROOLS-578) add double null check to asm stub builders
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-578?page=com.atlassian.jira.plugin... ]
Mario Fusco resolved DROOLS-578.
--------------------------------
Fix Version/s: 6.2.0.Beta2
Resolution: Done
Patch merged with https://github.com/droolsjbpm/drools/commit/e397ce966
> add double null check to asm stub builders
> ------------------------------------------
>
> Key: DROOLS-578
> URL: https://issues.jboss.org/browse/DROOLS-578
> Project: Drools
> Issue Type: Patch
> Security Level: Public(Everyone can see)
> Affects Versions: 6.1.0.Beta1, 6.1.0.Beta2, 6.1.0.Beta3, 6.1.0.Beta4, 6.1.0.CR1, 6.1.0.CR2, 6.1.0.Final
> Reporter: david hendi
> Assignee: Mario Fusco
> Fix For: 6.2.0.Beta2
>
> Attachments: asm-builder-double-null-check.patch
>
>
> currently the code generated does a null check within the synchronized code. this forces all threads to block while the check is made even after the check returns false. by adding a double null check, the synchronized code is bypassed once the check is satisfied.
> public void evaluate(KnowledgeHelper paramKnowledgeHelper, WorkingMemory paramWorkingMemory)
> throws Exception
> {
> if (this.consequence == null) {
> synchronized (this) {
> if (this.consequence == null) {
> ConsequenceGenerator.generate(this, paramKnowledgeHelper, paramWorkingMemory);
> }
> }
> }
> this.consequence.evaluate(paramKnowledgeHelper, paramWorkingMemory);
> }
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina edited comment on ELY-47 at 8/26/14 4:13 AM:
--------------------------------------------------------
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full test ignored in pull request for needs of implementing it.
was (Author: honza889):
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full ignored test in pull request for needs of implementing it.
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of pull request https://github.com/wildfly-security/wildfly-sasl/pull/13, but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (ELY-47) NFKC normalization in StringPrep is not in accordance with RFC
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/ELY-47?page=com.atlassian.jira.plugin.sys... ]
Jan Kalina edited comment on ELY-47 at 8/26/14 3:58 AM:
--------------------------------------------------------
Here was misunderstand function of *NORMALIZE_KC* profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full ignored test in pull request for needs of implementing it.
was (Author: honza889):
Here was misunderstand function of **NORMALIZE_KC** profile - this profile do only NFKC normalization, not case folding, which test expected.
Case folding is not implemented in StringPrep yet, so I keep full ignored test in pull request for needs of implementing it.
> NFKC normalization in StringPrep is not in accordance with RFC
> --------------------------------------------------------------
>
> Key: ELY-47
> URL: https://issues.jboss.org/browse/ELY-47
> Project: WildFly Elytron
> Issue Type: Bug
> Security Level: Public(Everyone can see)
> Reporter: Jan Kalina
> Assignee: Darran Lofthouse
>
> StringPrep from utils use java.text.Normalizer to NFKC normalization. But this normalization is not in accordance with RFC 3454 - see mapping table:
> http://tools.ietf.org/html/rfc3454#appendix-B.2
> Relevant profile description:
> http://tools.ietf.org/html/rfc3454#section-3.2
> Full test is part of pull request https://github.com/wildfly-security/wildfly-sasl/pull/13, but for basic testing and for reference can be used this simple test:
> {code:java}
> @Test
> public void testNormalizationWithNFKC(){
> ByteStringBuilder b = new ByteStringBuilder();
> String before = "\u0041\u0042\u0043\u0044\u0045\u0046\u0047";
> String after = "\u0061\u0062\u0063\u0064\u0065\u0066\u0067";
> StringPrep.encode(before, b, StringPrep.NORMALIZE_KC);
> assertEquals(after, new String(b.toArray()));
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months
[JBoss JIRA] (DROOLS-578) add double null check to asm stub builders
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-578?page=com.atlassian.jira.plugin... ]
Mario Fusco reassigned DROOLS-578:
----------------------------------
Assignee: Mario Fusco (was: Mark Proctor)
> add double null check to asm stub builders
> ------------------------------------------
>
> Key: DROOLS-578
> URL: https://issues.jboss.org/browse/DROOLS-578
> Project: Drools
> Issue Type: Patch
> Security Level: Public(Everyone can see)
> Affects Versions: 6.1.0.Beta1, 6.1.0.Beta2, 6.1.0.Beta3, 6.1.0.Beta4, 6.1.0.CR1, 6.1.0.CR2, 6.1.0.Final
> Reporter: david hendi
> Assignee: Mario Fusco
> Attachments: asm-builder-double-null-check.patch
>
>
> currently the code generated does a null check within the synchronized code. this forces all threads to block while the check is made even after the check returns false. by adding a double null check, the synchronized code is bypassed once the check is satisfied.
> public void evaluate(KnowledgeHelper paramKnowledgeHelper, WorkingMemory paramWorkingMemory)
> throws Exception
> {
> if (this.consequence == null) {
> synchronized (this) {
> if (this.consequence == null) {
> ConsequenceGenerator.generate(this, paramKnowledgeHelper, paramWorkingMemory);
> }
> }
> }
> this.consequence.evaluate(paramKnowledgeHelper, paramWorkingMemory);
> }
--
This message was sent by Atlassian JIRA
(v6.3.1#6329)
11 years, 10 months