[JBoss JIRA] (WFLY-2102) Improve deployment annotation parsing error message
by Brad Maxwell (JIRA)
[ https://issues.jboss.org/browse/WFLY-2102?page=com.atlassian.jira.plugin.... ]
Brad Maxwell commented on WFLY-2102:
------------------------------------
[~brian.stansberry] yeah, I'll update it, as usually goes we are pounded with tracking down other issues, so things keep falling to the backburner :-(
> Improve deployment annotation parsing error message
> -----------------------------------------------------
>
> Key: WFLY-2102
> URL: https://issues.jboss.org/browse/WFLY-2102
> Project: WildFly
> Issue Type: Enhancement
> Components: EE
> Reporter: Brad Maxwell
> Assignee: Brad Maxwell
> Fix For: 11.0.0.Alpha1
>
>
> Improve deployment annotation parsing error message
> Code such as this below, will error with IllegalArgumentException: Empty name segment is not allowed for env. The env is not enough information to identify what the issue is.
> @Singleton
> @Startup
> public class TestEJB {
> @Resource(name="/queue/test")
> private Queue queue;
> }
> Caused by: java.lang.IllegalArgumentException: Empty name segment is not allowed for env
> at org.jboss.msc.service.ServiceName.of(ServiceName.java:85) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.msc.service.ServiceName.append(ServiceName.java:112) [jboss-msc-1.0.4.GA-redhat-1.jar:1.0.4.GA-redhat-1]
> at org.jboss.as.naming.deployment.ContextNames.buildServiceName(ContextNames.java:183)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:195)
> at org.jboss.as.naming.deployment.ContextNames$BindInfo.<init>(ContextNames.java:186)
> at org.jboss.as.naming.deployment.ContextNames.bindInfoFor(ContextNames.java:141)
> at org.jboss.as.ee.component.OptionalLookupInjectionSource.getResourceValue(OptionalLookupInjectionSource.java:84)
> at org.jboss.as.ee.component.ComponentDescription$InjectedConfigurator.configureDependency(ComponentDescription.java:1019)
> at org.jboss.as.ee.component.ComponentDescription$InjectedConfigurator.configureDependency(ComponentDescription.java:998)
> at org.jboss.as.ee.component.deployers.ComponentInstallProcessor.deployComponent(ComponentInstallProcessor.java:138)
> at org.jboss.as.ee.component.deployers.ComponentInstallProcessor.deploy(ComponentInstallProcessor.java:95)
> ... 6 more
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFLY-5256) HTTPS undertow listener don't request client certificate when verify-client=NOT_REQUESTED
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-5256?page=com.atlassian.jira.plugin.... ]
Stuart Douglas commented on WFLY-5256:
--------------------------------------
I have not been able to reproduce this. Is it still and issue with later versions of Wildfly?
> HTTPS undertow listener don't request client certificate when verify-client=NOT_REQUESTED
> -----------------------------------------------------------------------------------------
>
> Key: WFLY-5256
> URL: https://issues.jboss.org/browse/WFLY-5256
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 8.2.0.Final
> Reporter: Manuel Colchete
> Assignee: Stuart Douglas
>
> HTTPS undertow listener has 3 options for verify-client parameter: NOT_REQUESTED (Default), REQUESTED, REQUIRED. If it is set to NOT_REQUESTED (the default), it should not require a certificate chain unless the client requests a resource protected by a security constraint that uses CLIENT-CERT authentication. But when I tried to access secured resource as first, it don't requested certificate and return HTTP status 403.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFLY-5256) HTTPS undertow listener don't request client certificate when verify-client=NOT_REQUESTED
by Stuart Douglas (JIRA)
[ https://issues.jboss.org/browse/WFLY-5256?page=com.atlassian.jira.plugin.... ]
Stuart Douglas commented on WFLY-5256:
--------------------------------------
And if so can you attach a reproducer
> HTTPS undertow listener don't request client certificate when verify-client=NOT_REQUESTED
> -----------------------------------------------------------------------------------------
>
> Key: WFLY-5256
> URL: https://issues.jboss.org/browse/WFLY-5256
> Project: WildFly
> Issue Type: Bug
> Components: Web (Undertow)
> Affects Versions: 8.2.0.Final
> Reporter: Manuel Colchete
> Assignee: Stuart Douglas
>
> HTTPS undertow listener has 3 options for verify-client parameter: NOT_REQUESTED (Default), REQUESTED, REQUIRED. If it is set to NOT_REQUESTED (the default), it should not require a certificate chain unless the client requests a resource protected by a security constraint that uses CLIENT-CERT authentication. But when I tried to access secured resource as first, it don't requested certificate and return HTTP status 403.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFBUILD-16) Support subsystem templates within a feature-pack
by Pedro Igor (JIRA)
Pedro Igor created WFBUILD-16:
---------------------------------
Summary: Support subsystem templates within a feature-pack
Key: WFBUILD-16
URL: https://issues.jboss.org/browse/WFBUILD-16
Project: WildFly Build Tools
Issue Type: Feature Request
Affects Versions: 1.1.0.CR2
Reporter: Pedro Igor
Assignee: Stuart Douglas
Users should be able to customize subsystems when extending a feature-pack without being forced to have a subsystem artifact where the config file would be located.
Accordingly with [~swd847], something like "so you could just have it in a subsystem-templates in the feature pack src" would be enough.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (LOGMGR-125) Log rotation fails on Windows if target already exists
by James Perkins (JIRA)
[ https://issues.jboss.org/browse/LOGMGR-125?page=com.atlassian.jira.plugin... ]
James Perkins updated LOGMGR-125:
---------------------------------
Git Pull Request: https://github.com/jboss-logging/jboss-logmanager/pull/88, https://github.com/jboss-logging/jboss-logmanager/pull/89, https://github.com/jboss-logging/jboss-logmanager/pull/91 (was: https://github.com/jboss-logging/jboss-logmanager/pull/88, https://github.com/jboss-logging/jboss-logmanager/pull/89)
> Log rotation fails on Windows if target already exists
> ------------------------------------------------------
>
> Key: LOGMGR-125
> URL: https://issues.jboss.org/browse/LOGMGR-125
> Project: JBoss Log Manager
> Issue Type: Bug
> Reporter: James Livingston
> Assignee: James Perkins
> Fix For: 2.0.4.Final, 2.1.0.Beta1
>
>
> PeriodicRotatingFileHandler (and others) use File.renameTo() to rename the file. That method is documented as having many implementation-defined aspects, see http://docs.oracle.com/javase/7/docs/api/java/io/File.html#renameTo%28jav...
> One that can be a problem is that on Windows, it will fail if the target file already exists. If you use a ".dd" suffix, this will occur when it rolls over to a new month. It has rarely been a problem, since most people use the year month and day so they are unique. Files.move() can replace existing files, so may be better, and some of the costs of that are likely not to be a problem with how it is using here.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFLY-1415) Move away from expensive enum switch
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-1415?page=com.atlassian.jira.plugin.... ]
Brian Stansberry updated WFLY-1415:
-----------------------------------
Fix Version/s: (was: Awaiting Volunteers)
Yes. We're not really looking for community volunteers for this. It would involve a ton of coordination activity.
> Move away from expensive enum switch
> ------------------------------------
>
> Key: WFLY-1415
> URL: https://issues.jboss.org/browse/WFLY-1415
> Project: WildFly
> Issue Type: Task
> Reporter: David Lloyd
> Priority: Minor
> Labels: janitor
>
> We use enums and enum switch extensively. These constructs generate many, many additional classes and bloat the code base unnecessarily.
> All cases where we are using enum-based switches for our XML parsers should be converted to use Java 7 String switch instead. The enum values shall be replaced with String constant fields, all enum switches converted to String switches, and all enum types removed from these classes. The net result should be a reduction by dozens if not hundreds of .class files, and possibly a measurable performance boost as well.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFLY-1415) Move away from expensive enum switch
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFLY-1415?page=com.atlassian.jira.plugin.... ]
Darran Lofthouse commented on WFLY-1415:
----------------------------------------
I think if an when this happens it will need a lot of coordination before any work begins. We have already branches quite a lot for WildFly 11 and this is the kind of change that will conflict heavily with work already started.
> Move away from expensive enum switch
> ------------------------------------
>
> Key: WFLY-1415
> URL: https://issues.jboss.org/browse/WFLY-1415
> Project: WildFly
> Issue Type: Task
> Reporter: David Lloyd
> Priority: Minor
> Labels: janitor
> Fix For: Awaiting Volunteers
>
>
> We use enums and enum switch extensively. These constructs generate many, many additional classes and bloat the code base unnecessarily.
> All cases where we are using enum-based switches for our XML parsers should be converted to use Java 7 String switch instead. The enum values shall be replaced with String constant fields, all enum switches converted to String switches, and all enum types removed from these classes. The net result should be a reduction by dozens if not hundreds of .class files, and possibly a measurable performance boost as well.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months