[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd updated WFCORE-1132:
--------------------------------
Component/s: (was: Remoting)
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by Andrig Miller (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
Andrig Miller commented on WFCORE-1132:
---------------------------------------
We removed it from the Undertow configuration, as we had them specified, and STRACE still showed it being set. We then just commented out the code in XNIO, so we didn't use profiling with the stack trace, just STRACE to see what socket options were being set.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd commented on WFCORE-1132:
-------------------------------------
I've done a search through various code bases and I'm not actually finding any place which is setting the socket buffer size to 8192. Is it possible to get a backtrace from where you observe the call to {{setSendBufferSize()}} and/or {{setReceiveBufferSize()}}?
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd edited comment on WFCORE-1132 at 11/12/15 4:17 PM:
---------------------------------------------------------------
This analysis is probably wrong:
{quote}The "receive-buffer-size" and "send-buffer-size" management attributes have a default value of 8192 (bytes) as of 2.0 of the subsystem (that is, since WildFly 8 onwards). This is obviously a very poor default. On my system at least, the default buffer sizes are nearer to 100s of kilobytes.
The performance team argues that there should be no default, letting the OS choose. I'm okay with that, and I'm also okay with changing the default to something more sensible in the 128k range, depending on what works best for compatibility, etc.{quote}
Still figuring out what's happening here. Those attributes seem to correspond to the Remoting buffer sizes as expected, so this problem may actually be in the Undertow subsystem after all.
was (Author: dmlloyd):
This analysis is probably wrong:
{quote}The "receive-buffer-size" and "send-buffer-size" management attributes have a default value of 8192 (bytes) as of 2.0 of the subsystem (that is, since WildFly 8 onwards). This is obviously a very poor default. On my system at least, the default buffer sizes are nearer to 100s of kilobytes.
The performance team argues that there should be no default, letting the OS choose. I'm okay with that, and I'm also okay with changing the default to something more sensible in the 128k range, depending on what works best for compatibility, etc.{quote}
Still figuring out what's happening here.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd edited comment on WFCORE-1132 at 11/12/15 4:16 PM:
---------------------------------------------------------------
This analysis is probably wrong:
{quote}The "receive-buffer-size" and "send-buffer-size" management attributes have a default value of 8192 (bytes) as of 2.0 of the subsystem (that is, since WildFly 8 onwards). This is obviously a very poor default. On my system at least, the default buffer sizes are nearer to 100s of kilobytes.
The performance team argues that there should be no default, letting the OS choose. I'm okay with that, and I'm also okay with changing the default to something more sensible in the 128k range, depending on what works best for compatibility, etc.{quote}
Still figuring out what's happening here.
was (Author: dmlloyd):
The "receive-buffer-size" and "send-buffer-size" management attributes have a default value of 8192 (bytes) as of 2.0 of the subsystem (that is, since WildFly 8 onwards). This is obviously a very poor default. On my system at least, the default buffer sizes are nearer to 100s of kilobytes.
The performance team argues that there should be no default, letting the OS choose. I'm okay with that, and I'm also okay with changing the default to something more sensible in the 128k range, depending on what works best for compatibility, etc.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1019) History browsing in CLI (using the up arrow) works strangely
by Ståle Pedersen (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1019?page=com.atlassian.jira.plugi... ]
Ståle Pedersen commented on WFCORE-1019:
----------------------------------------
this is an æsh bug, ill fix it in a 0.66.* version
> History browsing in CLI (using the up arrow) works strangely
> ------------------------------------------------------------
>
> Key: WFCORE-1019
> URL: https://issues.jboss.org/browse/WFCORE-1019
> Project: WildFly Core
> Issue Type: Enhancement
> Components: CLI
> Affects Versions: 2.0.0.CR1, 2.0.0.CR5
> Reporter: Ladislav Thon
> Assignee: Alexey Loubyansky
>
> I tend to rely on history browsing in the CLI a lot, but it got broken in WildFly 10.0.0.CR1 / WildFly Core 2.0.0.CR1 (I'd guess that the cause is the AESH upgrade). Let's see:
> {code}
> rm ~/.jboss-cli-history # let's start with clean slate
> ./wildfly-10.0.0.Beta2/bin/standalone.sh
> # the following is in second console
> ./wildfly-10.0.0.Beta2/bin/jboss-cli.sh -c
> :read-resource
> :whoami
> [up arrow shows :whoami, so press Enter to run it]
> [and repeat, up arrow shows :whoami]
> {code}
> OK, that's expected. Repeat the process with WildFly 10.0.0.CR1 or CR2 and you'll find out that the second \[up arrow\] shows {{:read-resource}}. This is IMHO highly wrong and it confused me _a lot_ when I first encoutered this bad behavior.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by Andrig Miller (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
Andrig Miller edited comment on WFCORE-1132 at 11/12/15 4:10 PM:
-----------------------------------------------------------------
We would prefer no defaults, and this also follows the recommendation from the networking expert on the platform performance team.
One other data point, in our testing in the performance lab, latency improved significantly by removing the setting of the send and receive buffers.
was (Author: andy.miller):
We would prefer no defaults, and this also follows the recommendation from the networking expert on the platform performance team.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by Andrig Miller (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
Andrig Miller commented on WFCORE-1132:
---------------------------------------
We would prefer no defaults, and this also follows the recommendation from the networking expert on the platform performance team.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd updated WFCORE-1132:
--------------------------------
Description:
Original report:
{quote}
In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
{quote}
This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
was:
Original report:
{quote}
In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
{quote}
This applies to the Remoting subsystem configuration, versions 2.0 and onwards.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards, and also possibly to Undertow, though that subsystem does not appear to use default values.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months
[JBoss JIRA] (WFCORE-1132) Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
by David Lloyd (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1132?page=com.atlassian.jira.plugi... ]
David Lloyd updated WFCORE-1132:
--------------------------------
Description:
Original report:
{quote}
In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
{quote}
This applies to the Remoting subsystem configuration, versions 2.0 and onwards.
was:
In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> Only set socket send and receive buffer sizes if it is in the Remoting subsystem configuration
> ----------------------------------------------------------------------------------------------
>
> Key: WFCORE-1132
> URL: https://issues.jboss.org/browse/WFCORE-1132
> Project: WildFly Core
> Issue Type: Bug
> Components: Remoting
> Affects Versions: 2.0.1.Final
> Reporter: Andrig Miller
> Priority: Blocker
> Fix For: 2.0.2.Final (EAP 7)
>
>
> Original report:
> {quote}
> In our testing of Wildfy 10 CR4, in the performance lab, we found that one of the differences between EAP 6.4.x and Wildfly 10 was that EAP does not set the socket send and receive buffers. We changed the configuration of Wildfly (Undertow) to remove the buffer parameters from the configuration, and we found that the buffer sizes were still be set to 8k. We hacked XNIO to comment out the setting of these parameters, and latency improved quite a bit.
> So, we need a permanent fix so that the socket send and receive buffers are only set, if they are specified in the configuration.
> {quote}
> This applies to the Remoting subsystem configuration, versions 2.0 and onwards.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 8 months