[JBoss JIRA] (JGRP-2117) TP: messages to self are not batched
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2117?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2117:
---------------------------
Labels: CR3 (was: )
> TP: messages to self are not batched
> ------------------------------------
>
> Key: JGRP-2117
> URL: https://issues.jboss.org/browse/JGRP-2117
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Labels: CR3
> Fix For: 4.0
>
>
> If A sends 100 multicast messages (or unicast messages to self), the messages to self are not batched but looped back individually, each using a separate thread from the thread pool.
> So in the above case, A will receive its own 100 messages using 100 threads from the pool.
> It would be more efficient to batch the 100 messages into a batch and then loop the batch back, taking up 1 thread instead of 100!
> To do this, looping back has to be done _after_ the bundler, when the bundler is sending the message batch.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (JGRP-2126) Table.removeMany() creates unneeded temporary list
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2126?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2126:
---------------------------
Labels: CR3 (was: )
> Table.removeMany() creates unneeded temporary list
> --------------------------------------------------
>
> Key: JGRP-2126
> URL: https://issues.jboss.org/browse/JGRP-2126
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Labels: CR3
> Fix For: 4.0
>
>
> When a thread acquires the CAS in NAKACK2 or UNICAST3 to deliver messages, it calls Table.removeMany() which removes messages that satisfy a condition and return them as a list. Next, a MessageBatch is created off of that list and passed up.
> The creation of the temp list is unnecessary; instead create a properly sized MessageBatch and make Table.removeMany() add the messages directly into the batch.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (JGRP-2130) Log: cache result of log.isTraceEnabled()
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2130?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2130:
--------------------------------
For protocols like NAKACK2 or UNICAST3, the result of log.isTraceEnabled() is cached in {{is_trace}}, but when the log level is changed (via {{setLogLevel()}}, {{is_trace}} is also changed.
> Log: cache result of log.isTraceEnabled()
> -----------------------------------------
>
> Key: JGRP-2130
> URL: https://issues.jboss.org/browse/JGRP-2130
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Labels: CR1
> Fix For: 4.0
>
>
> e.g.
> {noformat}
> boolean trace=log.isTraceEnabled();
> loop {
> if(trace) ...
> }
> {noformat}
> Unfortunately, {{isTraceEnabled()}} is not free in most scenarios, so the cost of invoking this method should be amortized over multiple calls.
> I don't want to cache this at a global level, or else we wouldn't be able to change the log level at runtime...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (JGRP-2130) Log: cache result of log.isTraceEnabled()
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2130?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-2130:
---------------------------
Labels: CR1 (was: )
> Log: cache result of log.isTraceEnabled()
> -----------------------------------------
>
> Key: JGRP-2130
> URL: https://issues.jboss.org/browse/JGRP-2130
> Project: JGroups
> Issue Type: Enhancement
> Reporter: Bela Ban
> Assignee: Bela Ban
> Priority: Minor
> Labels: CR1
> Fix For: 4.0
>
>
> e.g.
> {noformat}
> boolean trace=log.isTraceEnabled();
> loop {
> if(trace) ...
> }
> {noformat}
> Unfortunately, {{isTraceEnabled()}} is not free in most scenarios, so the cost of invoking this method should be amortized over multiple calls.
> I don't want to cache this at a global level, or else we wouldn't be able to change the log level at runtime...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7574) Elytron "expressions-allowed" => true attributes
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/WFLY-7574?page=com.atlassian.jira.plugin.... ]
Martin Choma moved JBEAP-7242 to WFLY-7574:
-------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-7574 (was: JBEAP-7242)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Security
(was: Security)
(was: User Experience)
Affects Version/s: 11.0.0.Alpha1
(was: 7.1.0.DR8)
> Elytron "expressions-allowed" => true attributes
> ------------------------------------------------
>
> Key: WFLY-7574
> URL: https://issues.jboss.org/browse/WFLY-7574
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Martin Choma
>
> Please review these usage of "expressions-allowed" => true
> * class names and module names
> {code}
> /custom-role-mapper/module
> /custom-role-mapper/class-name
> /constant-permission-mapper/module
> /constant-permission-mapper/class-name
> /simple-permission-mapper/permission-mappings/module
> /simple-permission-mapper/permission-mappings/class-name
> /custom-permission-mapper/module
> /custom-permission-mapper/class-name
> /custom-name-rewriter/module
> /custom-name-rewriter/class-name
> /custom-principal-decoder/module
> /custom-principal-decoder/class-name
> /custom-realm-mapper/module
> /custom-realm-mapper/class-name
> /service-loader-http-server-mechanism-factory/module
> /service-loader-sasl-server-factory/module
> /custom-modifiable-realm/module
> /custom-modifiable-realm/class-name
> /custom-credential-security-factory/module
> /custom-credential-security-factory/class-name
> /custom-role-decoder/module
> /custom-role-decoder/class-name
> /custom-realm/module
> /custom-realm/class-name
> {code}
> Brian: "Traditionally we also don't allow expressions on attributes whose values are classnames or module names
> TBH there is no great reason for that, beyond a feeling that it will allow greater flexibility for future changes at little practical cost
> but it's what we've done and we might as well stick to it"
> * referencing another services
> {code}
> /sasl-authentication-factory/mechanism-configurations/mechanism-realm-configurations
> /http-authentication-factory/mechanism-configurations/mechanism-realm-configurations
> /ldap-key-store/dir-context
> /server-ssl-context/provider-loader
> /client-ssl-context/provider-loader
> /filtering-key-store/key-store
> /dir-context/ssl-context
> /ldap-realm/dir-context
> /trust-managers/key-store
> /trust-managers/provider-loader
> /key-managers/key-store
> /key-managers/provider-loader
> /credential-store/relative-to
> /credential-store/provider-loader
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7570) JBeret WildFly extension cannot handle runtime-name
by Cheng Fang (JIRA)
[ https://issues.jboss.org/browse/WFLY-7570?page=com.atlassian.jira.plugin.... ]
Cheng Fang reassigned WFLY-7570:
--------------------------------
Assignee: James Perkins (was: Cheng Fang)
> JBeret WildFly extension cannot handle runtime-name
> ---------------------------------------------------
>
> Key: WFLY-7570
> URL: https://issues.jboss.org/browse/WFLY-7570
> Project: WildFly
> Issue Type: Bug
> Components: Batch
> Affects Versions: 11.0.0.Alpha1
> Environment: Nightly build from 11th of November from here:
> https://ci.jboss.org/hudson/job/WildFly-latest-master/lastBuild/
> java -version
> {noformat}
> java version "1.8.0_102"
> Java(TM) SE Runtime Environment (build 1.8.0_102-b14)
> Java HotSpot(TM) 64-Bit Server VM (build 25.102-b14, mixed mode)
> {noformat}
> Reporter: Markus Falk
> Assignee: James Perkins
> Attachments: error.png
>
>
> A NullPointerException is thrown, when using a runtime-name for a batch job.
> Exception
> {noformat}
> ERROR [org.jboss.as.controller.management-operation] (management-handler-thread - 13) WFLYCTL0013: Operation ("read-attribute") failed - address: ([
> ("deployment" => "batch-chunk-csv-database.war"),
> ("subsystem" => "batch-jberet"),
> ("job" => "myJob")
> ]): java.lang.NullPointerException
> at org.wildfly.extension.batch.jberet.deployment.JobOperationStepHandler.execute(JobOperationStepHandler.java:68)
> at org.jboss.as.controller.operations.global.ReadAttributeHandler.doExecuteInternal(ReadAttributeHandler.java:174)
> at org.jboss.as.controller.operations.global.ReadAttributeHandler.doExecute(ReadAttributeHandler.java:137)
> at org.jboss.as.controller.operations.global.GlobalOperationHandlers$AbstractMultiTargetHandler.execute(GlobalOperationHandlers.java:230)
> at org.jboss.as.controller.operations.global.GlobalOperationHandlers$AvailableResponseWrapper.execute(GlobalOperationHandlers.java:988)
> at org.jboss.as.controller.AbstractOperationContext.executeStep(AbstractOperationContext.java:921)
> at org.jboss.as.controller.AbstractOperationContext.processStages(AbstractOperationContext.java:664)
> at org.jboss.as.controller.AbstractOperationContext.executeOperation(AbstractOperationContext.java:383)
> at org.jboss.as.controller.OperationContextImpl.executeOperation(OperationContextImpl.java:1364)
> at org.jboss.as.controller.ModelControllerImpl.internalExecute(ModelControllerImpl.java:416)
> at org.jboss.as.controller.ModelControllerImpl.lambda$execute$1(ModelControllerImpl.java:237)
> at org.wildfly.security.auth.client.PeerIdentity.runAsAll(PeerIdentity.java:431)
> at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:206)
> at org.jboss.as.controller.ModelControllerImpl.execute(ModelControllerImpl.java:237)
> at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.doExecute(ModelControllerClientOperationHandler.java:217)
> at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler.access$400(ModelControllerClientOperationHandler.java:137)
> at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:161)
> at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1$1.run(ModelControllerClientOperationHandler.java:157)
> at org.wildfly.security.auth.client.PeerIdentity.runAsAll(PeerIdentity.java:464)
> at org.wildfly.security.auth.server.SecurityIdentity.runAs(SecurityIdentity.java:225)
> at org.jboss.as.controller.AccessAuditContext.doAs(AccessAuditContext.java:185)
> at org.jboss.as.controller.remote.ModelControllerClientOperationHandler$ExecuteRequestHandler$1.execute(ModelControllerClientOperationHandler.java:157)
> at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$1.doExecute(ManagementRequestContextImpl.java:70)
> at org.jboss.as.protocol.mgmt.ManagementRequestContextImpl$AsyncTaskRunner.run(ManagementRequestContextImpl.java:160)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> at org.jboss.threads.JBossThread.run(JBossThread.java:320)
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFCORE-1981) Many deprecation warnings in wf-core code
by Rostislav Svoboda (JIRA)
Rostislav Svoboda created WFCORE-1981:
-----------------------------------------
Summary: Many deprecation warnings in wf-core code
Key: WFCORE-1981
URL: https://issues.jboss.org/browse/WFCORE-1981
Project: WildFly Core
Issue Type: Bug
Affects Versions: 3.0.0.Alpha12
Reporter: Rostislav Svoboda
Assignee: Tomaz Cerar
Attachments: wf-core-deprecated-log.txt
There are many deprecation (281 atm) warnings in wf-core code.
List of detected deprecations attached.
summary:
{code}
cat wf-core-deprecated-log.txt | cut -d] -f2 | sort | uniq -c | sort -n -r
66 Caller in org.jboss.as.controller.access has been deprecated
27 ServiceListener in org.jboss.msc.service has been deprecated
26 Pool in org.xnio has been deprecated
21 CurrentOperationIdHolder in org.jboss.as.controller has been deprecated
13 ExternalManagementRequestExecutor in org.jboss.as.server has been deprecated
13 ExtensibleHttpManagement in org.jboss.as.server.mgmt.domain has been deprecated
12 ServiceVerificationHandler in org.jboss.as.controller has been deprecated
9 ByteBufferSlicePool in org.xnio has been deprecated
8 RealmIdentityManager in org.jboss.as.domain.http.server.security has been deprecated
6 SERVICE_NAME in RequestController has been deprecated
6 builder(PersistentResourceDefinition) in PersistentResourceXMLDescription has been deprecated
4 ServerStartException in org.wildfly.core.embedded has been deprecated
4 ServerRestartRequiredHandler in org.jboss.as.server.operations has been deprecated
4 removePropertyChangeListener(PropertyChangeListener) in ControlledProcessStateService has been deprecated
4 ExtensionContextSupplement in org.jboss.as.controller.extension has been deprecated
4 AbstractControllerService(ProcessType,RunningModeControl,ConfigurationPersister,ControlledProcessState,ResourceDefinition,OperationStepHandler,ExpressionResolver) in AbstractControllerService has been deprecated
3 transformOperation(ModelVersion,ModelNode,TransformerOperationAttachment) in KernelServices has been deprecated
3 SimpleResourceDefinition(PathElement,ResourceDescriptionResolver,OperationStepHandler,OperationStepHandler,Flag,Flag) in SimpleResourceDefinition has been deprecated
3 register(TransformationDescription,SubsystemRegistration,ModelVersionRange) in Tools has been deprecated
3 JBOSS_BINDING_NAME in SocketBinding has been deprecated
3 executeAndGrabTransformerAttachment(ModelNode) in KernelServices has been deprecated
3 addPropertyChangeListener(PropertyChangeListener) in ControlledProcessStateService has been deprecated
2 OPTIONAL in DependencyType has been deprecated
2 Note: Some input files additionally use or override a deprecated API.
2 MultipleResponseAsyncTask in ManagementRequestContext has been deprecated
2 getCurrentState() in ControlledProcessStateService has been deprecated
2 ExtensionRegistry(ProcessType,RunningModeControl) in ExtensionRegistry has been deprecated
2 deserialize(String,byte[
2 deserialize(ObjectName,byte[
2 builder(PersistentResourceDefinition,String) in PersistentResourceXMLDescription has been deprecated
2 AbstractControllerService(ProcessType,RunningModeControl,ConfigurationPersister,ControlledProcessState,ResourceDefinition,OperationStepHandler,ExpressionResolver,ManagedAuditLogger,DelegatingConfigurableAuthorizer) in AbstractControllerService has been deprecated
2 AbstractControllerService(ProcessType,RunningModeControl,ConfigurationPersister,ControlledProcessState,DescriptionProvider,OperationStepHandler,ExpressionResolver) in AbstractControllerService has been deprecated
1 setXmlName(String) in Builder has been deprecated
1 setWrapperElement(String) in Builder has been deprecated
1 PROCESS_STATE in ServerDescriptionConstants has been deprecated
1 OperationFailedException(ModelNode) in OperationFailedException has been deprecated
1 ManagedDMRContentTypeResource(PathElement,String,byte[
1 installConnectorServicesForNetworkInterfaceBinding(ServiceTarget,ServiceName,String,ServiceName,int,OptionMap,ServiceName,ServiceName,ServiceName) in RemotingServices has been deprecated
1 initializeExtraSubystemsAndModel(ExtensionRegistry,Resource,ManagementResourceRegistration) in AdditionalInitialization has been deprecated
1 getDeploymentSubsystemModel(String) in DeploymentUnit has been deprecated
1 generateLegacySubsystemResourceRegistrationDmr(KernelServices,ModelVersion) in AbstractSubsystemTest has been deprecated
1 enableTransformerAttachmentGrabber() in KernelServicesBuilder has been deprecated
1 currentAccessAuditContext() in AccessAuditContext has been deprecated
1 createVault(String,Map<String,Object>) in AbstractVaultReader has been deprecated
1 createLegacyTestStructure(File) in TestUtils has been deprecated
1 createDeploymentSubModel(String,PathElement) in DeploymentUnit has been deprecated
1 createDeploymentSubModel(String,PathAddress,Resource) in DeploymentUnit has been deprecated
1 createDeploymentSubModel(String,PathAddress) in DeploymentUnit has been deprecated
{code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7573) Elytron oauth2-introspection descriptions copy/pasted from jwt
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/WFLY-7573?page=com.atlassian.jira.plugin.... ]
Martin Choma moved JBEAP-7123 to WFLY-7573:
-------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-7573 (was: JBEAP-7123)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Security
(was: Security)
(was: User Experience)
Affects Version/s: 11.0.0.Alpha1
(was: 7.1.0.DR8)
> Elytron oauth2-introspection descriptions copy/pasted from jwt
> --------------------------------------------------------------
>
> Key: WFLY-7573
> URL: https://issues.jboss.org/browse/WFLY-7573
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Martin Choma
>
> /token-realm/oauth2-introspection descriptions are apparently copied from jwt. For example:
> {code}
> "client-secret" => {
> "type" => STRING,
> "description" => "A list of strings representing the audiences supported by this configuration. During validation JWT tokens must have an <code>aud</code> claim that contains one of the values defined here.",
> "expressions-allowed" => false,
> "nillable" => false,
> "min-length" => 1L,
> "max-length" => 2147483647L
> }
> {code}
> It applies to these attributes:
> * {{client-id}}
> * {{client-secret}}
> * {{client-ssl-context}}
> * {{introspection-url}}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7572) Elytron expects certificate in PEM format as user input
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/WFLY-7572?page=com.atlassian.jira.plugin.... ]
Martin Choma updated WFLY-7572:
-------------------------------
Labels: user_experience (was: )
> Elytron expects certificate in PEM format as user input
> -------------------------------------------------------
>
> Key: WFLY-7572
> URL: https://issues.jboss.org/browse/WFLY-7572
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Martin Choma
> Labels: user_experience
>
> In {{/token-realm/public-key}} attribute there is certificate in PEM format expected, which I consider to be user un-friendly.
> I wonder couldn't that be accomplished by leveraging key-store/trust-manager capability?
> {code}
> "public-key" => {
> "type" => STRING,
> "description" => "A public key in PEM Format. During validation, if a public key is provided, signature will be verified based on the key you provided here.",
> "expressions-allowed" => false,
> "nillable" => true,
> "min-length" => 1L,
> "max-length" => 2147483647L
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7572) Elytron expects certificate in PEM format as user input
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/WFLY-7572?page=com.atlassian.jira.plugin.... ]
Martin Choma moved JBEAP-7121 to WFLY-7572:
-------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-7572 (was: JBEAP-7121)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Security
(was: Security)
Affects Version/s: 11.0.0.Alpha1
(was: 7.1.0.DR8)
> Elytron expects certificate in PEM format as user input
> -------------------------------------------------------
>
> Key: WFLY-7572
> URL: https://issues.jboss.org/browse/WFLY-7572
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Martin Choma
>
> In {{/token-realm/public-key}} attribute there is certificate in PEM format expected, which I consider to be user un-friendly.
> I wonder couldn't that be accomplished by leveraging key-store/trust-manager capability?
> {code}
> "public-key" => {
> "type" => STRING,
> "description" => "A public key in PEM Format. During validation, if a public key is provided, signature will be verified based on the key you provided here.",
> "expressions-allowed" => false,
> "nillable" => true,
> "min-length" => 1L,
> "max-length" => 2147483647L
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months