[JBoss JIRA] (WFLY-7476) Complicated failure-descriptions in Elytron properties-realm
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7476?page=com.atlassian.jira.plugin.... ]
Jan Kalina commented on WFLY-7476:
----------------------------------
Required services that are not installed: this message is handled by wildfly as consequece of missing referenced capability.
> Complicated failure-descriptions in Elytron properties-realm
> ------------------------------------------------------------
>
> Key: WFLY-7476
> URL: https://issues.jboss.org/browse/WFLY-7476
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Labels: user_experience
>
> There are complicated failure-descriptions in Elytron properties-realm. They include some details from exceptions which are not needed and can be confused for non-java administrators. Please handle these exceptions and provide some user friendly failure-description.
> Examples of complicated failure-description in properties-realm:
> * Adding path which does not exist:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=/wrong/path/a.properties})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0080: Failed services" => {"org.wildfly.security.security-realm.realm" => "org.jboss.msc.service.StartException in service org.wildfly.security.security-realm.realm: WFLYELY00014: Unable to load the properties files required to start the properties file backed realm.
> Caused by: java.io.FileNotFoundException: /wrong/path/a.properties (No such file or directory)"},
> "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.security.security-realm.realm"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
> },
> "rolled-back" => true
> }
> {code}
> * Adding file with missing $REALM:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=/some/path/roles.properties})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0080: Failed services" => {"org.wildfly.security.security-realm.realm" => "org.jboss.msc.service.StartException in service org.wildfly.security.security-realm.realm: WFLYELY00014: Unable to load the properties files required to start the properties file backed realm.
> Caused by: java.io.IOException: ELY01006: No realm name found in properties file"},
> "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.security.security-realm.realm"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
> },
> "rolled-back" => true
> }
> {code}
> * path mentiond in relative-to does not exist:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=users.properties,relative-to=non.exist})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.server.path.\"non.exist\""],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => ["org.wildfly.security.security-realm.realm is missing [jboss.server.path.\"non.exist\"]"]
> },
> "rolled-back" => true
> }
> {code}
> Suggestion for improvement:
> * use only description of failure, e.g. something like "file /wrong/path/a.properties was not found"
> * do not use any unneeded information - e.g. "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7476) Complicated failure-descriptions in Elytron properties-realm
by Brian Stansberry (JIRA)
[ https://issues.jboss.org/browse/WFLY-7476?page=com.atlassian.jira.plugin.... ]
Brian Stansberry commented on WFLY-7476:
----------------------------------------
It's not generated by MSC.
> Complicated failure-descriptions in Elytron properties-realm
> ------------------------------------------------------------
>
> Key: WFLY-7476
> URL: https://issues.jboss.org/browse/WFLY-7476
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Labels: user_experience
>
> There are complicated failure-descriptions in Elytron properties-realm. They include some details from exceptions which are not needed and can be confused for non-java administrators. Please handle these exceptions and provide some user friendly failure-description.
> Examples of complicated failure-description in properties-realm:
> * Adding path which does not exist:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=/wrong/path/a.properties})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0080: Failed services" => {"org.wildfly.security.security-realm.realm" => "org.jboss.msc.service.StartException in service org.wildfly.security.security-realm.realm: WFLYELY00014: Unable to load the properties files required to start the properties file backed realm.
> Caused by: java.io.FileNotFoundException: /wrong/path/a.properties (No such file or directory)"},
> "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.security.security-realm.realm"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
> },
> "rolled-back" => true
> }
> {code}
> * Adding file with missing $REALM:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=/some/path/roles.properties})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0080: Failed services" => {"org.wildfly.security.security-realm.realm" => "org.jboss.msc.service.StartException in service org.wildfly.security.security-realm.realm: WFLYELY00014: Unable to load the properties files required to start the properties file backed realm.
> Caused by: java.io.IOException: ELY01006: No realm name found in properties file"},
> "WFLYCTL0412: Required services that are not installed:" => ["org.wildfly.security.security-realm.realm"],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
> },
> "rolled-back" => true
> }
> {code}
> * path mentiond in relative-to does not exist:
> {code}
> /subsystem=elytron/properties-realm=realm:add(users-properties={path=users.properties,relative-to=non.exist})
> {
> "outcome" => "failed",
> "failure-description" => {
> "WFLYCTL0412: Required services that are not installed:" => ["jboss.server.path.\"non.exist\""],
> "WFLYCTL0180: Services with missing/unavailable dependencies" => ["org.wildfly.security.security-realm.realm is missing [jboss.server.path.\"non.exist\"]"]
> },
> "rolled-back" => true
> }
> {code}
> Suggestion for improvement:
> * use only description of failure, e.g. something like "file /wrong/path/a.properties was not found"
> * do not use any unneeded information - e.g. "WFLYCTL0180: Services with missing/unavailable dependencies" => undefined
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7146) Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/WFLY-7146?page=com.atlassian.jira.plugin.... ]
Ilia Vassilev edited comment on WFLY-7146 at 11/9/16 9:45 AM:
--------------------------------------------------------------
Submitted new PR [1] for the requested changes from JBEAP-5986.
Note: The "Fix Version/s" field is unchanged and needs to be corrected with the right version.
[1] https://github.com/wildfly-security/elytron-subsystem/pull/291
was (Author: ivassile):
Submitted new PR [1] for the requested changes from JBEAP-5986.
[1] https://github.com/wildfly-security/elytron-subsystem/pull/291
> Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description
> --------------------------------------------------------------------------------------------
>
> Key: WFLY-7146
> URL: https://issues.jboss.org/browse/WFLY-7146
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Jan Kalina
> Assignee: Ilia Vassilev
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> Attribute 'match' is required when adding 'regex-name-validating-rewriter' although when reading the resource description via CLI, I can see that it has defined default value (true) and in [XSD file|https://github.com/wildfly-security/elytron-subsystem/blob/1.0.0.Alp...] it is not stated as a 'required'. Try:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:add(pattern=".*")
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0172: match is required",
> "rolled-back" => true
> }
> {code}
> When you try to add also with 'match' attribute then rewriter is added successfully.
> Also - the 'match' attribute description in CLI is not quite clear:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:read-resource-description
> ...
> "match" => {
> "type" => BOOLEAN,
> "description" => "Should names that match the pattern be rejected or names that don't",
> "expressions-allowed" => true,
> "nillable" => false,
> "default" => true,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "resource-services"
> },
> ...
> {code}
> After reading the description I still don't know what happens when pattern matches the name and value of 'match' attribute is set to 'true' - will it be rejected or not?
> Expected behaviour:
> # 'match' attribute to be arbitrary (or change XSD so it is in sync with model)
> # more clear description of 'match' attribute
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7146) Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/WFLY-7146?page=com.atlassian.jira.plugin.... ]
Ilia Vassilev commented on WFLY-7146:
-------------------------------------
Submitted new PR [1] for the requested changes from JBEAP-5986.
[1] https://github.com/wildfly-security/elytron-subsystem/pull/291
> Elytron, regex-name-validating-rewriter - 'match' attribute required and unclear description
> --------------------------------------------------------------------------------------------
>
> Key: WFLY-7146
> URL: https://issues.jboss.org/browse/WFLY-7146
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Reporter: Jan Kalina
> Assignee: Ilia Vassilev
> Priority: Minor
> Fix For: 11.0.0.Alpha1
>
>
> Attribute 'match' is required when adding 'regex-name-validating-rewriter' although when reading the resource description via CLI, I can see that it has defined default value (true) and in [XSD file|https://github.com/wildfly-security/elytron-subsystem/blob/1.0.0.Alp...] it is not stated as a 'required'. Try:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:add(pattern=".*")
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0172: match is required",
> "rolled-back" => true
> }
> {code}
> When you try to add also with 'match' attribute then rewriter is added successfully.
> Also - the 'match' attribute description in CLI is not quite clear:
> {code}
> /subsystem=elytron/regex-name-validating-rewriter=nameRewriter:read-resource-description
> ...
> "match" => {
> "type" => BOOLEAN,
> "description" => "Should names that match the pattern be rejected or names that don't",
> "expressions-allowed" => true,
> "nillable" => false,
> "default" => true,
> "access-type" => "read-write",
> "storage" => "configuration",
> "restart-required" => "resource-services"
> },
> ...
> {code}
> After reading the description I still don't know what happens when pattern matches the name and value of 'match' attribute is set to 'true' - will it be rejected or not?
> Expected behaviour:
> # 'match' attribute to be arbitrary (or change XSD so it is in sync with model)
> # more clear description of 'match' attribute
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months