[JBoss JIRA] (WFCORE-1934) Make maximumPoolSize of ServerService Thread Pool configurable
by Masafumi Miura (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1934?page=com.atlassian.jira.plugi... ]
Masafumi Miura commented on WFCORE-1934:
----------------------------------------
Here's a proposed patch:
https://github.com/wildfly/wildfly-core/compare/2.x...msfm:WFCORE-1934
I would like to propose a new system property {{org.jboss.server.services.maxThreads}} for ServerService Thread Pool (similarly to org.jboss.server.bootstrap.maxThreads for MSC Threads).
Default is not changed. But, when {{org.jboss.server.services.maxThreads}} is configured, the specified value is set to both corePoolSize and maximumPoolSize, and also BlockingQueue is changed from SynchronousQueue (Direct handoffs) to LinkedBlockingQueue (Unbounded queues):
|| || corePoolSize || maximumPoolSize || BlockingQueue ||
|Default| 0 | Integer.MAX_VALUE | SynchronousQueue |
|-Dorg.jboss.server.services.maxThreads=100 | 100 | 100 | LinkedBlockingQueue |
> Make maximumPoolSize of ServerService Thread Pool configurable
> --------------------------------------------------------------
>
> Key: WFCORE-1934
> URL: https://issues.jboss.org/browse/WFCORE-1934
> Project: WildFly Core
> Issue Type: Bug
> Components: Server
> Affects Versions: 2.2.0.Final
> Reporter: Masafumi Miura
> Assignee: Jason Greene
> Attachments: ServerServiceThreadPool_ejb_startup_singleton.zip, ServerServiceThreadPool_persistence_unit.zip
>
>
> Provide a way to configure {{maximumPoolSize}} of {{ServerService Thread Pool}}. It defaults to {{Integer.MAX_VALUE}} and it's unable to be changed in the current implementation:
>
> {quote}
> https://github.com/wildfly/wildfly-core/blob/master/server/src/main/java/...
> {code}
> 446 public synchronized void start(StartContext context) throws StartException {
> 447 executorService = new ThreadPoolExecutor(0, Integer.MAX_VALUE, 20L, TimeUnit.SECONDS,
> 448 new SynchronousQueue<Runnable>(), threadFactory);
> 449 }
> {code}
> {quote}
> Though the threads will disappear after 20 seconds of finishing a task, ulimit ({{nproc}}, max user processes) has a possibility to run out depending on deployed applications. For example, an application coming with many {{<persistence-unit>}} entries in {{persistence.xml}} or a lot of @Startup @Singleton EJB can cause spawning a lot of {{ServerService Thread Pool}} thread.
> Even if ulimit can be configurable and it is recommended to be tuned in a production environment, making {{maximumPoolSize}} of {{ServerService Thread Pool}} configurable would be helpful.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7176) Review x500-attribute-principal-decoder resource in Elytron subsystem
by Ondrej Lukas (JIRA)
[ https://issues.jboss.org/browse/WFLY-7176?page=com.atlassian.jira.plugin.... ]
Ondrej Lukas commented on WFLY-7176:
------------------------------------
[~honza889] Splitting JBEAP-6100 into more Jiras was requested by developers. There was requirement to have one jira per every resource with stability "to be reviewed" in Elytron Subsystem Stability spreadsheet. State of stability is set by developers. In case when you think that nothing in this resource need to be reviewed then change the stability status of x500-attribute-principal-decoder to "stable" and move related Jira to QA.
> Review x500-attribute-principal-decoder resource in Elytron subsystem
> ---------------------------------------------------------------------
>
> Key: WFLY-7176
> URL: https://issues.jboss.org/browse/WFLY-7176
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Priority: Critical
>
> See description of JBEAP-6100 for more details.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (DROOLS-1321) Prefer https over http for absolute links on drools.org, optaplanner.org, jbpm.org and kiegroup.org
by Michael Biarnes Kiefer (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1321?page=com.atlassian.jira.plugi... ]
Michael Biarnes Kiefer resolved DROOLS-1321.
--------------------------------------------
Resolution: Done
> Prefer https over http for absolute links on drools.org, optaplanner.org, jbpm.org and kiegroup.org
> ---------------------------------------------------------------------------------------------------
>
> Key: DROOLS-1321
> URL: https://issues.jboss.org/browse/DROOLS-1321
> Project: Drools
> Issue Type: Task
> Components: build
> Reporter: Geoffrey De Smet
> Assignee: Michael Biarnes Kiefer
>
> Motivation:
> 1) Chrome has "a long-term plan to mark all HTTP sites as non-secure."
> https://security.googleblog.com/2016/09/moving-towards-more-secure-web.html
> 2) SEO: Google/Bing penalize website (lower ranking) that use http or mix http and https.
> To do:
> - Change all absolute links on our websites _and in our user manuals_ that lead to redhat.com, jboss.org, drools.org, optaplanner.org, jbpm.org and kiegroup.org to https.
> - This includes canonical meta elements
> - This includes tabzilla.js/.css loading of images (those actually give us the mixed https and http errors in chrome's inspect tooling if you go to https://www.drools.org today)
> - This does not include external links, such as to wikipedia etc.
> Keep an eye out on google webmaster tools to verify this doesn't introduce broken links.
> Exceptions:
> - ci.optaplanner.org must be on http, because those sites don't work over https...
> Note: I've asked eng-ops to do ssl monitoring of our websites. So basically no risk of out of date certifications etc.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFCORE-1934) Make maximumPoolSize of ServerService Thread Pool configurable
by Masafumi Miura (JIRA)
Masafumi Miura created WFCORE-1934:
--------------------------------------
Summary: Make maximumPoolSize of ServerService Thread Pool configurable
Key: WFCORE-1934
URL: https://issues.jboss.org/browse/WFCORE-1934
Project: WildFly Core
Issue Type: Bug
Components: Server
Affects Versions: 2.2.0.Final
Reporter: Masafumi Miura
Assignee: Jason Greene
Attachments: ServerServiceThreadPool_ejb_startup_singleton.zip, ServerServiceThreadPool_persistence_unit.zip
Provide a way to configure {{maximumPoolSize}} of {{ServerService Thread Pool}}. It defaults to {{Integer.MAX_VALUE}} and it's unable to be changed in the current implementation:
{quote}
https://github.com/wildfly/wildfly-core/blob/master/server/src/main/java/...
{code}
446 public synchronized void start(StartContext context) throws StartException {
447 executorService = new ThreadPoolExecutor(0, Integer.MAX_VALUE, 20L, TimeUnit.SECONDS,
448 new SynchronousQueue<Runnable>(), threadFactory);
449 }
{code}
{quote}
Though the threads will disappear after 20 seconds of finishing a task, ulimit ({{nproc}}, max user processes) has a possibility to run out depending on deployed applications. For example, an application coming with many {{<persistence-unit>}} entries in {{persistence.xml}} or a lot of @Startup @Singleton EJB can cause spawning a lot of {{ServerService Thread Pool}} thread.
Even if ulimit can be configurable and it is recommended to be tuned in a production environment, making {{maximumPoolSize}} of {{ServerService Thread Pool}} configurable would be helpful.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7437) Inconsistencies in otp-credential-mapper attribute of Elytron ldap-realm
by Ondrej Lukas (JIRA)
[ https://issues.jboss.org/browse/WFLY-7437?page=com.atlassian.jira.plugin.... ]
Ondrej Lukas commented on WFLY-7437:
------------------------------------
I think inconsistency here is between having required attributes in otp-credential-mapper object and allowing to use adding otp-credential-mapper without these required attributes.
Having ldap-realm without otp-credential-mapper is definitely ok, but adding otp-credential-mapper without required algorithm-from, hash-from, seed-from, sequence-from is wrong.
In other parts of Elytron subsystem someObjectAttribute={} does not mean undefined. Take a look at command:
{code}
/subsystem=elytron/properties-realm=realm:add(users-properties={path=$SOME_PATH},groups-properties={})
{
"outcome" => "failed",
"failure-description" => "WFLYCTL0155: path may not be null",
"rolled-back" => true
}
{code}
It validates whether required attribute {{path}} from groups-properties is set. IMHO it is correct behavior - it does not allow to use groups-properties without required attribute. Or is there any difference between otp-credential-mapper and groups-properties? I think it should be unified for whole subsystem.
> Inconsistencies in otp-credential-mapper attribute of Elytron ldap-realm
> ------------------------------------------------------------------------
>
> Key: WFLY-7437
> URL: https://issues.jboss.org/browse/WFLY-7437
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Priority: Minor
> Labels: user_experience
>
> Attribute {{identity-mapping.otp-credential-mapper}} from Elytron ldap-realm should include Object which should contain four required attributes - algorithm-from, hash-from, seed-from, sequence-from. All of these attributes are set as nillable=false.
> However CLI allows to run command where otp-credential-mapper attribute is added without any attributes which is inconsistent with their nillable=false. See following command:
> {code}
> /subsystem=elytron/ldap-realm=ldap-realm:add(dir-context=ldap,identity-mapping={rdn-identifier=uid,otp-credential-mapper={}})
> {code}
> Moreover, this command results to configuration xml without any otp-credential-mapper:
> {code}
> <ldap-realm name="ldap-realm" dir-context="ldap">
> <identity-mapping rdn-identifier="uid"/>
> </ldap-realm>
> {code}
> In case when at least one of otp-credential-mapper required attribute is added, then CLI command correctly fails:
> {code}
> /subsystem=elytron/ldap-realm=ldap-realm:add(dir-context=ldap,identity-mapping={rdn-identifier=uid,otp-credential-mapper={algorithm-from=atr}})
> {
> "outcome" => "failed",
> "failure-description" => "WFLYCTL0155: hash-from may not be null",
> "rolled-back" => true
> }
> {code}
> Suggestion:
> Do not allow to add {{identity-mapping.otp-credential-mapper}} without required attributes.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-7210) Expose JAX-RS resources as children of the subsystem
by Lin Gao (JIRA)
[ https://issues.jboss.org/browse/WFLY-7210?page=com.atlassian.jira.plugin.... ]
Lin Gao commented on WFLY-7210:
-------------------------------
PR for WFLY-7024 is up by adding child resource definition for each root REST resource(each class with @Path definition).
I think this issue can be resolved once the PR for WFLY-7024 is merged. :-)
PR: https://github.com/wildfly/wildfly/pull/9215
> Expose JAX-RS resources as children of the subsystem
> ----------------------------------------------------
>
> Key: WFLY-7210
> URL: https://issues.jboss.org/browse/WFLY-7210
> Project: WildFly
> Issue Type: Feature Request
> Components: REST
> Affects Versions: 10.1.0.Final
> Reporter: Guillermo González de Agüero
> Assignee: Lin Gao
> Attachments: hal-jaxrs.png
>
>
> Servlets, EJBs, WebSockets, JPA, etc expose its components as children of the subsystem in the management API. For example to list the stateless EJBs of a deployment:
> [standalone@localhost:9990 /] /deployment=cdivsejb.war/subsystem=ejb3:read-children-resources(child-type=stateless-session-bean)
> This makes it specially easy to navigate trough the web console (attached screenshot).
> To read JAX-RS resources, the command would be:
> [standalone@localhost:9990 /] /deployment=cdivsejb.war/subsystem=jaxrs:show-resources()
> I propose to make deprecate the show-resources operation and create a new "resources" child, containing the Rest resources.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFCORE-1932) Management model does not validate input values in interface section
by Chao Wang (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1932?page=com.atlassian.jira.plugi... ]
Chao Wang moved JBEAP-6880 to WFCORE-1932:
------------------------------------------
Project: WildFly Core (was: JBoss Enterprise Application Platform)
Key: WFCORE-1932 (was: JBEAP-6880)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: Domain Management
(was: Server)
(was: User Experience)
Affects Version/s: 3.0.0.Alpha11
(was: 7.1.0.DR7)
> Management model does not validate input values in interface section
> --------------------------------------------------------------------
>
> Key: WFCORE-1932
> URL: https://issues.jboss.org/browse/WFCORE-1932
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 3.0.0.Alpha11
> Reporter: Chao Wang
> Assignee: Chao Wang
> Priority: Minor
>
> Management model does not validate input values for attributes in {{/interface}} section.
> bq. Attribute indicating that part of the selection criteria for choosing an IP address for this interface should be whether or it the address fits in the given subnet definition. Value is a network IP address and the number of bits in the address' network prefix, written in "slash notation"; e.g. "192.168.0.0/16". An 'undefined' value means this attribute is not relevant to the IP address selection.
> In the description of {{subnet-match}} attribute it is clearly defined the format of input value. However the following command does not fail.
> {code}
> /interface=public:write-attribute(name=subnet-match,value="wrong-input")
> {
> "outcome" => "success",
> "response-headers" => {
> "operation-requires-reload" => true,
> "process-state" => "reload-required"
> }
> }
> {code}
> bq. Attribute indicating that part of the selection criteria for choosing an IP address for this interface should be whether or not the address matches the given value. Value is either an IP address in IPv6 or IPv4 dotted decimal notation, or a hostname that can be resolved to an IP address. An 'undefined' value means this attribute is not relevant to the IP address selection.
> There are also attributes which accept inet addresses - namely inet-address, loopback-address. Validation for these attributes is not performed either.
> {code}
> /interface=public:write-attribute(name=inet-address,value="wrong-input")
> {
> "outcome" => "success",
> "response-headers" => {
> "operation-requires-reload" => true,
> "process-state" => "reload-required"
> }
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFCORE-1931) Extra commas in descriptions of *-outbound-socket-binding CLI resources
by Chao Wang (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1931?page=com.atlassian.jira.plugi... ]
Chao Wang moved WFLY-7451 to WFCORE-1931:
-----------------------------------------
Project: WildFly Core (was: WildFly)
Key: WFCORE-1931 (was: WFLY-7451)
Component/s: Server
(was: Server)
Affects Version/s: 3.0.0.Alpha11
(was: 11.0.0.Alpha1)
> Extra commas in descriptions of *-outbound-socket-binding CLI resources
> -----------------------------------------------------------------------
>
> Key: WFCORE-1931
> URL: https://issues.jboss.org/browse/WFCORE-1931
> Project: WildFly Core
> Issue Type: Bug
> Components: Server
> Affects Versions: 3.0.0.Alpha11
> Reporter: Ondrej Kotek
> Assignee: Chao Wang
> Priority: Trivial
> Labels: user_experience
>
> There are extra commas in descriptions of children resources of _socket-binding-group_ CLI resource (_local-destination-outbound-socket-binding_ and _remote-destination-outbound-socket-binding_).
> E.g., there is "Configuration information for a, local destination, outbound socket binding.", there should be "Configuration information for a local destination outbound socket binding."
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months
[JBoss JIRA] (WFLY-2658) (-Djboss.dist) jboss.dist property is not correctly propagated using -Djboss.dist
by Eduardo Silva (JIRA)
[ https://issues.jboss.org/browse/WFLY-2658?page=com.atlassian.jira.plugin.... ]
Eduardo Silva commented on WFLY-2658:
-------------------------------------
Can this somewhat be related to https://issues.jboss.org/browse/WFLY-966?
> (-Djboss.dist) jboss.dist property is not correctly propagated using -Djboss.dist
> ---------------------------------------------------------------------------------
>
> Key: WFLY-2658
> URL: https://issues.jboss.org/browse/WFLY-2658
> Project: WildFly
> Issue Type: Bug
> Components: Test Suite
> Affects Versions: 8.0.0.Beta1
> Reporter: Ondrej Lukas
>
> This JIRA is clone of bz-970610 (https://bugzilla.redhat.com/show_bug.cgi?id=970610)
> When I run testsuite of EAP 6.1.0 using command [1], where JBOSS_HOME is a path EAP 6.1.0, the manualmode tests fail with error [2]:
> It uses path defined in jboss.dist property defined in testsuite/integration/pom.xml instead of the one provided -Djboss.dist which should redefine it.
> [1] ./integration-tests.sh -Dpublic-repos -DallTests -Dmaven.repo.local=${MAVEN_REPO_LOCAL} -Djboss.dist=${JBOSS_HOME} -Dmaven.test.failure.ignore=true -Dsurefire.forked.process.timeout=3600
> [2]
> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.7-redhat-1:run (build-manual-mode-servers) on project jboss-as-ts-integ-manualmode: An Ant BuildException has occured: The following error occurred while executing this line:
> [ERROR] /mnt/hudson_workspace/workspace/eap-60-as-testsuite-one-offs-rhatlapa/jboss-eap-6.1-src/testsuite/integration/src/test/scripts/manualmode-build.xml:52: /mnt/hudson_workspace/workspace/eap-60-as-testsuite-one-offs-rhatlapa/jboss-eap-6.1-src/build/target/jboss-as-7.2.0.Final-redhat-8/modules does not exist.
> [ERROR] around Ant part ...<ant antfile="/mnt/hudson_workspace/workspace/eap-60-as-testsuite-one-offs-rhatlapa/jboss-eap-6.1-src/testsuite/integration/manualmode/../src/test/scripts/manualmode-build.xml">... @ 4:180 in /mnt/hudson_workspace/workspace/eap-60-as-testsuite-one-offs-rhatlapa/jboss-eap-6.1-src/testsuite/integration/manualmode/target/antrun/build-main.xml
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 8 months