December 2016 - jboss-jira - Jboss List Archives

[JBoss JIRA] (WFLY-7832) Coverity: dereference null value in ClassLoadingAttributeDefinitions (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7832?page=com.atlassian.jira.plugin.... ] Ilia Vassilev updated WFLY-7832: -------------------------------- Component/s: Security > Coverity: dereference null value in ClassLoadingAttributeDefinitions (Elytron subsystem) > ---------------------------------------------------------------------------------------- > > Key: WFLY-7832 > URL: https://issues.jboss.org/browse/WFLY-7832 > Project: WildFly > Issue Type: Bug > Components: Security > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Labels: static_analysis > > Coverity static-analysis scan found a possilbe method call on null object in the {{ClassLoadingAttributeDefinitions.resolveClassLoader}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code > {code:java} > Module current = Module.getCallerModule(); > if (module != null) { > ModuleIdentifier mi = ModuleIdentifier.fromString(module); > current = current.getModule(mi); > {code} > The {{current}} value returned from {{Module.getCallerModule()}} may be {{null}}. The {{getModule()}} method is called on it without the null-check. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7831) Coverity: default platform encoding used in TokenRealmDefinition (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7831?page=com.atlassian.jira.plugin.... ] Ilia Vassilev updated WFLY-7831: -------------------------------- Component/s: Security > Coverity: default platform encoding used in TokenRealmDefinition (Elytron subsystem) > ------------------------------------------------------------------------------------ > > Key: WFLY-7831 > URL: https://issues.jboss.org/browse/WFLY-7831 > Project: WildFly > Issue Type: Bug > Components: Security > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Priority: Minor > Labels: static_analysis > > Coverity static-analysis scan found a String to byte conversion with default platform encoding in the {{TokenRealmDefinition.performRuntime}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code > {code:java} > jwtValidatorBuilder.publicKey(publicKey.getBytes()); > {code} > The encoding should be specified as argument. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7828) Coverity static analysis: Resource leaks in ProviderLoaderService (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7828?page=com.atlassian.jira.plugin.... ] Ilia Vassilev updated WFLY-7828: -------------------------------- Component/s: Security > Coverity static analysis: Resource leaks in ProviderLoaderService (Elytron subsystem) > ------------------------------------------------------------------------------------- > > Key: WFLY-7828 > URL: https://issues.jboss.org/browse/WFLY-7828 > Project: WildFly > Issue Type: Bug > Components: Security > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Priority: Critical > Labels: static_analysis > > Coverity static-analysis scan found 2 resource leaks in {{ProviderLoaderService}} class. > 1) > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code is used in `load` method: > {code:java} > if (provider == null) { > provider = providerClazz.newInstance(); > if (configurationStreamSupplier != null) { > try (InputStream is = configurationStreamSupplier.get()) { > provider.load(configurationStreamSupplier.get()); > } > } > } > {code} > The load method should use `is` instance instead of calling the supplier again. > 2) > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code is used in `toInputStream` method: > {code:java} > SecurityActions.doPrivileged((PrivilegedExceptionAction<InputStream>) () -> new FileInputStream(file) ); > return new FileInputStream(file); > {code} > There should be probably just: > {code:java} > return SecurityActions.doPrivileged((PrivilegedExceptionAction<InputStream>) () -> new FileInputStream(file) ); > {code} -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7833) Coverity: dereference null value in PermissionMapperDefinitions (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7833?page=com.atlassian.jira.plugin.... ] Ilia Vassilev updated WFLY-7833: -------------------------------- Component/s: Security > Coverity: dereference null value in PermissionMapperDefinitions (Elytron subsystem) > ----------------------------------------------------------------------------------- > > Key: WFLY-7833 > URL: https://issues.jboss.org/browse/WFLY-7833 > Project: WildFly > Issue Type: Bug > Components: Security > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Labels: static_analysis > > Coverity static-analysis scan found a possilbe method call on null object in the {{PermissionMapperDefinitions.createPermission}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > {code:java} > Module currentModule = Module.getCallerModule(); > if (permission.getModule() != null) { > ModuleIdentifier mi = ModuleIdentifier.fromString(permission.getModule()); > try { > currentModule = currentModule.getModule(mi); > {code} > The {{currentModule}} value returned from {{Module.getCallerModule()}} may be {{null}}. The {{getModule()}} method is called on it without the null-check. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1052) Remove @author tags from sources

by Michael Biarnes Kiefer (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1052?page=com.atlassian.jira.plugi... ] Michael Biarnes Kiefer commented on DROOLS-1052: ------------------------------------------------ [~psiroky] only for master or for other branches too ? > Remove @author tags from sources > -------------------------------- > > Key: DROOLS-1052 > URL: https://issues.jboss.org/browse/DROOLS-1052 > Project: Drools > Issue Type: Task > Reporter: Petr Široký > Assignee: Michael Biarnes Kiefer > > Some of our sources contain author Javadoc tags. As per our README ( https://github.com/droolsjbpm/droolsjbpm-build-bootstrap/blob/master/READ...) we should not using those as they promote code ownership and discourage team work. > We need to scan through the sources and remove those tags. > See https://github.com/droolsjbpm/jbpm/commit/ff5fd1ea464fe791933b9ea436cd2c4... for example of removing the tags from one of the jBPM modules. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (ELY-855) Add ability to merge AuthenticationConfigurations

by David Lloyd (JIRA)

David Lloyd created ELY-855: ------------------------------- Summary: Add ability to merge AuthenticationConfigurations Key: ELY-855 URL: https://issues.jboss.org/browse/ELY-855 Project: WildFly Elytron Issue Type: Task Components: Authentication Client Reporter: David Lloyd Priority: Critical We need a "with" method on AuthenticationConfiguration which appends one configuration to another. This allows for fallback defaults. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (DROOLS-1006) License header: replace Jboss Inc by Red Hat, Inc. and/or its affiliates.

by Michael Biarnes Kiefer (JIRA)

[ https://issues.jboss.org/browse/DROOLS-1006?page=com.atlassian.jira.plugi... ] Michael Biarnes Kiefer resolved DROOLS-1006. -------------------------------------------- Resolution: Done > License header: replace Jboss Inc by Red Hat, Inc. and/or its affiliates. > ------------------------------------------------------------------------- > > Key: DROOLS-1006 > URL: https://issues.jboss.org/browse/DROOLS-1006 > Project: Drools > Issue Type: Task > Affects Versions: 6.3.0.Final > Reporter: Geoffrey De Smet > Assignee: Michael Biarnes Kiefer > > All developers have been notified to change their header, so all new files will use the new header. > This jira is to fix the existing files. > 1) In java, drl, js and css files, replace in path this Case Sensitive Regular Expression in IntelliJ: > {code} > ^/\*\n \* Copyright (\d{4}) JBoss Inc\n > {code} > by with this > {code} > /*\n * Copyright $1 Red Hat, Inc. and/or its affiliates.\n > {code} > To understand the regex, read this: > https://docs.oracle.com/javase/7/docs/api/java/util/regex/Pattern.html > Commit that already before starting step 2. I even recommend doing a separate commit per file type. (But wait with pushing until all are fixed.) > 2) Then look for the string "JBoss Inc" in all files, case insensitive. Fix those too if applicable. Either by another smart regex find-replace or manually. > 3) Do step 1) and step 2) again for "JBoss by Red Hat." instead of "JBoss Inc" -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7833) Coverity: dereference null value in PermissionMapperDefinitions (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7833?page=com.atlassian.jira.plugin.... ] Ilia Vassilev moved ELY-846 to WFLY-7833: ----------------------------------------- Project: WildFly (was: WildFly Elytron) Key: WFLY-7833 (was: ELY-846) > Coverity: dereference null value in PermissionMapperDefinitions (Elytron subsystem) > ----------------------------------------------------------------------------------- > > Key: WFLY-7833 > URL: https://issues.jboss.org/browse/WFLY-7833 > Project: WildFly > Issue Type: Bug > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Labels: static_analysis > > Coverity static-analysis scan found a possilbe method call on null object in the {{PermissionMapperDefinitions.createPermission}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > {code:java} > Module currentModule = Module.getCallerModule(); > if (permission.getModule() != null) { > ModuleIdentifier mi = ModuleIdentifier.fromString(permission.getModule()); > try { > currentModule = currentModule.getModule(mi); > {code} > The {{currentModule}} value returned from {{Module.getCallerModule()}} may be {{null}}. The {{getModule()}} method is called on it without the null-check. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7832) Coverity: dereference null value in ClassLoadingAttributeDefinitions (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7832?page=com.atlassian.jira.plugin.... ] Ilia Vassilev moved ELY-845 to WFLY-7832: ----------------------------------------- Project: WildFly (was: WildFly Elytron) Key: WFLY-7832 (was: ELY-845) > Coverity: dereference null value in ClassLoadingAttributeDefinitions (Elytron subsystem) > ---------------------------------------------------------------------------------------- > > Key: WFLY-7832 > URL: https://issues.jboss.org/browse/WFLY-7832 > Project: WildFly > Issue Type: Bug > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Labels: static_analysis > > Coverity static-analysis scan found a possilbe method call on null object in the {{ClassLoadingAttributeDefinitions.resolveClassLoader}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code > {code:java} > Module current = Module.getCallerModule(); > if (module != null) { > ModuleIdentifier mi = ModuleIdentifier.fromString(module); > current = current.getModule(mi); > {code} > The {{current}} value returned from {{Module.getCallerModule()}} may be {{null}}. The {{getModule()}} method is called on it without the null-check. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

[JBoss JIRA] (WFLY-7831) Coverity: default platform encoding used in TokenRealmDefinition (Elytron subsystem)

by Ilia Vassilev (JIRA)

[ https://issues.jboss.org/browse/WFLY-7831?page=com.atlassian.jira.plugin.... ] Ilia Vassilev moved ELY-844 to WFLY-7831: ----------------------------------------- Project: WildFly (was: WildFly Elytron) Key: WFLY-7831 (was: ELY-844) > Coverity: default platform encoding used in TokenRealmDefinition (Elytron subsystem) > ------------------------------------------------------------------------------------ > > Key: WFLY-7831 > URL: https://issues.jboss.org/browse/WFLY-7831 > Project: WildFly > Issue Type: Bug > Reporter: Josef Cacek > Assignee: Ilia Vassilev > Priority: Minor > Labels: static_analysis > > Coverity static-analysis scan found a String to byte conversion with default platform encoding in the {{TokenRealmDefinition.performRuntime}} method. > https://scan7.coverity.com/reports.htm#v16159/p12663/fileInstanceId=68921... > Following code > {code:java} > jwtValidatorBuilder.publicKey(publicKey.getBytes()); > {code} > The encoding should be specified as argument. -- This message was sent by Atlassian JIRA (v7.2.3#72005)

7 years, 4 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

jboss-jira December 2016