[JBoss JIRA] (JASSIST-256) Javassist - add annotation to class doesn't work on reflections
by Shigeru Chiba (JIRA)
[ https://issues.jboss.org/browse/JASSIST-256?page=com.atlassian.jira.plugi... ]
Shigeru Chiba closed JASSIST-256.
---------------------------------
> Javassist - add annotation to class doesn't work on reflections
> ---------------------------------------------------------------
>
> Key: JASSIST-256
> URL: https://issues.jboss.org/browse/JASSIST-256
> Project: Javassist
> Issue Type: Bug
> Affects Versions: 3.20.0-GA
> Environment: JDK1.7, IDEA
> Reporter: Rui C.
> Assignee: Shigeru Chiba
> Priority: Minor
> Fix For: 3.21.0-GA
>
>
> {code:java}
> ClassPool pool = ClassPool.getDefault();
> CtClass superclass = pool.getCtClass(AbstractEntity.class.getName());
> CtClass cc = pool.makeClass("com.rapid.develop.entity.Ponit", superclass);
> ClassFile ccFile = cc.getClassFile();
> ConstPool constpool = ccFile.getConstPool();
> AnnotationsAttribute attr = new AnnotationsAttribute(constpool, AnnotationsAttribute.visibleTag);
> Annotation entityAnno = new Annotation("Entity", constpool);
> Annotation tableAnno = new Annotation("Table", constpool);
> tableAnno.addMemberValue("name", new StringMemberValue("test", ccFile.getConstPool()));
> attr.addAnnotation(entityAnno);
> attr.addAnnotation(tableAnno);
> ccFile.addAttribute(attr);
> Class clazz = cc.toClass();
> Object o = clazz.newInstance();
> assertTrue(o.getClass().getName().equals("com.rapid.develop.entity.Ponit"));
> // annotations length = zero
> java.lang.annotation.Annotation[] annotations = clazz.getDeclaredAnnotations();
> assertEquals(2, annotations.length);
> {code}
> I used javassist to add annotation for class， I saw these annotations were added to class file.
> But I can't get them using java API clazz.getDeclaredAnnotations() and clazz.getAnnotations()
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JASSIST-256) Javassist - add annotation to class doesn't work on reflections
by Shigeru Chiba (JIRA)
[ https://issues.jboss.org/browse/JASSIST-256?page=com.atlassian.jira.plugi... ]
Shigeru Chiba resolved JASSIST-256.
-----------------------------------
Fix Version/s: 3.21.0-GA
Resolution: Done
No, the problem is that "Entity" is not a fully-qualified class name.
{code:java}
Annotation entityAnno = new Annotation("Entity", constpool);
{code}
I've fixed a problem of ArrayMemberValue.
> Javassist - add annotation to class doesn't work on reflections
> ---------------------------------------------------------------
>
> Key: JASSIST-256
> URL: https://issues.jboss.org/browse/JASSIST-256
> Project: Javassist
> Issue Type: Bug
> Affects Versions: 3.20.0-GA
> Environment: JDK1.7, IDEA
> Reporter: Rui C.
> Assignee: Shigeru Chiba
> Priority: Minor
> Fix For: 3.21.0-GA
>
>
> {code:java}
> ClassPool pool = ClassPool.getDefault();
> CtClass superclass = pool.getCtClass(AbstractEntity.class.getName());
> CtClass cc = pool.makeClass("com.rapid.develop.entity.Ponit", superclass);
> ClassFile ccFile = cc.getClassFile();
> ConstPool constpool = ccFile.getConstPool();
> AnnotationsAttribute attr = new AnnotationsAttribute(constpool, AnnotationsAttribute.visibleTag);
> Annotation entityAnno = new Annotation("Entity", constpool);
> Annotation tableAnno = new Annotation("Table", constpool);
> tableAnno.addMemberValue("name", new StringMemberValue("test", ccFile.getConstPool()));
> attr.addAnnotation(entityAnno);
> attr.addAnnotation(tableAnno);
> ccFile.addAttribute(attr);
> Class clazz = cc.toClass();
> Object o = clazz.newInstance();
> assertTrue(o.getClass().getName().equals("com.rapid.develop.entity.Ponit"));
> // annotations length = zero
> java.lang.annotation.Annotation[] annotations = clazz.getDeclaredAnnotations();
> assertEquals(2, annotations.length);
> {code}
> I used javassist to add annotation for class， I saw these annotations were added to class file.
> But I can't get them using java API clazz.getDeclaredAnnotations() and clazz.getAnnotations()
>
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JGRP-1620) RpcDispatcher/MessageDispatcher changes
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1620?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1620:
---------------------------
Description:
* In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
* Sync and async calls
** If a unicast call is async, return null immediately after sending it
*** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
* If a multicast call is async, return null immediately (instead of an {{RspList}})
*** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
* Investigate whether non-blocking RPCs need to create Request instances at all
** This prevents creation and population of the hashmap (for {{GroupRequest}})
** Async requests could be dispatched to {{RequestCorrelator}} directly
* Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
* Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
was:
* In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
* Sync and async calls
** If a unicast call is async, return null immediately after sending it
*** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
* If a multicast call is async, return null immediately (instead of an {{RspList}})
*** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
* Investigate whether non-blocking RPCs need to create Request instances at all
* Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
* Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
> RpcDispatcher/MessageDispatcher changes
> ---------------------------------------
>
> Key: JGRP-1620
> URL: https://issues.jboss.org/browse/JGRP-1620
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0
>
>
> * In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
> ** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
> * Sync and async calls
> ** If a unicast call is async, return null immediately after sending it
> *** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
> * If a multicast call is async, return null immediately (instead of an {{RspList}})
> *** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
> * Investigate whether non-blocking RPCs need to create Request instances at all
> ** This prevents creation and population of the hashmap (for {{GroupRequest}})
> ** Async requests could be dispatched to {{RequestCorrelator}} directly
> * Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
> * Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
> ** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFLY-6179) X: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@Y rejected from java.util.concurrent.ThreadPoolExecutor@Z
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-6179?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-6179:
---------------------------------
Priority: Minor (was: Major)
> X: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@Y rejected from java.util.concurrent.ThreadPoolExecutor@Z
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-6179
> URL: https://issues.jboss.org/browse/WFLY-6179
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Priority: Minor
>
> As seen in QE jobs by [~mvinkler]:
> {noformat}
> [JBossINF] [0m[31m00:03:59,091 ERROR [org.jgroups.protocols.UDP] (unicast receiver,ee,perf20) perf20: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@cf4fccc rejected from java.util.concurrent.ThreadPoolExecutor@122a91ad[Running, pool size = 300, active threads = 3, queued tasks = 0, completed tasks = 57909800]. Msg: RequestCorrelator: id=200, type=REQ, id=39088476, rsp_expected=true, FORK: ee:web, UNICAST3: DATA, seqno=21476211, conn_id=2, UDP: [cluster_name=ee]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JGRP-2015) DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/JGRP-2015?page=com.atlassian.jira.plugin.... ]
Radoslav Husar commented on JGRP-2015:
--------------------------------------
I didn't use the right word, I just meant a lot of logging. The logs in QE labs that are normally less than 100MB got to serveral GBs in size (1 log message per rejection).
> DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions
> --------------------------------------------------------------------------------------
>
> Key: JGRP-2015
> URL: https://issues.jboss.org/browse/JGRP-2015
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 3.6.7
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 3.6.8, 4.0
>
>
> It seems to me there are few issues in the new DONT_BUNDLE+OOB processing:
> * messages are not removed from batch when execution fails
> * rejections are not counted to num_rejected_msgs
> * lot of logging per message overfills the log
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JGRP-1620) RpcDispatcher/MessageDispatcher changes
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1620?page=com.atlassian.jira.plugin.... ]
Bela Ban updated JGRP-1620:
---------------------------
Description:
* In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
* Sync and async calls
** If a unicast call is async, return null immediately after sending it
*** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
* If a multicast call is async, return null immediately (instead of an {{RspList}})
*** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
* Investigate whether non-blocking RPCs need to create Request instances at all
* Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
* Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
was:
* In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
* Return null from castMessage() if the call is async, instead of a null {{RspList}}
* Investigate whether non-blocking RPCs need to create Request instances at all
* Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
* Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
> RpcDispatcher/MessageDispatcher changes
> ---------------------------------------
>
> Key: JGRP-1620
> URL: https://issues.jboss.org/browse/JGRP-1620
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0
>
>
> * In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
> ** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
> * Sync and async calls
> ** If a unicast call is async, return null immediately after sending it
> *** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
> * If a multicast call is async, return null immediately (instead of an {{RspList}})
> *** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
> * Investigate whether non-blocking RPCs need to create Request instances at all
> * Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
> * Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
> ** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JGRP-2015) DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/JGRP-2015?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated JGRP-2015:
---------------------------------
Description:
It seems to me there are few issues in the new DONT_BUNDLE+OOB processing:
* messages are not removed from batch when execution fails
* rejections are not counted to num_rejected_msgs
* lot of logging per message overfills the log
was:
It seems to me there are few issues in the new DONT_BUNDLE+OOB processing:
* messages are not removed from batch when execution fails
* rejections are not counted to num_rejected_msgs
* spurious logging per message overfills the log
> DONT_BUNDLE+OOB processing: spurious logging, uncounted rejections, retried executions
> --------------------------------------------------------------------------------------
>
> Key: JGRP-2015
> URL: https://issues.jboss.org/browse/JGRP-2015
> Project: JGroups
> Issue Type: Bug
> Affects Versions: 3.6.7
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
> Fix For: 3.6.8, 4.0
>
>
> It seems to me there are few issues in the new DONT_BUNDLE+OOB processing:
> * messages are not removed from batch when execution fails
> * rejections are not counted to num_rejected_msgs
> * lot of logging per message overfills the log
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFLY-6179) X: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@Y rejected from java.util.concurrent.ThreadPoolExecutor@Z
by Radoslav Husar (JIRA)
[ https://issues.jboss.org/browse/WFLY-6179?page=com.atlassian.jira.plugin.... ]
Radoslav Husar updated WFLY-6179:
---------------------------------
Description:
As seen in QE jobs by [~mvinkler]:
{noformat}
[JBossINF] [0m[31m00:03:59,091 ERROR [org.jgroups.protocols.UDP] (unicast receiver,ee,perf20) perf20: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@cf4fccc rejected from java.util.concurrent.ThreadPoolExecutor@122a91ad[Running, pool size = 300, active threads = 3, queued tasks = 0, completed tasks = 57909800]. Msg: RequestCorrelator: id=200, type=REQ, id=39088476, rsp_expected=true, FORK: ee:web, UNICAST3: DATA, seqno=21476211, conn_id=2, UDP: [cluster_name=ee]
{noformat}
was:
[JBossINF] [0m[31m00:03:59,091 ERROR [org.jgroups.protocols.UDP] (unicast receiver,ee,perf20) perf20: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@cf4fccc rejected from java.util.concurrent.ThreadPoolExecutor@122a91ad[Running, pool size = 300, active threads = 3, queued tasks = 0, completed tasks = 57909800]. Msg: RequestCorrelator: id=200, type=REQ, id=39088476, rsp_expected=true, FORK: ee:web, UNICAST3: DATA, seqno=21476211, conn_id=2, UDP: [cluster_name=ee]
> X: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@Y rejected from java.util.concurrent.ThreadPoolExecutor@Z
> ----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-6179
> URL: https://issues.jboss.org/browse/WFLY-6179
> Project: WildFly
> Issue Type: Bug
> Components: Clustering
> Reporter: Radoslav Husar
> Assignee: Radoslav Husar
>
> As seen in QE jobs by [~mvinkler]:
> {noformat}
> [JBossINF] [0m[31m00:03:59,091 ERROR [org.jgroups.protocols.UDP] (unicast receiver,ee,perf20) perf20: failed submitting DONT_BUNDLE message to thread pool: java.util.concurrent.RejectedExecutionException: Task org.jgroups.protocols.TP$SingleMessageHandler@cf4fccc rejected from java.util.concurrent.ThreadPoolExecutor@122a91ad[Running, pool size = 300, active threads = 3, queued tasks = 0, completed tasks = 57909800]. Msg: RequestCorrelator: id=200, type=REQ, id=39088476, rsp_expected=true, FORK: ee:web, UNICAST3: DATA, seqno=21476211, conn_id=2, UDP: [cluster_name=ee]
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFLY-6181) Upgrade JGroups to 3.6.8.Final
by Radoslav Husar (JIRA)
Radoslav Husar created WFLY-6181:
------------------------------------
Summary: Upgrade JGroups to 3.6.8.Final
Key: WFLY-6181
URL: https://issues.jboss.org/browse/WFLY-6181
Project: WildFly
Issue Type: Component Upgrade
Components: Clustering
Affects Versions: 10.0.0.Final
Reporter: Radoslav Husar
Assignee: Paul Ferraro
Tracking Jira for fixes in JGroups.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months