[JBoss JIRA] (ELY-425) HTTP Authentication Mechanism Backwards Compatibility
by Darran Lofthouse (JIRA)
Darran Lofthouse created ELY-425:
------------------------------------
Summary: HTTP Authentication Mechanism Backwards Compatibility
Key: ELY-425
URL: https://issues.jboss.org/browse/ELY-425
Project: WildFly Elytron
Issue Type: Task
Components: HTTP
Reporter: Darran Lofthouse
Fix For: 1.1.0.CR1
A number of fixes have been applied to authentication mechanisms within Undertow, we need to review the commit history within Undertow and ensure the same fixes are applied to the mechanisms within Elytron so that those migrating are not hit by previously encountered and fixed issues.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFCORE-1399) Failure when resolving an expression with the default value containing a '$' at the end
by Valentin Maechler (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1399?page=com.atlassian.jira.plugi... ]
Valentin Maechler edited comment on WFCORE-1399 at 2/22/16 3:38 AM:
--------------------------------------------------------------------
Good day!
I've tried to escape the {{'$'}} with a leading {{'$'}} ==> test cases do not work as expected.
Let's say we have a default value {{'a$'}}.
And the system property is called {{'z'}}.
The expression is then {code}'${z:a$$}'{code} including the escaping {{'$'}}.
Expectation:
# if the system property {{'z'}} is set to {{'system-prop-value'}} the resulting value shall be {{'system-prop-value'}} (/)
# if the system property {{'z'}} is *NOT* set the resulting value shall be {{'a$'}} (x)
The 1st case works fine (/) *but* the result of the 2nd case is {{'a$$'}} (x).
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
was (Author: vmae):
Good day!
I've tried to escape the {{'$'}} with a leading {{'$'}} ==> test cases do not work as expected.
Let's say we have a default value {{'a$'}}.
And the system property is called {{'z'}}.
The expression is then {code}'${z:a$$}'{code} including the escaping {{'$'}}.
Expectation:
# if the system property {{'z'}} is set to {{'system-prop-value'}} the resulting value shall be {{'system-prop-value'}} (/)
# if the system property {{'z'}} is *NOT* set the resulting value shall be {{'a$'}} (x)
The 1st case works fine but the result of the 2nd case is {{'a$$'}}.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
> Failure when resolving an expression with the default value containing a '$' at the end
> ---------------------------------------------------------------------------------------
>
> Key: WFCORE-1399
> URL: https://issues.jboss.org/browse/WFCORE-1399
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.1.0.CR1
> Reporter: Valentin Maechler
> Assignee: ehsavoie Hugonnet
> Attachments: ExpressionResolver.java, ExpressionResolverUnitTestCase.java
>
>
> Can not add a JNDI / naming entry which contains a "$" sign at the end of its default value.
> e.g. {code}
> value="${my.sample.property1:entry5-default-value-with-special-char-at-the-end-$}"
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (JGRP-1620) RpcDispatcher/MessageDispatcher changes
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-1620?page=com.atlassian.jira.plugin.... ]
Bela Ban resolved JGRP-1620.
----------------------------
Resolution: Done
> RpcDispatcher/MessageDispatcher changes
> ---------------------------------------
>
> Key: JGRP-1620
> URL: https://issues.jboss.org/browse/JGRP-1620
> Project: JGroups
> Issue Type: Feature Request
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 4.0
>
>
> * In MessageDispatcher.castMessageXXX() and send(), we pass a Message as argument. Change this to only ship the byte[] buffer and options.
> ** This prevents a unicast RPC from having a message with a null dest, or a multicast RPC having a message with a non-null dest (JGRP-1617).
> * Sync and async calls
> ** If a unicast call is async, return null immediately after sending it
> *** In case of a callWithFuture() -> return a null future as well (not a {{NullFuture}}!)
> * If a multicast call is async, return null immediately (instead of an {{RspList}})
> *** In case of a callWithFuture -> return a null future (instead of a {{nullFuture}})
> * Investigate whether non-blocking RPCs need to create Request instances at all
> ** This prevents creation and population of the hashmap (for {{GroupRequest}})
> ** Async requests could be dispatched to {{RequestCorrelator}} directly
> * Return a {{CompletableFuture}} instead of a {{NotifyingFuture}}
> * Remove {{NotifyingFuture}} and {{FutureListener}}: requires changing {{ExecutionService}}
> ** Perhaps: https://github.com/wburns/infinispan/blob/ISPN-6074/core/src/main/java/or...
> * Replaced {{org.jgroups.TimeoutException}} with {{java.util.concurrent.TimeoutException}}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFCORE-1399) Failure when resolving an expression with the default value containing a '$' at the end
by Valentin Maechler (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1399?page=com.atlassian.jira.plugi... ]
Valentin Maechler edited comment on WFCORE-1399 at 2/22/16 2:57 AM:
--------------------------------------------------------------------
Good day!
I've tried to escape the {{'$'}} with a leading {{'$'}} ==> test cases do not work as expected.
Let's say we have a default value {{'a$'}}.
And the system property is called {{'z'}}.
The expression is then {code}'${z:a$$}'{code} including the escaping {{'$'}}.
Expectation:
# if the system property {{'z'}} is set to {{'system-prop-value'}} the resulting value shall be {{'system-prop-value'}} (/)
# if the system property {{'z'}} is *NOT* set the resulting value shall be {{'a$'}} (x)
The 1st case works fine but the result of the 2nd case is {{'a$$'}}.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
was (Author: vmae):
Good day!
I've tried to escape the {{'$'}} with a leading {{'$'}} ==> test cases do not work as expected.
Let's say we have a default value {{'a$'}}.
And the system property is called {{'z'}}.
The expression is then {{'${z:a$$}'}} including the escaping {{'$'}}.
Expectation:
# if the system property {{'z'}} is set to {{'system-prop-value'}} the resulting value shall be {{'system-prop-value'}} (/)
# if the system property {{'z'}} is *NOT* set the resulting value shall be {{'a$'}} (x)
The 1st case works fine but the result of the 2nd case is {{'a$$'}}.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
> Failure when resolving an expression with the default value containing a '$' at the end
> ---------------------------------------------------------------------------------------
>
> Key: WFCORE-1399
> URL: https://issues.jboss.org/browse/WFCORE-1399
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.1.0.CR1
> Reporter: Valentin Maechler
> Assignee: ehsavoie Hugonnet
> Attachments: ExpressionResolver.java, ExpressionResolverUnitTestCase.java
>
>
> Can not add a JNDI / naming entry which contains a "$" sign at the end of its default value.
> e.g. {code}
> value="${my.sample.property1:entry5-default-value-with-special-char-at-the-end-$}"
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFCORE-1399) Failure when resolving an expression with the default value containing a '$' at the end
by Valentin Maechler (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1399?page=com.atlassian.jira.plugi... ]
Valentin Maechler edited comment on WFCORE-1399 at 2/22/16 2:57 AM:
--------------------------------------------------------------------
Good day!
I've tried to escape the {{'$'}} with a leading {{'$'}} ==> test cases do not work as expected.
Let's say we have a default value {{'a$'}}.
And the system property is called {{'z'}}.
The expression is then {{'${z:a$$}'}} including the escaping {{'$'}}.
Expectation:
# if the system property {{'z'}} is set to {{'system-prop-value'}} the resulting value shall be {{'system-prop-value'}} (/)
# if the system property {{'z'}} is *NOT* set the resulting value shall be {{'a$'}} (x)
The 1st case works fine but the result of the 2nd case is {{'a$$'}}.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
was (Author: vmae):
Good day!
I've tried to escape the '$' with a leading '$' ==> test cases do not work as expected.
Let's say we have a default value 'a$'.
And the system property is called 'z'.
The expression is then '${z:a$$}' including the escaping '$'.
Expectation:
# if the system property 'z' is set to 'system-prop-value' the resulting value shall be 'system-prop-value' (/)
# if the system property 'z' is *NOT* set the resulting value shall be 'a$' (x)
The 1st case works fine but the result of the 2nd case is 'a$$'.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
> Failure when resolving an expression with the default value containing a '$' at the end
> ---------------------------------------------------------------------------------------
>
> Key: WFCORE-1399
> URL: https://issues.jboss.org/browse/WFCORE-1399
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.1.0.CR1
> Reporter: Valentin Maechler
> Assignee: ehsavoie Hugonnet
> Attachments: ExpressionResolver.java, ExpressionResolverUnitTestCase.java
>
>
> Can not add a JNDI / naming entry which contains a "$" sign at the end of its default value.
> e.g. {code}
> value="${my.sample.property1:entry5-default-value-with-special-char-at-the-end-$}"
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFCORE-1399) Failure when resolving an expression with the default value containing a '$' at the end
by Valentin Maechler (JIRA)
[ https://issues.jboss.org/browse/WFCORE-1399?page=com.atlassian.jira.plugi... ]
Valentin Maechler commented on WFCORE-1399:
-------------------------------------------
Good day!
I've tried to escape the '$' with a leading '$' ==> test cases do not work as expected.
Let's say we have a default value 'a$'.
And the system property is called 'z'.
The expression is then '${z:a$$}' including the escaping '$'.
Expectation:
# if the system property 'z' is set to 'system-prop-value' the resulting value shall be 'system-prop-value' (/)
# if the system property 'z' is *NOT* set the resulting value shall be 'a$' (x)
The 1st case works fine but the result of the 2nd case is 'a$$'.
test cases added to ExpressionResolverUnitTestCase.java
{code}
@Test
public void testSpecialDefaultValueWithSystemPropertySet() throws OperationFailedException {
System.setProperty("z", "system-prop-value");
try {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
assertEquals("system-prop-value", node.get("expr").asString());
} finally {
System.clearProperty("z");
}
}
@Test
public void testSpecialDefaultValueWithoutSystemPropertySet() throws OperationFailedException {
ModelNode node = new ModelNode();
node.get("expr").set(new ValueExpression("${z:a$$}"));
node = ExpressionResolver.TEST_RESOLVER.resolveExpressions(node);
assertEquals(1, node.keys().size());
System.out.println("testSpecialDefaultValueWithoutSystemPropertySet: " + node.get("expr").asString());
assertEquals("a$", node.get("expr").asString());
}
{code}
> Failure when resolving an expression with the default value containing a '$' at the end
> ---------------------------------------------------------------------------------------
>
> Key: WFCORE-1399
> URL: https://issues.jboss.org/browse/WFCORE-1399
> Project: WildFly Core
> Issue Type: Bug
> Components: Domain Management
> Affects Versions: 2.1.0.CR1
> Reporter: Valentin Maechler
> Assignee: ehsavoie Hugonnet
> Attachments: ExpressionResolver.java, ExpressionResolverUnitTestCase.java
>
>
> Can not add a JNDI / naming entry which contains a "$" sign at the end of its default value.
> e.g. {code}
> value="${my.sample.property1:entry5-default-value-with-special-char-at-the-end-$}"
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months
[JBoss JIRA] (WFLY-6198) When a datasource has no connection-properties and its driver has defined datasource-class a warning should be issued
by ehsavoie Hugonnet (JIRA)
[ https://issues.jboss.org/browse/WFLY-6198?page=com.atlassian.jira.plugin.... ]
ehsavoie Hugonnet updated WFLY-6198:
------------------------------------
Summary: When a datasource has no connection-properties and its driver has defined datasource-class a warning should be issued (was: When a datasource has no connection-properties and its driver has defined datasource-class is defined and no connections-properties a warning should be issued)
> When a datasource has no connection-properties and its driver has defined datasource-class a warning should be issued
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: WFLY-6198
> URL: https://issues.jboss.org/browse/WFLY-6198
> Project: WildFly
> Issue Type: Enhancement
> Components: JCA
> Affects Versions: 10.0.0.Final
> Reporter: ehsavoie Hugonnet
> Assignee: ehsavoie Hugonnet
>
> If a datasource-class is defined then it takes precedence to create the datasource and as such it can only use connection-properties.
> Since there is not a single connection-url property for all drivers, you have to use connection-properties if you are defining the datasource-class.
> A warning when the datasource-class is defined but no connection-properties are present should be issued.
--
This message was sent by Atlassian JIRA
(v6.4.11#64026)
10 years, 2 months