[JBoss JIRA] (DROOLS-1399) Comparison of DRL changes should not consider spaces during incremental compilation
by Matteo Mortari (JIRA)
Matteo Mortari created DROOLS-1399:
--------------------------------------
Summary: Comparison of DRL changes should not consider spaces during incremental compilation
Key: DROOLS-1399
URL: https://issues.jboss.org/browse/DROOLS-1399
Project: Drools
Issue Type: Bug
Components: core engine
Affects Versions: 7.0.0.Beta5
Reporter: Matteo Mortari
Assignee: Matteo Mortari
Priority: Minor
During incremental compilation the equivalent DRL file contains only a modification with a new space character in a non-rule, non-resource line. Currently, this triggers the incremental compilation to rebuild all the resources associated in that DRL file anyway. Consequently, a rule in that DRL file might be actually UNchanged; but following the explanation above, it will match and fire again, like it's a new/modified rule.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (JGRP-2136) Merge installs the same view
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2136?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2136:
--------------------------------
Hmm, simply checking if a new merge view has the same members as the current view doesn't work, as it would break the scenario tested in MergeTest5:
{noformat}
A: [B|5] (3) [B, A, C]
B: [C|5] (3) [C, A, B]
C: [A|2] (3) [A, B, C]
{noformat}
Here, the new merge view has the same members as the existing view *but in different order*. Perhaps we need to check if we have the same members *and the same order*?
> Merge installs the same view
> ----------------------------
>
> Key: JGRP-2136
> URL: https://issues.jboss.org/browse/JGRP-2136
> Project: JGroups
> Issue Type: Bug
> Reporter: Bela Ban
> Assignee: Bela Ban
> Fix For: 3.6.12, 4.0
>
>
> The cluster is A,B with AUTH and ASYM_ENCRYPT. When a rogue member C (whith an incorrect auth_value in AUTH) attempts to join, it will be rejected by AUTH. However, while the subsequent merge attempts also fail (as designed), this leads to spurious MergeView installations in A and B, e.g.:
> {noformat}
> ** View=[belasmac-17416|1] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|2] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|1] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|3] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|2] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|4] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|3] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|5] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|4] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|6] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|5] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|7] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|6] (2) [belasmac-17416, belasmac-56188]
> ** MergeView::[belasmac-17416|8] (2) [belasmac-17416, belasmac-56188], 1 subgroups: [belasmac-17416|7] (2) [belasmac-17416, belasmac-56188]
> {noformat}
> This neither corrupts security of the system (the rogue member cannot merge-join) nor correctness, but we need to prevent the spurious views. Systems like Infinispan might start a rebalance on a view, regardless of whether they are the same as before or not.
> SOLUTION: the merge leader needs to see if the MergeView it is about to send out is the same as the current view, and simply drop it if that's the case.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (WFLY-7844) Elytron dir-context supports only plaintext password
by Jan Kalina (JIRA)
[ https://issues.jboss.org/browse/WFLY-7844?page=com.atlassian.jira.plugin.... ]
Jan Kalina reassigned WFLY-7844:
--------------------------------
Assignee: Jan Kalina (was: Darran Lofthouse)
> Elytron dir-context supports only plaintext password
> ----------------------------------------------------
>
> Key: WFLY-7844
> URL: https://issues.jboss.org/browse/WFLY-7844
> Project: WildFly
> Issue Type: Bug
> Components: Security
> Affects Versions: 11.0.0.Alpha1
> Reporter: Ondrej Lukas
> Assignee: Jan Kalina
> Priority: Blocker
>
> Only plaintext password is currently able to be configured in Elytron dir-context resource. Any integration with Credential store is missing.
> We request blocker since it seems that there is currently no option how to provide non-plaintext password for dir-context to server configuration.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1107) Upgrade to JPA 2.1 and Hibernate 5
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1107?page=com.atlassian.jira.plugi... ]
Petr Široký resolved DROOLS-1107.
---------------------------------
Fix Version/s: 7.0.0.CR1
Resolution: Done
> Upgrade to JPA 2.1 and Hibernate 5
> ----------------------------------
>
> Key: DROOLS-1107
> URL: https://issues.jboss.org/browse/DROOLS-1107
> Project: Drools
> Issue Type: Enhancement
> Reporter: Petar Tahchiev
> Assignee: Petr Široký
> Fix For: 7.0.0.CR1
>
>
> Hello,
> my app is running with Hibernate5 and JPA2.1 and when I try to use latest {{drools-persistence-jpa}} I get this exception:
> {code}
> Caused by: java.lang.NoSuchMethodError: javax.persistence.CollectionTable.indexes()[Ljavax/persistence/Index;
> at org.hibernate.cfg.AnnotationBinder.bindJoinedTableAssociation(AnnotationBinder.java:2378)
> at org.hibernate.cfg.AnnotationBinder.processElementAnnotations(AnnotationBinder.java:2094)
> at org.hibernate.cfg.AnnotationBinder.processIdPropertiesIfNotAlready(AnnotationBinder.java:906)
> at org.hibernate.cfg.AnnotationBinder.bindClass(AnnotationBinder.java:733)
> {code}
> Hibernate5 is already stable. Please update to it.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1397) Drools condition cannot retrieve object from Map with Enum key
by Mario Fusco (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1397?page=com.atlassian.jira.plugi... ]
Mario Fusco commented on DROOLS-1397:
-------------------------------------
I already saw the question on StackOverflow and reproduced the problem locally. Actually the bug is in mvel (that is used internally by drools to parse this sort of expressions) so it needs to be fixed there. While investigating this issue I also noticed the following:
1. The cast in the from expression is not necessary and just adding the parenthesis as it follows is enough to workaround the problem
{code}
$comm: Comm() from ($conv.getComms()).get(Type.AAA)
{code}
2. Having noticed 1. another trivial way to workaround this issue is moving the map declaration inside the former pattern like in
{code}
$conv: Convention( $comms : comms )
$comm: Comm() from $comms.get(Type.AAA)
{code}
Please let me know if both 1. and 2. also works for you.
> Drools condition cannot retrieve object from Map with Enum key
> --------------------------------------------------------------
>
> Key: DROOLS-1397
> URL: https://issues.jboss.org/browse/DROOLS-1397
> Project: Drools
> Issue Type: Bug
> Components: core engine, decision tables
> Affects Versions: 6.5.0.Final
> Environment: JDK 1.7, JUnit test, exact drools version is 6.5.0.Final-redhat-2
> Reporter: Patrick Mingard
> Assignee: Mario Fusco
> Priority: Minor
>
> I'm migrating an application that used drools 5.3 on the newer drools 6.5 version.
> I'm using a decision table, And one of my condition is accessing a Map which has an enum class as a key. It is not compiling unless I do a strange ArrayList cast.
> Please refer to [this stackoverflow topic|http://stackoverflow.com/questions/41461468/drools-condition-cannot...] for details.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1398) Use Maven for compiling the workbench projects
by Toni Rikkola (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1398?page=com.atlassian.jira.plugi... ]
Toni Rikkola commented on DROOLS-1398:
--------------------------------------
Back to Drools and Mario. Had a quick chat with mfusco and mmortari. Could be that this is impossible ;)
> Use Maven for compiling the workbench projects
> ----------------------------------------------
>
> Key: DROOLS-1398
> URL: https://issues.jboss.org/browse/DROOLS-1398
> Project: Drools
> Issue Type: Feature Request
> Reporter: Toni Rikkola
> Assignee: Mario Fusco
>
> We currently use the kie-maven-plugin internally to compile the kjar's and only use Maven to provide the information about parent projects and dependencies for the project.
> Yet we have the power of Maven underneath and we do not use it. It is impossible to use simple features like ignoring folders or moving code. Or more complicated, for example if you have your own rule asset format and need a Maven plugin to generate the DRL out of it.
> However it is possible to set this functionality up. This causes problems:
> * Same git tag built in the workbench produce different results depending on the Workbench version that is being used. This means that if you want to rebuild a lost kjar, you need to install the same workbench version that was originally used to create the first one
> * Projects build in command line/build server can produce different kjars than the ones built with the workbench
> Benefits we gain for going full Maven:
> * Build the same artifacts anywhere
> * Make Maven build cycle usable
> * Make Maven plugins usable
> * Run tests with any test tooling, users are not limited to Test Scenarios
> What to keep in mind:
> * If we let the user set the KIE version for the kie-maven-plugin. The internal compiler still uses the version the workbench has.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1397) Drools condition cannot retrieve object from Map with Enum key
by Patrick Mingard (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1397?page=com.atlassian.jira.plugi... ]
Patrick Mingard updated DROOLS-1397:
------------------------------------
Steps to Reproduce:
A fact :
{{ public class Convention {
[...]
private Map<ECommissionType, List<Commission>> commissions = new HashMap<>();
[...]
}}}
An enumeration :
{{ public enum ECommissionType {
ACQ,RIS,POF,[...]
}}}
And a rule condition assuming $convention is properly initialized in a former condition and is an instance of the Convention class shown) :
$comm : Commission() from $convention.getCommissions().get(ECommissionType.$1)
Compilation using kie-maven-plugin is raising an error :
Unable to Analyse Expression $convention.getCommissions().get(ECommissionType.RIS)):
sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl cannot be cast to java.lang.Class : [Rule name='B_CommissionLigne_98']
(I'm sorry I'm completely unable to format correctly the code extracts on this site... more readable on stackoverflow)
was:
A fact :
{{ public class Convention {
[...]
private Map<ECommissionType, List<Commission>> commissions = new HashMap<>();
[...]
}}}
An enumeration :
{{ public enum ECommissionType {
ACQ,RIS,POF,[...]
}}}
And a rule condition assuming $convention is properly initialized in a former condition and is an instance of the Convention class shown) :
$comm : Commission() from $convention.getCommissions().get(ECommissionType.$1)
Compilation using kie-maven-plugin is raising an error :
Unable to Analyse Expression $convention.getCommissions().get(ECommissionType.RIS)):
sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl cannot be cast to java.lang.Class : [Rule name='B_CommissionLigne_98']
> Drools condition cannot retrieve object from Map with Enum key
> --------------------------------------------------------------
>
> Key: DROOLS-1397
> URL: https://issues.jboss.org/browse/DROOLS-1397
> Project: Drools
> Issue Type: Bug
> Components: core engine, decision tables
> Affects Versions: 6.5.0.Final
> Environment: JDK 1.7, JUnit test, exact drools version is 6.5.0.Final-redhat-2
> Reporter: Patrick Mingard
> Assignee: Mario Fusco
> Priority: Minor
>
> I'm migrating an application that used drools 5.3 on the newer drools 6.5 version.
> I'm using a decision table, And one of my condition is accessing a Map which has an enum class as a key. It is not compiling unless I do a strange ArrayList cast.
> Please refer to [this stackoverflow topic|http://stackoverflow.com/questions/41461468/drools-condition-cannot...] for details.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1398) Use Maven for compiling the workbench projects
by Toni Rikkola (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1398?page=com.atlassian.jira.plugi... ]
Toni Rikkola reassigned DROOLS-1398:
------------------------------------
Assignee: Mario Fusco (was: Toni Rikkola)
> Use Maven for compiling the workbench projects
> ----------------------------------------------
>
> Key: DROOLS-1398
> URL: https://issues.jboss.org/browse/DROOLS-1398
> Project: Drools
> Issue Type: Feature Request
> Reporter: Toni Rikkola
> Assignee: Mario Fusco
>
> We currently use the kie-maven-plugin internally to compile the kjar's and only use Maven to provide the information about parent projects and dependencies for the project.
> Yet we have the power of Maven underneath and we do not use it. It is impossible to use simple features like ignoring folders or moving code. Or more complicated, for example if you have your own rule asset format and need a Maven plugin to generate the DRL out of it.
> However it is possible to set this functionality up. This causes problems:
> * Same git tag built in the workbench produce different results depending on the Workbench version that is being used. This means that if you want to rebuild a lost kjar, you need to install the same workbench version that was originally used to create the first one
> * Projects build in command line/build server can produce different kjars than the ones built with the workbench
> Benefits we gain for going full Maven:
> * Build the same artifacts anywhere
> * Make Maven build cycle usable
> * Make Maven plugins usable
> * Run tests with any test tooling, users are not limited to Test Scenarios
> What to keep in mind:
> * If we let the user set the KIE version for the kie-maven-plugin. The internal compiler still uses the version the workbench has.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months
[JBoss JIRA] (DROOLS-1397) Drools condition cannot retrieve object from Map with Enum key
by Patrick Mingard (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1397?page=com.atlassian.jira.plugi... ]
Patrick Mingard updated DROOLS-1397:
------------------------------------
Steps to Reproduce:
A fact :
{{ public class Convention {
[...]
private Map<ECommissionType, List<Commission>> commissions = new HashMap<>();
[...]
}}}
An enumeration :
{{ public enum ECommissionType {
ACQ,RIS,POF,[...]
}}}
And a rule condition assuming $convention is properly initialized in a former condition and is an instance of the Convention class shown) :
$comm : Commission() from $convention.getCommissions().get(ECommissionType.$1)
Compilation using kie-maven-plugin is raising an error :
Unable to Analyse Expression $convention.getCommissions().get(ECommissionType.RIS)):
sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl cannot be cast to java.lang.Class : [Rule name='B_CommissionLigne_98']
was:
A fact :
public class Convention {
[...]
private Map<ECommissionType, List<Commission>> commissions = new HashMap<>();
[...]
}
An enumeration :
public enum ECommissionType {
ACQ,RIS,POF,[...]
}
And a rule condition assuming `$convention` is properly initialized in a former condition and is an instance of the `Convention` class shown) :
$comm : Commission() from $convention.getCommissions().get(ECommissionType.$1)
Compilation using kie-maven-plugin is raising an error :
Unable to Analyse Expression $convention.getCommissions().get(ECommissionType.RIS)):
sun.reflect.generics.reflectiveObjects.ParameterizedTypeImpl cannot be cast to java.lang.Class : [Rule name='B_CommissionLigne_98']
> Drools condition cannot retrieve object from Map with Enum key
> --------------------------------------------------------------
>
> Key: DROOLS-1397
> URL: https://issues.jboss.org/browse/DROOLS-1397
> Project: Drools
> Issue Type: Bug
> Components: core engine, decision tables
> Affects Versions: 6.5.0.Final
> Environment: JDK 1.7, JUnit test, exact drools version is 6.5.0.Final-redhat-2
> Reporter: Patrick Mingard
> Assignee: Mario Fusco
> Priority: Minor
>
> I'm migrating an application that used drools 5.3 on the newer drools 6.5 version.
> I'm using a decision table, And one of my condition is accessing a Map which has an enum class as a key. It is not compiling unless I do a strange ArrayList cast.
> Please refer to [this stackoverflow topic|http://stackoverflow.com/questions/41461468/drools-condition-cannot...] for details.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 4 months