[JBoss JIRA] (DROOLS-1169) JDK9 with drools: upgrade ECJ to be jdk 9 compatible and remove "java native compiler" mvn profile workaround
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/DROOLS-1169?page=com.atlassian.jira.plugi... ]
Tomaz Cerar commented on DROOLS-1169:
-------------------------------------
ECJ 4.4.x works fine on JDK9 GA runtime.
As long as you still use -source/-target 8.
Which should be enough for get current systems working just fine.
> JDK9 with drools: upgrade ECJ to be jdk 9 compatible and remove "java native compiler" mvn profile workaround
> -------------------------------------------------------------------------------------------------------------
>
> Key: DROOLS-1169
> URL: https://issues.jboss.org/browse/DROOLS-1169
> Project: Drools
> Issue Type: Bug
> Components: core engine
> Reporter: Geoffrey De Smet
> Assignee: Mario Fusco
> Labels: java9
>
> The code below runs perfectly with OpenJDK 8 (and even 6 and 7).
> To reproduce, use JDK 9 ( https://jdk9.java.net/download/ ) and in optaplanner-core, run XStreamXmlSolverFactoryTest [1] (or mostly any other test that builds a DRL file) to get this error:
> {code}
> 15:56:40.229 [main] ERROR o.d.c.k.b.impl.AbstractKieModule - Unable to build KieBaseModel:defaultKieBase
> Rule Compilation error : [Rule name='Conflict']
> org/optaplanner/core/api/solver/Rule_Conflict903142795.java (1:0) : The type java.lang.Object cannot be resolved. It is indirectly referenced from required .class files
> org/optaplanner/core/api/solver/Rule_Conflict903142795.java (1:0) : The type java.io.Serializable cannot be resolved. It is indirectly referenced from required .class files
> org/optaplanner/core/api/solver/Rule_Conflict903142795.java (3:337) : Implicit super constructor Object() is undefined for default constructor. Must define an explicit constructor
> org/optaplanner/core/api/solver/Rule_Conflict903142795.java (6:569) : java.lang.Exception cannot be resolved to a type
> java.lang.IllegalStateException: There are errors in a score DRL:
> Error Messages:
> Message [id=1, level=ERROR, path=org/optaplanner/core/api/solver/testdataScoreRules.drl, line=31, column=0
> text=Rule Compilation error The type java.lang.Object cannot be resolved. It is indirectly referenced from required .class files
> The type java.io.Serializable cannot be resolved. It is indirectly referenced from required .class files
> Implicit super constructor Object() is undefined for default constructor. Must define an explicit constructor
> java.lang.Exception cannot be resolved to a type]
> {code}
> That tests builds this DRL:
> {code}
> package org.optaplanner.core.api.solver;
> dialect "java"
> import org.optaplanner.core.api.score.buildin.simple.SimpleScoreHolder;
> import org.optaplanner.core.impl.testdata.domain.TestdataValue;
> import org.optaplanner.core.impl.testdata.domain.TestdataEntity;
> global SimpleScoreHolder scoreHolder;
> // ############################################################################
> // Constraints
> // ############################################################################
> rule "Conflict"
> when
> TestdataEntity(value != null, $leftValue : value)
> TestdataEntity(value == $leftValue)
> then
> scoreHolder.addConstraintMatch(kcontext, -1);
> end
> {code}
> Not sure where the Object constructor reference comes from... This might be a JDK 9 upstream issue.
> Note: don't build drools with OpenJDK9 as that will fail sooner :)
> [1] https://github.com/droolsjbpm/optaplanner/blob/master/optaplanner-core/sr...
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (DROOLS-2077) Turn On Code Static Analysis for drools-wb repository
by Jozef Marko (JIRA)
[ https://issues.jboss.org/browse/DROOLS-2077?page=com.atlassian.jira.plugi... ]
Jozef Marko updated DROOLS-2077:
--------------------------------
Sprint: 2017 Week 43-44
> Turn On Code Static Analysis for drools-wb repository
> -----------------------------------------------------
>
> Key: DROOLS-2077
> URL: https://issues.jboss.org/browse/DROOLS-2077
> Project: Drools
> Issue Type: Task
> Components: Guided Decision Table Editor, Guided Decision Tree Editor, Guided Rule Editor, Guided Score Card Editor, Guided Template Editor, Test Scenarios Editor, XLS Decision Table Editor
> Affects Versions: 7.4.1.Final
> Reporter: Jozef Marko
> Assignee: Jozef Marko
>
> Add the configuration below to the pom.xml and make sure all modules of drools-wb repository are passing the build.
> {code:xml}
> <checkstyle.header.template><![CDATA[
> ^\/\*$\n^
> \* Copyright \d\d\d\d Red Hat, Inc\. and\/or its affiliates\.$\n^
> \*$\n^
> \* Licensed under the Apache License, Version 2\.0 \(the "License"\);$\n^
> \* you may not use this file except in compliance with the License\.$\n^
> \* You may obtain a copy of the License at$\n^
> \*$\n^
> \* http:\/\/www\.apache\.org\/licenses\/LICENSE-2\.0$\n^
> \*$\n^
> \* Unless required by applicable law or agreed to in writing, software$\n^
> \* distributed under the License is distributed on an "AS IS" BASIS,$\n^
> \* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied\.$\n^
> \* See the License for the specific language governing permissions and$\n^
> \* limitations under the License\.$\n^
> \*\/$
> ]]>
> </checkstyle.header.template>
> <checkstyle.failOnViolation>true</checkstyle.failOnViolation>
> <checkstyle.logViolationsToConsole>true</checkstyle.logViolationsToConsole>
> <jacoco.haltOnFailure>true</jacoco.haltOnFailure>
> {code}
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months
[JBoss JIRA] (WFCORE-3352) Reduce IO requirements of build
by Tomaz Cerar (JIRA)
[ https://issues.jboss.org/browse/WFCORE-3352?page=com.atlassian.jira.plugi... ]
Tomaz Cerar commented on WFCORE-3352:
-------------------------------------
Sent follow up PR that reverts the revert and removes all dependencies to build zip artifact as they are not needed anyways.
> Reduce IO requirements of build
> -------------------------------
>
> Key: WFCORE-3352
> URL: https://issues.jboss.org/browse/WFCORE-3352
> Project: WildFly Core
> Issue Type: Task
> Components: Test Suite
> Reporter: Tomaz Cerar
> Assignee: Tomaz Cerar
> Fix For: 4.0.0.Alpha1
>
>
> Currently we provision server way to often even when it is not needed.
> Whole wildfly-core should use thin provisioned server everywhere and create "inflated" server in dist folder only when running with -Drelease
--
This message was sent by Atlassian JIRA
(v7.5.0#75005)
8 years, 6 months