[JBoss JIRA] (ELY-958) Coverity static analysis: Dereference null return value in KeyUtil (Elytron)
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-958?page=com.atlassian.jira.plugin.sy... ]
Ilia Vassilev moved WFLY-7960 to ELY-958:
-----------------------------------------
Project: WildFly Elytron (was: WildFly)
Key: ELY-958 (was: WFLY-7960)
Component/s: (was: Security)
Affects Version/s: 1.1.0.Beta24
(was: 11.0.0.Alpha1)
> Coverity static analysis: Dereference null return value in KeyUtil (Elytron)
> ----------------------------------------------------------------------------
>
> Key: ELY-958
> URL: https://issues.jboss.org/browse/ELY-958
> Project: WildFly Elytron
> Issue Type: Bug
> Affects Versions: 1.1.0.Beta24
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
>
> Coverity static analysis found possible use of null object comming from {{RawPBEKey.getSalt()}} passed into {{javax.crypto.spec.PBEParameterSpec.PBEParameterSpec}}
> {code:java|title=javax.crypto.spec.PBEParameterSpec.java}
> public PBEParameterSpec(byte[] salt, int iterationCount) {
> this.salt = salt.clone();
> this.iterationCount = iterationCount;
> }
> {code}
> Responsible elytron code:
> {code:java|title=KeyUtils.java}
> if (key instanceof PBEKey && paramSpecClass.isAssignableFrom(PBEParameterSpec.class)) {
> final PBEKey pbeKey = (PBEKey) key;
> // TODO: we miss the IV here
> return paramSpecClass.cast(new PBEParameterSpec(pbeKey.getSalt(), pbeKey.getIterationCount()));
> }
> {code}
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=84906...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-957) Coverity static analysis: DefaultSingleSignOn.getIdentity() not synchronized
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-957?page=com.atlassian.jira.plugin.sy... ]
Ilia Vassilev moved WFLY-7959 to ELY-957:
-----------------------------------------
Project: WildFly Elytron (was: WildFly)
Key: ELY-957 (was: WFLY-7959)
Component/s: HTTP
(was: Security)
Affects Version/s: 1.1.0.Beta24
(was: 11.0.0.Alpha1)
> Coverity static analysis: DefaultSingleSignOn.getIdentity() not synchronized
> ----------------------------------------------------------------------------
>
> Key: ELY-957
> URL: https://issues.jboss.org/browse/ELY-957
> Project: WildFly Elytron
> Issue Type: Bug
> Components: HTTP
> Affects Versions: 1.1.0.Beta24
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Priority: Minor
>
> Coverity static-analysis scan found getter is not synchronized, while setter is.
> {code}
> public SecurityIdentity getIdentity() {
> return this.entry.getCachedIdentity().getSecurityIdentity();
> }
> {code}
> Current implementation is correct because in DefaultSingleSignOnEntry (currently only avalaible implementation of SingleSignOnEntry) cachedIdentity is volatile.
> However other implementations can be wrongly implemented. Once getIdentity() would be marked with synchronize modifier, such problem shouldn't occure.
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=84908...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-7093) Transfer of contextData back to the jboss ejb client
by Brad Maxwell (JIRA)
[ https://issues.jboss.org/browse/WFLY-7093?page=com.atlassian.jira.plugin.... ]
Brad Maxwell updated WFLY-7093:
-------------------------------
Attachment: MethodInvocationMessageHandler.java.diff
> Transfer of contextData back to the jboss ejb client
> ----------------------------------------------------
>
> Key: WFLY-7093
> URL: https://issues.jboss.org/browse/WFLY-7093
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 10.1.0.Final
> Reporter: Teresa Miyar
> Assignee: David Lloyd
> Priority: Minor
> Attachments: MethodInvocationMessageHandler.java.diff, MethodInvocationResponseHandler.java.diff
>
>
> The spec says:
> The getContextData method enables a business method, lifecycle callback method, or timeout method to retrieve any interceptor/webservices context associated with its invocation.
> The way this context data travels from client to server is by copying the data into a server context, this data is used inside the server ejb but not copied back to client. Client requests that this contextData is populated from client to server and vice versa.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-7093) Transfer of contextData back to the jboss ejb client
by Brad Maxwell (JIRA)
[ https://issues.jboss.org/browse/WFLY-7093?page=com.atlassian.jira.plugin.... ]
Brad Maxwell updated WFLY-7093:
-------------------------------
Attachment: MethodInvocationResponseHandler.java.diff
> Transfer of contextData back to the jboss ejb client
> ----------------------------------------------------
>
> Key: WFLY-7093
> URL: https://issues.jboss.org/browse/WFLY-7093
> Project: WildFly
> Issue Type: Bug
> Components: EJB
> Affects Versions: 10.1.0.Final
> Reporter: Teresa Miyar
> Assignee: David Lloyd
> Priority: Minor
> Attachments: MethodInvocationMessageHandler.java.diff, MethodInvocationResponseHandler.java.diff
>
>
> The spec says:
> The getContextData method enables a business method, lifecycle callback method, or timeout method to retrieve any interceptor/webservices context associated with its invocation.
> The way this context data travels from client to server is by copying the data into a server context, this data is used inside the server ejb but not copied back to client. Client requests that this contextData is populated from client to server and vice versa.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-955) Coverity static analysis: Dereference null return value in ServerAuthenticationContext (Elytron)
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/ELY-955?page=com.atlassian.jira.plugin.sy... ]
Ilia Vassilev moved WFLY-7965 to ELY-955:
-----------------------------------------
Project: WildFly Elytron (was: WildFly)
Key: ELY-955 (was: WFLY-7965)
Component/s: Authentication Mechanisms
(was: Security)
Affects Version/s: 1.1.0.Beta24
(was: 11.0.0.Alpha1)
> Coverity static analysis: Dereference null return value in ServerAuthenticationContext (Elytron)
> ------------------------------------------------------------------------------------------------
>
> Key: ELY-955
> URL: https://issues.jboss.org/browse/ELY-955
> Project: WildFly Elytron
> Issue Type: Bug
> Components: Authentication Mechanisms
> Affects Versions: 1.1.0.Beta24
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
>
> Coverity static-analysis scan found possible dereference null return value in following code
> {code:java|title=ServerAuthenticationContext.java}
> if (log.isTraceEnabled()) {
> log.tracef("Authorizing principal %s.", authenticationPrincipal.getName());
> log.tracef("Authorizing against the following attributes: %s => %s",
> authorizationIdentity.getAttributes().keySet(), authorizationIdentity.getAttributes().values());
> }
> {code}
> Coverity suppose null value could get here via {{AggregateSecurityRealm.Identity.getAuthorizationIdentity}} calling {{TokenSecurityRealm.TokenRealmIdentity.getAuthorizationIdentity}}
> {code:java|title=TokenRealmIdentity.java}
> @Override
> public AuthorizationIdentity getAuthorizationIdentity() throws RealmUnavailableException {
> if (exists()) {
> return new AuthorizationIdentity() {
> @Override
> public Attributes getAttributes() {
> return claims;
> }
> };
> }
> return null;
> }
> {code}
> https://scan7.coverity.com/reports.htm#v23632/p11778/fileInstanceId=85537...
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months