[JBoss JIRA] (ELY-770) Review SASL mechanism handling of isComplete()
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-770?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse updated ELY-770:
---------------------------------
Fix Version/s: 1.1.0.Beta32
(was: 1.1.0.Beta31)
> Review SASL mechanism handling of isComplete()
> ----------------------------------------------
>
> Key: ELY-770
> URL: https://issues.jboss.org/browse/ELY-770
> Project: WildFly Elytron
> Issue Type: Task
> Components: SASL
> Reporter: Darran Lofthouse
> Priority: Critical
> Fix For: 1.1.0.Beta32
>
>
> The javadoc of the isComplete() method states: -
> _Determines whether the authentication exchange has completed. This method is typically called after each invocation of evaluateResponse() to determine whether the authentication has completed successfully or should be continued._
> Also getAuthorizationID() states: -
> _Reports the authorization ID in effect for the client of this session. This method can only be called if isComplete() returns true.
> _
> Although the former is very vague there just seem to be a suggestion that complete means successfully complete, our mechs are setting complete very early and other wrappers such as AuthenticationCompleteCallbackSaslServerFactory are using complete as a flag to report failures.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (ELY-849) Rename setMechanismProperties to setSaslMechanismProperties
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/ELY-849?page=com.atlassian.jira.plugin.sy... ]
Darran Lofthouse updated ELY-849:
---------------------------------
Fix Version/s: 1.1.0.Beta32
(was: 1.1.0.Beta31)
> Rename setMechanismProperties to setSaslMechanismProperties
> -----------------------------------------------------------
>
> Key: ELY-849
> URL: https://issues.jboss.org/browse/ELY-849
> Project: WildFly Elytron
> Issue Type: Enhancement
> Components: Authentication Client
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Priority: Blocker
> Fix For: 1.1.0.Beta32
>
>
> If we later add HTTP mechanisms we have no way to differentiate between HTTP and SASL mechanism properties.
> We could probably share properties and rely on protocol matching in the MatchRule but as a single AuthenticationConfiguration will support both HTTP and SASL I think independent properties will be required.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month