[JBoss JIRA] (WFCORE-2497) Convert *-authentication-factory resources to be child resources of security-domain
by Darran Lofthouse (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2497?page=com.atlassian.jira.plugi... ]
Darran Lofthouse updated WFCORE-2497:
-------------------------------------
Fix Version/s: 3.0.0.Beta8
(was: 4.0.0.Alpha1)
> Convert *-authentication-factory resources to be child resources of security-domain
> -----------------------------------------------------------------------------------
>
> Key: WFCORE-2497
> URL: https://issues.jboss.org/browse/WFCORE-2497
> Project: WildFly Core
> Issue Type: Task
> Components: Security
> Reporter: Darran Lofthouse
> Assignee: Darran Lofthouse
> Fix For: 3.0.0.Beta8
>
>
> This is a good example of where child resources work.
> The authentication factory resources have a mandatory dependency on a single security domain.
> The configuration within the factory is related to it's security domain.
> There is only a single resource that can provide security domains.
> The behaviour of the parent is unaffected by the existence or configuration of the child.
> The parent and child manage their own services independently with the child's service depending on the parent's service.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month
[JBoss JIRA] (JGRP-2163) Potential NPE in TP.handleProbe
by Bela Ban (JIRA)
[ https://issues.jboss.org/browse/JGRP-2163?page=com.atlassian.jira.plugin.... ]
Bela Ban commented on JGRP-2163:
--------------------------------
If you look at the code which calls handleProbe(), you'll see that {{keys}} will never be null, but I fixed it anyway in 3.6. Master doesn't need the fix as it already has a null check.
> Potential NPE in TP.handleProbe
> -------------------------------
>
> Key: JGRP-2163
> URL: https://issues.jboss.org/browse/JGRP-2163
> Project: JGroups
> Issue Type: Bug
> Reporter: Zoltan Farkas
> Assignee: Bela Ban
> Priority: Minor
> Fix For: 3.6.14
>
>
> at:
> https://github.com/belaban/JGroups/blob/3.6/src/org/jgroups/protocols/TP....
> {code}
> public Map<String, String> handleProbe(String... keys) {
> Map<String,String> retval=new HashMap<>(keys != null? keys.length : 2);
> for(String key: keys) {
> {code}
> keys is checked for null and on the next line it is de-refferenced...
> this code fill fail with NPE if keys is null...
> This issue is discovered by findbugs NP_NULL_ON_SOME_PATH check. Highly recommend running findbugs + coverity (free for OS projects).
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 1 month