[JBoss JIRA] (DROOLS-760) Code style formatters are not actual
by Petr Široký (JIRA)
[ https://issues.jboss.org/browse/DROOLS-760?page=com.atlassian.jira.plugin... ]
Petr Široký commented on DROOLS-760:
------------------------------------
There were some changes related to formatting done by [~kgaevski]. I believe the formatters are now up-to-date. [~kgaevski] can you please confirm that?
> Code style formatters are not actual
> ------------------------------------
>
> Key: DROOLS-760
> URL: https://issues.jboss.org/browse/DROOLS-760
> Project: Drools
> Issue Type: Task
> Reporter: Tibor Zimányi
> Assignee: Petr Široký
> Priority: Minor
> Labels: reported-by-qe
> Attachments: code-styleQE.zip
>
>
> Code style formatters in git repo are not actual. Or not widely used. This causes that different styles are used in code.
> There should be some agreement about how the code should be written and this should be forced in PRs. This can remove many problems with whitespaces in PR diffs.
> Attached code style templates can be used as a base for new templates that (hope) will be used in Drools projects.
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-2462) CS tool, format Missing required option
by Martin Choma (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2462?page=com.atlassian.jira.plugi... ]
Martin Choma commented on WFCORE-2462:
--------------------------------------
Yes
> CS tool, format Missing required option
> ---------------------------------------
>
> Key: WFCORE-2462
> URL: https://issues.jboss.org/browse/WFCORE-2462
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Labels: credential-store, user_experience, wildfly-elytron-tool
>
> There is validation on required option.
> {code}
> [mchoma@localhost bin]$ java -jar wildfly-elytron-tool.jar credential-store
> Missing required option: [-a Add new alias to the credential store, -r Remove alias from the credential store, -e Check if alias exists within the credential store, -v Display all aliases, -h Get help with usage of this command][mchoma@localhost bin]$
> {code}
> However it is one line message. I would prefer mulitline message for readability as
> {code}
> [mchoma@localhost bin]$ java -jar wildfly-elytron-tool.jar credential-store
> Missing one of required options:
> -a Add new alias to the credential store,
> -r Remove alias from the credential store,
> -e Check if alias exists within the credential store,
> -v Display all aliases,
> -h Get help with usage of this command
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFCORE-2462) CS tool, format Missing required option
by Ilia Vassilev (JIRA)
[ https://issues.jboss.org/browse/WFCORE-2462?page=com.atlassian.jira.plugi... ]
Ilia Vassilev commented on WFCORE-2462:
---------------------------------------
[~mchoma] Since we will not change the code, can we close the issue?
> CS tool, format Missing required option
> ---------------------------------------
>
> Key: WFCORE-2462
> URL: https://issues.jboss.org/browse/WFCORE-2462
> Project: WildFly Core
> Issue Type: Bug
> Components: Security
> Reporter: Martin Choma
> Assignee: Ilia Vassilev
> Labels: credential-store, user_experience, wildfly-elytron-tool
>
> There is validation on required option.
> {code}
> [mchoma@localhost bin]$ java -jar wildfly-elytron-tool.jar credential-store
> Missing required option: [-a Add new alias to the credential store, -r Remove alias from the credential store, -e Check if alias exists within the credential store, -v Display all aliases, -h Get help with usage of this command][mchoma@localhost bin]$
> {code}
> However it is one line message. I would prefer mulitline message for readability as
> {code}
> [mchoma@localhost bin]$ java -jar wildfly-elytron-tool.jar credential-store
> Missing one of required options:
> -a Add new alias to the credential store,
> -r Remove alias from the credential store,
> -e Check if alias exists within the credential store,
> -v Display all aliases,
> -h Get help with usage of this command
> {code}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (WFLY-8321) IllegalArgumentException in autocomplete of driver-name of datasource add command with embedded server
by Michal Petrov (JIRA)
[ https://issues.jboss.org/browse/WFLY-8321?page=com.atlassian.jira.plugin.... ]
Michal Petrov moved JBEAP-9417 to WFLY-8321:
--------------------------------------------
Project: WildFly (was: JBoss Enterprise Application Platform)
Key: WFLY-8321 (was: JBEAP-9417)
Workflow: GIT Pull Request workflow (was: CDW with loose statuses v1)
Component/s: JCA
(was: JCA)
Affects Version/s: 11.0.0.Alpha1
(was: 7.1.0.DR13)
> IllegalArgumentException in autocomplete of driver-name of datasource add command with embedded server
> ------------------------------------------------------------------------------------------------------
>
> Key: WFLY-8321
> URL: https://issues.jboss.org/browse/WFLY-8321
> Project: WildFly
> Issue Type: Bug
> Components: JCA
> Affects Versions: 11.0.0.Alpha1
> Reporter: Michal Petrov
> Assignee: Michal Petrov
> Priority: Minor
>
> IllegalArgumentException in autocomplete of driver-name of datasource add command with embedded server
> {noformat}
> Exception in thread "Aesh Process Loop 1006094903" java.lang.IllegalArgumentException
> at org.jboss.dmr.ModelValue.asList(ModelValue.java:143)
> at org.jboss.dmr.ModelNode.asList(ModelNode.java:1566)
> at org.jboss.as.cli.handlers.jca.JDBCDriverNameProvider.getAllCandidates(JDBCDriverNameProvider.java:71)
> at org.jboss.as.cli.impl.DefaultCompleter.complete(DefaultCompleter.java:64)
> at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:276)
> at org.jboss.as.cli.operation.OperationRequestCompleter.complete(OperationRequestCompleter.java:89)
> at org.jboss.as.cli.CommandCompleter.doComplete(CommandCompleter.java:137)
> at org.jboss.as.cli.CommandCompleter.complete(CommandCompleter.java:64)
> at org.jboss.as.cli.impl.Console$Factory$1$1.complete(Console.java:143)
> at org.jboss.aesh.console.AeshCompletionHandler.complete(AeshCompletionHandler.java:155)
> at org.jboss.aesh.console.AeshInputProcessor.complete(AeshInputProcessor.java:429)
> at org.jboss.aesh.console.AeshInputProcessor.parseOperation(AeshInputProcessor.java:166)
> at org.jboss.aesh.console.Console.processInternalOperation(Console.java:778)
> at org.jboss.aesh.console.Console.execute(Console.java:738)
> at org.jboss.aesh.console.Console.access$900(Console.java:73)
> at org.jboss.aesh.console.Console$6.run(Console.java:647)
> at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> see. Steps to Reproduce
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-995) Elytron Audit Logging does not log principal if simple file format is used
by Jan Tymel (JIRA)
[ https://issues.jboss.org/browse/ELY-995?page=com.atlassian.jira.plugin.sy... ]
Jan Tymel updated ELY-995:
--------------------------
Attachment: deployment.war
> Elytron Audit Logging does not log principal if simple file format is used
> --------------------------------------------------------------------------
>
> Key: ELY-995
> URL: https://issues.jboss.org/browse/ELY-995
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Jan Tymel
> Priority: Critical
> Attachments: deployment.war
>
>
> _SIMPLE_ format of Elytron Audit Logging does not contain the information about the principal when the authentication is not successful. _JSON_ format contains such piece of information.
> Compare _JSON_ format
> {noformat}
> 3/8/17 3:53 PM,WARNING,{"event":"SecurityAuthenticationFailedEvent","event-time":"3/8/17 3:53 PM","security-identity":{"name":"anonymous","creation-time":"3/8/17 3:53 PM"},"success":false,"principal":"user"}
> {noformat}
> to _SIMPLE_ format
> {noformat}
> 3/8/17 3:54 PM,WARNING,event=SecurityAuthenticationFailedEvent,event-time=3/8/17 3:54 PM,security-identity=[name=anonymous,creation-time=3/8/17 3:54 PM],success=false}
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-995) Elytron Audit Logging does not log principal if simple file format is used
by Jan Tymel (JIRA)
[ https://issues.jboss.org/browse/ELY-995?page=com.atlassian.jira.plugin.sy... ]
Jan Tymel updated ELY-995:
--------------------------
Steps to Reproduce:
* Follow steps _Configure Elytron (default profile)_ in [blog post|http://javlog.cacek.cz/2017/01/enable-elytron-in-wildfly.html] in order to change default configuration to Elytron
* Start server and deploy attached war (containing servlet secured with BASIC HTTP auth)
* Access http://127.0.0.1:8080/protected/printRoles in a browser
* Fill in username and password (authentication will be unsuccessful no matter what is provided)
* Change format to simple: {{/subsystem=elytron/file-audit-log=local-audit:write-attribute(name=format,value=SIMPLE)}}
* Fill in username and password once more
* Check _JBOSS_HOME/standalone/log/audit.log_
was:
* Follow steps _Configure Elytron (default profile)_ in [blog post|http://javlog.cacek.cz/2017/01/enable-elytron-in-wildfly.html] in order to change default configuration to Elytron
* Start server and deploy attached war (containing servlet secured with BASIC HTTP auth)
* Access http://127.0.0.1:8080/protected/printRoles in a browser
* Fill in username and password (authentication will be unsuccessful no matter what is provided)
* Change format to simple: {{/subsystem=elytron/file-audit-log=local-audit:write-attribute(name=format,value=SIMPLE)}}
* Fill in username and password once more
* Check that _JBOSS_HOME/standalone/log/audit.log_
> Elytron Audit Logging does not log principal if simple file format is used
> --------------------------------------------------------------------------
>
> Key: ELY-995
> URL: https://issues.jboss.org/browse/ELY-995
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Jan Tymel
> Assignee: Darran Lofthouse
> Priority: Critical
> Attachments: deployment.war
>
>
> _SIMPLE_ format of Elytron Audit Logging does not contain the information about the principal when the authentication is not successful. _JSON_ format contains such piece of information.
> Compare _JSON_ format
> {noformat}
> 3/8/17 3:53 PM,WARNING,{"event":"SecurityAuthenticationFailedEvent","event-time":"3/8/17 3:53 PM","security-identity":{"name":"anonymous","creation-time":"3/8/17 3:53 PM"},"success":false,"principal":"user"}
> {noformat}
> to _SIMPLE_ format
> {noformat}
> 3/8/17 3:54 PM,WARNING,event=SecurityAuthenticationFailedEvent,event-time=3/8/17 3:54 PM,security-identity=[name=anonymous,creation-time=3/8/17 3:54 PM],success=false}
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-995) Elytron Audit Logging does not log principal if simple file format is used
by Jan Tymel (JIRA)
[ https://issues.jboss.org/browse/ELY-995?page=com.atlassian.jira.plugin.sy... ]
Jan Tymel reassigned ELY-995:
-----------------------------
Assignee: (was: Darran Lofthouse)
> Elytron Audit Logging does not log principal if simple file format is used
> --------------------------------------------------------------------------
>
> Key: ELY-995
> URL: https://issues.jboss.org/browse/ELY-995
> Project: WildFly Elytron
> Issue Type: Bug
> Reporter: Jan Tymel
> Priority: Critical
> Attachments: deployment.war
>
>
> _SIMPLE_ format of Elytron Audit Logging does not contain the information about the principal when the authentication is not successful. _JSON_ format contains such piece of information.
> Compare _JSON_ format
> {noformat}
> 3/8/17 3:53 PM,WARNING,{"event":"SecurityAuthenticationFailedEvent","event-time":"3/8/17 3:53 PM","security-identity":{"name":"anonymous","creation-time":"3/8/17 3:53 PM"},"success":false,"principal":"user"}
> {noformat}
> to _SIMPLE_ format
> {noformat}
> 3/8/17 3:54 PM,WARNING,event=SecurityAuthenticationFailedEvent,event-time=3/8/17 3:54 PM,security-identity=[name=anonymous,creation-time=3/8/17 3:54 PM],success=false}
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months
[JBoss JIRA] (ELY-995) Elytron Audit Logging does not log principal if simple file format is used
by Jan Tymel (JIRA)
Jan Tymel created ELY-995:
-----------------------------
Summary: Elytron Audit Logging does not log principal if simple file format is used
Key: ELY-995
URL: https://issues.jboss.org/browse/ELY-995
Project: WildFly Elytron
Issue Type: Bug
Reporter: Jan Tymel
Assignee: Darran Lofthouse
Priority: Critical
_SIMPLE_ format of Elytron Audit Logging does not contain the information about the principal when the authentication is not successful. _JSON_ format contains such piece of information.
Compare _JSON_ format
{noformat}
3/8/17 3:53 PM,WARNING,{"event":"SecurityAuthenticationFailedEvent","event-time":"3/8/17 3:53 PM","security-identity":{"name":"anonymous","creation-time":"3/8/17 3:53 PM"},"success":false,"principal":"user"}
{noformat}
to _SIMPLE_ format
{noformat}
3/8/17 3:54 PM,WARNING,event=SecurityAuthenticationFailedEvent,event-time=3/8/17 3:54 PM,security-identity=[name=anonymous,creation-time=3/8/17 3:54 PM],success=false}
{noformat}
--
This message was sent by Atlassian JIRA
(v7.2.3#72005)
9 years, 2 months